Bug 226669 - Merge Review: zip
Merge Review: zip
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:37 EST by Nobody's working on this, feel free to take it
Modified: 2009-12-10 10:20 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-12-10 10:20:43 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ruben: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:37:01 EST
Fedora Merge Review: zip

http://cvs.fedora.redhat.com/viewcvs/devel/zip/
Initial Owner: varekova@redhat.com
Comment 1 Ruben Kerkhof 2007-02-04 06:38:07 EST
Review for release 1.2.2:
* RPM name is OK
* Source zip231.tar.gz is the same as upstream
* Source zcrypt29.tar.gz is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Encoding should be UTF-8
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)

Minor:
* The latest version is 2.32

Notes:
* Please use {?dist} in the Release tag. See http://fedoraproject.org/wiki/DistTag for more info


Rpmlint is not silent:

Source RPM:
W: zip summary-ended-with-dot A file compression and packaging utility compatible with PKZIP.
E: zip tag-not-utf8 %changelog
W: zip invalid-license distributable
E: zip non-utf8-spec-file zip.spec
W: zip mixed-use-of-spaces-and-tabs (spaces: line 51, tab: line 47)

rpmlint of zip:
W: zip summary-ended-with-dot A file compression and packaging utility compatible with PKZIP.
E: zip tag-not-utf8 %changelog
W: zip invalid-license distributable
Comment 2 Ivana Varekova 2007-02-06 09:24:42 EST
I have not updated to 2.32 - but everything else should be fixed in  zip-2.31-2.fc7.
Comment 3 Ruben Kerkhof 2007-02-06 16:04:30 EST
Hi Ivana,

One last thing, please preserve timestamps when installing files (install -p or cp -p)
Comment 4 Ivana Varekova 2007-02-07 04:03:24 EST
Fixed in zip-2.31-3.fc7
Comment 5 Ruben Kerkhof 2007-02-07 16:00:12 EST
I don't think the file BUGS is very relevant and MANUAL is a duplicate of the manpage your already 
installing.

Please consider removing those.

I don't see any further blockers, so this package is approved.
Comment 6 Patrice Dumas 2007-02-16 15:31:12 EST
Some suggestions:

* The crypt29 source seems to be unavailable. I have found:
  ftp://ftp.uu.net/pub/archiving/zip/src/zcrypt29.zip

* rename exec-shield.patch zip-exec-shield.patch

* add README.CR to %doc

* replace %defattr(-,root,root) with %defattr(-,root,root,-)
Comment 7 Marcin Garski 2007-04-05 07:44:39 EDT
* What's the reasons not updating to 2.32?

* I'm not sure but probably zcrypt29.zip can br droped.

As it states in crypt.c (from 2.31 and 2.32):

  The main encryption/decryption source code for Info-Zip software was
  originally written in Europe.  To the best of our knowledge, it can
  be freely distributed in both source and object forms from any country,
  including the USA under License Exception TSU of the U.S. Export
  Administration Regulations (section 740.13(e)) of 6 June 2002.

  Prior to January 2000, re-export from the US was a violation of US law.

Enc/dec in 2.3{2,1} are newer then in zrypt29.zip

* Drop BUGS, as in 2.32 we can read:
"This file is likely out of date
17 May 2006"
Comment 8 Patrice Dumas 2008-02-05 11:55:15 EST
The bug should certainly be assigned to Ruben.

But the comments should also be addressed, in my opinion
the package is not really ready for inclusion without those
comments addressed.
Comment 9 Karel Klíč 2009-12-03 02:29:57 EST
All comments are probably addressed now:

- zip is updated to 3.0 in rawhide
- zcrypt29.zip has been dropped
- exec-shield.patch has been renamed

Note You need to log in before you can comment on or make changes to this bug.