Spec URL: https://farchord.fedorapeople.org/reviews/francis/francis.spec SRPM URL: https://farchord.fedorapeople.org/reviews/francis/francis-1.1.0-1.fc40.src.rpm Description: Francis uses the well-known pomodoro technique to help you get more productive. Fedora Account System Username: farchord
Taking this review.
Initial spec review: > Summary: Francis uses the well-known pomodoro technique to help you get more productive ... What? Also, this is horrible summary. What *is it*? > Url: https://apps.kde.org/en-gb/francis/ Use "URL: https://apps.kde.org/francis/" Also... write a real description.
Spec URL: https://farchord.fedorapeople.org/reviews/francis/francis.spec SRPM URL: https://farchord.fedorapeople.org/reviews/francis/francis-1.1.0-1.fc40.src.rpm Updated Source/summary/description
> Summary: Francis is a time tracking app for Plasma 6. Drop the name of the app and the period. Also, is it *only* for Plasma 6? > %description > Francis is a time tracking app using the well-known \ > pomodoro technique to help you get more productive. This is already a multi-line macro, you don't need `\`. > Url: Please use "URL:"
Spec URL: https://farchord.fedorapeople.org/reviews/francis/francis.spec SRPM URL: https://farchord.fedorapeople.org/reviews/francis/francis-1.1.0-1.fc40.src.rpm More description/url/summary changes
The package is missing "Requires: hicolor-icon-theme".
Spec URL: https://farchord.fedorapeople.org/reviews/francis/francis.spec SRPM URL: https://farchord.fedorapeople.org/reviews/francis/francis-1.1.0-1.fc40.src.rpm Updated requires
Copr build: https://copr.fedorainfracloud.org/coprs/build/7099419 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267483-francis/fedora-rawhide-x86_64/07099419-francis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7099422 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267483-francis/fedora-rawhide-x86_64/07099422-francis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7099418 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267483-francis/fedora-rawhide-x86_64/07099418-francis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7099416 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267483-francis/fedora-rawhide-x86_64/07099416-francis/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
Thank you for the review, Neal
The Pagure repository was created at https://src.fedoraproject.org/rpms/francis