Spec URL: https://download.copr.fedorainfracloud.org/results/loise/update-testing/fedora-rawhide-x86_64/07106741-qt6-qtquick3dphysics/qt6-qtquick3dphysics.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/loise/update-testing/fedora-rawhide-x86_64/07106741-qt6-qtquick3dphysics/qt6-qtquick3dphysics-6.6.2-1.fc41.src.rpm Description: Qt6 - Quick3D Physics Libraries and utilities Fedora Account System Username:loise
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
SPEC: https://download.copr.fedorainfracloud.org/results/loise/update-testing/fedora-rawhide-x86_64/07106741-qt6-qtquick3dphysics/qt6-qtquick3dphysics.spec SRPM: https://download.copr.fedorainfracloud.org/results/loise/update-testing/fedora-rawhide-x86_64/07106741-qt6-qtquick3dphysics/qt6-qtquick3dphysics-6.6.2-1.fc41.src.rpm
Spec URL:https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysics/fedora-rawhide-x86_64/07106792-qt6-qtquick3dphysics/qt6-qtquick3dphysics.spec SRPM URL:https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysics/fedora-rawhide-x86_64/07106792-qt6-qtquick3dphysics/qt6-qtquick3dphysics-6.6.2-1.fc41.src.rpm Description: Qt6 - Quick3D Physics Libraries and utilities Fedora Account System Username:loise
1) Looks like BR: qt6-qtbase-static and qt6-qtdeclarative-static are not needed? At least I can build it without it and don't see any complain 2) The commented workaround can be dropped if the issue was fixed in GCC? 3) Was there an alternative of the cooker binary in Qt5? If not, we might not need to add the -qt6 suffix? 4) I think the thing checking "QMAKE_PRL_BUILD_DIR" is not needed? I guess it's not needed in any of Qt6 package we have and should be perhaps removed? I'm guessing because it's qmake related and we don't use qmake anymore. I also don't see any *.la library being installed. 5) Shouldn't this package own %{_qt6_libdir}/cmake/Qt6Quick3DPhysics and similar directories?
(In reply to Jan Grulich from comment #4) > 1) Looks like BR: qt6-qtbase-static and qt6-qtdeclarative-static are not > needed? At least I can build it without it and don't see any complain Well, then drop them :) > 2) The commented workaround can be dropped if the issue was fixed in GCC? Yes > 3) Was there an alternative of the cooker binary in Qt5? If not, we might > not need to add the -qt6 suffix? That's already a presumption that we will end up with a -qt7 version in the future. The package is new, so you're right, it's not needed really. Drop it if you want :) > 4) I think the thing checking "QMAKE_PRL_BUILD_DIR" is not needed? I guess > it's not needed in any of Qt6 package we have and should be perhaps removed? > I'm guessing because it's qmake related and we don't use qmake anymore. I > also don't see any *.la library being installed. yes, we're using cmake, not qmake. I simply copied that from another qt6 package :) so drop it if we drop it everywhere ? > 5) Shouldn't this package own %{_qt6_libdir}/cmake/Qt6Quick3DPhysics and > similar directories? ah yes, I'm sorry I forgot that. It's owned only by this package, yes. Do you want me to fix this or are you doing it while at it and just import so we get this out the door ? admin will be kde-sig anyway, so there's not necessity for me to own the package at all.
Please, fix it and post here updated SPEC file :).
Spec URL: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysics/fedora-rawhide-x86_64/07115571-qt6-qtquick3dphysics/qt6-qtquick3dphysics.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysics/fedora-rawhide-x86_64/07115571-qt6-qtquick3dphysics/qt6-qtquick3dphysics-6.6.2-1.fc41.src.rpm
I think we need to use "%dir path" for every directory owned by the package. E.g. %dir %{_qt6_libdir}/cmake/Qt6Quick3DPhysics/ %{_qt6_libdir}/cmake/Qt6Quick3DPhysics/*.cmake At least that's my understanding of this macro and that without it, when uninstalling, it would remove all the files in that directory, except the directory itself.
Spec URL: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysics/fedora-rawhide-x86_64/07115766-qt6-qtquick3dphysics/qt6-qtquick3dphysics.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysics/fedora-rawhide-x86_64/07115766-qt6-qtquick3dphysics/qt6-qtquick3dphysics-6.6.2-1.fc41.src.rpm Sorry, I forgot about that part :) fixed.
Doesn't it report now that files are listed twice? :)
Spec URL: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysics/fedora-rawhide-x86_64/07115974-qt6-qtquick3dphysics/qt6-qtquick3dphysics.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysics/fedora-rawhide-x86_64/07115974-qt6-qtquick3dphysics/qt6-qtquick3dphysics-6.6.2-1.fc41.src.rpm Now they don't anymore :)
Looks good to me now. Package approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtquick3dphysics