Bug 2268800 - Crash in openQA testing when changing wallpaper to solid color and clicking on the color picker
Summary: Crash in openQA testing when changing wallpaper to solid color and clicking o...
Alias: None
Product: Fedora
Classification: Fedora
Component: mesa
Version: rawhide
Hardware: x86_64
OS: Linux
Target Milestone: ---
Assignee: Adam Jackson
QA Contact: Fedora Extras Quality Assurance
Whiteboard: openqa
Depends On:
TreeView+ depends on / blocked
Reported: 2024-03-10 17:07 UTC by Adam Williamson
Modified: 2024-03-14 12:50 UTC (History)
18 users (show)

Fixed In Version: mesa-24.0.3-1.fc41
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2024-03-14 12:50:17 UTC
Type: Bug

Attachments (Terms of Use)
backtrace of the crash (118.67 KB, text/plain)
2024-03-10 17:08 UTC, Adam Williamson
no flags Details

System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FC-1138 0 None None None 2024-03-11 21:34:46 UTC

Description Adam Williamson 2024-03-10 17:07:27 UTC
We have a test in openQA which starts out by trying to set the wallpaper to solid black (for more screenshot matching consistency). It goes to the wallpaper settings, changes from "Image" to "Plain Color", then clicks on the little color square that should launch the color picker.

Since Fedora-Rawhide-20240307.n.0 , doing this seems to consistently cause plasmashell to crash. I have backtraced the crash, and it's a bunch of LLVM stuff I can't make head or tail of. Attaching the backtrace.

Comment 1 Adam Williamson 2024-03-10 17:08:20 UTC
Created attachment 2020992 [details]
backtrace of the crash

Comment 2 Alessandro Astone 2024-03-10 17:53:39 UTC
Caused by mesa-24.0.2

Since it works in mesa-24.0.0 it should be easy to git blame.

Comment 3 Alessandro Astone 2024-03-10 18:18:05 UTC
Unfortunately it's not a change in mesa, but rather mesa-24.0.2 was the first built against LLVM18.

Mesa @ git main compiled against LLVM18 is also broken

Comment 4 Nikita Popov 2024-03-11 13:41:29 UTC
I believe this patch to mesa should fix the issue:

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c b/src/gallium/auxiliary/gallivm/lp_bld_init.c
index cd2108f3a08..1345d85b224 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_init.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_init.c
@@ -609,7 +609,11 @@ gallivm_compile_module(struct gallivm_state *gallivm)
    LLVMRunPasses(gallivm->module, passes, LLVMGetExecutionEngineTargetMachine(gallivm->engine), opts);
    if (!(gallivm_perf & GALLIVM_PERF_NO_OPT))
+      strcpy(passes, "sroa,early-cse,simplifycfg,reassociate,mem2reg,instsimplify,instcombine<no-verify-fixpoint>");
       strcpy(passes, "sroa,early-cse,simplifycfg,reassociate,mem2reg,instsimplify,instcombine");
       strcpy(passes, "mem2reg");

Comment 5 Nikita Popov 2024-03-11 13:55:31 UTC
I went ahead and submitted a mesa PR with that change here: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28101

I hope someone else can verify that this indeed resolves the problem, as I'm not familiar with how to test mesa changes.

Comment 6 Alessandro Astone 2024-03-11 14:02:45 UTC
Yes, that fixes the issue; thank you.

Comment 7 Nikita Popov 2024-03-11 16:39:08 UTC
Thanks for confirming!

I've opened a PR with this patch against dist-git here: https://src.fedoraproject.org/rpms/mesa/pull-request/46

Comment 8 Fedora Update System 2024-03-14 11:08:47 UTC
FEDORA-2024-f0e8a6a5d8 (mesa-24.0.3-1.fc41) has been submitted as an update to Fedora 41.

Comment 9 Fedora Update System 2024-03-14 12:50:17 UTC
FEDORA-2024-f0e8a6a5d8 (mesa-24.0.3-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.