Spec URL: https://ngompa.fedorapeople.org/for-review/apk-tools.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/apk-tools-2.14.1-1.fc40.src.rpm Description: The Alpine Package Keeper (APK) is a suite of tools to implement the package management solution made for Alpine Linux. Fedora Account System Username: ngompa
Copr build: https://copr.fedorainfracloud.org/coprs/build/7138010 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2269042-apk-tools/fedora-rawhide-x86_64/07138010-apk-tools/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Notes: * libfetch is vendored into the source tree. Should this be packaged and depended on, or is this not the kind of bundling that's a problem? * apk-tools does run, but fails on most operations without a database. Expected? * Technically upstream does provide tests, but only a very basic smoke test. Could be included in %check if possible. * Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Reviewer: apk.so not in `ldconfig -p` output after install [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc, /usr/src, /usr/lib64/lua/5.4, /usr/share/man/man5, /usr/lib64/lua, /usr/lib, /usr/sbin, /usr/lib64, /usr/include, /usr/src/debug, /usr/lib64/pkgconfig, /usr/share, /usr/share/licenses, /usr, /usr/share/man, /usr/share/man/man8 Reviewer: /usr/lib64/lua comes from lua-libs, required via lua(abi). The rest of these are standard LFH dirs as far as I can tell, so I'm not sure why rpmlint complains about them? [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc, /usr/lib64/lua/5.4, /usr/share, /usr/share/man/man5, /usr/lib64/lua, /usr/lib, /usr, /usr/sbin, /usr/share/licenses, /usr/share/man, /usr/lib64, /usr/include, /usr/src/debug, /usr/src, /usr/share/man/man8, /usr/lib64/pkgconfig [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. Notes: libfetch is bundled in sources. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 193 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lua-apk , libapk , libapk-devel Reviewer: lua-apk depends on libapk - %{name} is apk-tools [!]: Package functions as described. Reviewer: Package installs and help text works, but database is not initialized. [x]: Latest version is packaged. [?]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Reviewer: Upstream does not publish source signatures [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Reviewer: Project does have tests but they appear to be only extremely basic smoke tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: apk-tools-2.14.1-1.fc41.x86_64.rpm lua-apk-2.14.1-1.fc41.x86_64.rpm libapk-2.14.1-1.fc41.x86_64.rpm libapk-devel-2.14.1-1.fc41.x86_64.rpm apk-tools-debuginfo-2.14.1-1.fc41.x86_64.rpm apk-tools-debugsource-2.14.1-1.fc41.x86_64.rpm apk-tools-2.14.1-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjlxapmwc')] checks: 32, packages: 7 Rpmlint (debuginfo) ------------------- Checking: apk-tools-debuginfo-2.14.1-1.fc41.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpw9_vg8q3')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 10 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "libapk-devel". (none): E: there is no installed rpm "apk-tools-debuginfo". (none): E: there is no installed rpm "lua-apk". (none): E: there is no installed rpm "apk-tools". (none): E: there is no installed rpm "apk-tools-debugsource". (none): E: there is no installed rpm "libapk". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- lua-apk: /usr/lib64/lua/5.4/apk.so Source checksums ---------------- https://gitlab.alpinelinux.org/alpine/apk-tools/-/archive/v2.14.1/apk-tools-v2.14.1.tar.gz : CHECKSUM(SHA256) this package : c06487563cae9e92161dfe1a81e714f700229cc0ad075b6c26ac3f157892e732 CHECKSUM(SHA256) upstream package : c06487563cae9e92161dfe1a81e714f700229cc0ad075b6c26ac3f157892e732 Requires -------- apk-tools (rpmlib, GLIBC filtered): libapk(x86-64) libapk.so.2.14.0()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) lua-apk (rpmlib, GLIBC filtered): libapk(x86-64) libapk.so.2.14.0()(64bit) libc.so.6()(64bit) lua(abi) rtld(GNU_HASH) libapk (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) libapk-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libapk(x86-64) libapk.so.2.14.0()(64bit) pkgconfig(openssl) pkgconfig(zlib) apk-tools-debuginfo (rpmlib, GLIBC filtered): apk-tools-debugsource (rpmlib, GLIBC filtered): Provides -------- apk-tools: apk-tools apk-tools(x86-64) lua-apk: lua-apk lua-apk(x86-64) libapk: libapk libapk(x86-64) libapk.so.2.14.0()(64bit) libapk-devel: libapk-devel libapk-devel(x86-64) pkgconfig(apk) apk-tools-debuginfo: apk-tools-debuginfo apk-tools-debuginfo(x86-64) debuginfo(build-id) apk-tools-debugsource: apk-tools-debugsource apk-tools-debugsource(x86-64)
(In reply to Dalton Miner from comment #2) > Notes: > * libfetch is vendored into the source tree. Should this be packaged and > depended on, or is this not the kind of bundling that's a problem? If it was not modified for apk-tools' usage, it could have been. I will talk to upstream about what their plans are for apk3. > * apk-tools does run, but fails on most operations without a database. > Expected? Yes, this is expected. apt+dpkg and pacman similarly fail. > * Technically upstream does provide tests, but only a very basic smoke test. > Could be included in %check if possible. I've added a check section to run the tests.
[fedora-review-service-build]
(In reply to Neal Gompa from comment #3) > (In reply to Dalton Miner from comment #2) > > Notes: > > * libfetch is vendored into the source tree. Should this be packaged and > > depended on, or is this not the kind of bundling that's a problem? > > If it was not modified for apk-tools' usage, it could have been. I will talk > to upstream about what their plans are for apk3. Thanks! I see that it's included as a bundled provides now. > > * apk-tools does run, but fails on most operations without a database. > > Expected? > > Yes, this is expected. apt+dpkg and pacman similarly fail. Ok, fair enough. > > * Technically upstream does provide tests, but only a very basic smoke test. > > Could be included in %check if possible. > > I've added a check section to run the tests. Nice! Ok, that's all the concerns I had.
The Pagure repository was created at https://src.fedoraproject.org/rpms/apk-tools
FEDORA-2024-aa60913838 (apk-tools-2.14.1-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-aa60913838
FEDORA-2024-b40411db98 (apk-tools-2.14.1-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b40411db98
FEDORA-2024-076f1f6b46 (apk-tools-2.14.1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-076f1f6b46
FEDORA-2024-076f1f6b46 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-076f1f6b46 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-076f1f6b46 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-aa60913838 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-aa60913838 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-aa60913838 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b40411db98 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b40411db98 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b40411db98 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-076f1f6b46 (apk-tools-2.14.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-b40411db98 (apk-tools-2.14.1-1.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-aa60913838 (apk-tools-2.14.1-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.