Spec URL: https://farchord.fedorapeople.org/reviews/ruqola/ruqola.spec SRPM URL: https://farchord.fedorapeople.org/reviews/ruqola/ruqola-2.1.0-1.fc40.src.rpm Description: Ruqola is a Rocket chat client for the KDE desktop. Fedora Account System Username: farchord
FYI for this review, I split off the documentation to a separate package. But I wasn't sure if I needed/wanted to set the documentation to be required to be installed on runtime. I would appreciate feedback here.
Spec URL: https://farchord.fedorapeople.org/reviews/ruqola/ruqola.spec SRPM URL: https://farchord.fedorapeople.org/reviews/ruqola/ruqola-2.1.0-1.fc40.src.rpm Removed doc requirement, changed libdir macros in %files
Copr build: https://copr.fedorainfracloud.org/coprs/build/7155762 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2269281-ruqola/fedora-rawhide-x86_64/07155762-ruqola/fedora-review/review.txt Found issues: - License file moc_licensesisenterprisejob.cpp is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7156066 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2269281-ruqola/fedora-rawhide-x86_64/07156066-ruqola/fedora-review/review.txt Found issues: - License file moc_licensesisenterprisejob.cpp is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://farchord.fedorapeople.org/reviews/ruqola/ruqola.spec SRPM URL: https://farchord.fedorapeople.org/reviews/ruqola/ruqola-2.1.0-1.fc40.src.rpm Set the doc subpkg as noarch
Created attachment 2021857 [details] The .spec file difference from Copr build 7156066 to 7165575
Copr build: https://copr.fedorainfracloud.org/coprs/build/7165575 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2269281-ruqola/fedora-rawhide-x86_64/07165575-ruqola/fedora-review/review.txt Found issues: - License file moc_licensesisenterprisejob.cpp is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
Thank you for the review, Neal
The Pagure repository was created at https://src.fedoraproject.org/rpms/ruqola
FEDORA-2024-6e828b7340 (Initial release of ruqola) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6e828b7340
FEDORA-2024-6e828b7340 (Initial release of ruqola) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.