Bug 2269901 - Review Request: golang-github-gohugoio-hugo-goldmark-extensions - A collection of Goldmark extensions created by the Hugo community
Summary: Review Request: golang-github-gohugoio-hugo-goldmark-extensions - A collectio...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2209669
TreeView+ depends on / blocked
 
Reported: 2024-03-17 01:39 UTC by W. Michael Petullo
Modified: 2024-03-17 21:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-03-17 20:41:20 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2024-03-17 01:39:40 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-hugo-goldmark-extensions.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-hugo-goldmark-extensions-v0.2.0-1.20240317gitpassthrough.v0.2.0.fc39.src.rpm
Description: A collection of Goldmark extensions created by the Hugo community
Fedora Account System Username: mikep

This one is a little strange. First, the version and tag are set a little differently. Second, I had to modify the Hugo package to contain an explicit BuildRequires of golang-github-gohugoio-hugo-goldmark-extensions-devel to build in COPR. Using "golang(...)" did not work, and leaving things to the implicit requires also did not work. I have not yet figured out why this is the case.

Comment 1 Mikel Olasagasti Uranga 2024-03-17 19:21:50 UTC
>  Version:                v0.2.0

Remove the `v` from it unless there is a strong reason to keep it.

> %global distprefix      %{nil}

Add this after the "%global tag" to have a shorter name.

Comment 3 Mikel Olasagasti Uranga 2024-03-17 20:08:51 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 4 Fedora Admin user for bugzilla script actions 2024-03-17 20:19:52 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gohugoio-hugo-goldmark-extensions

Comment 5 Fedora Update System 2024-03-17 20:37:55 UTC
FEDORA-2024-6cb4f04cd5 (golang-github-gohugoio-hugo-goldmark-extensions-0.2.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6cb4f04cd5

Comment 6 Fedora Update System 2024-03-17 20:41:20 UTC
FEDORA-2024-6cb4f04cd5 (golang-github-gohugoio-hugo-goldmark-extensions-0.2.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Review Service 2024-03-17 21:55:28 UTC
There seems to be some problem with the following file.
SRPM URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-hugo-goldmark-extensions-v0.2.0-1.20240317gitpassthrough.v0.2.0.fc39.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.