Spec URL: http://people.atrpms.net/~hdegoede/gemdropx.spec SRPM URL: http://people.atrpms.net/~hdegoede/gemdropx-0.9-1.fc7.src.rpm Description: Gem Drop X is a fast-paced puzzle game where it is your job to clear the screen of gems before they squash you.
Well, * BuildRequires - Mockbuild fails on FC7 i386 (needs desktop-file-utils) * Documentation - Please add other "README" files * Timestamps - keep timestamps on image files and etc, i.e. use "cp -p" or "install -p" * Desktop file entry ----------------------------------------------------- --add-category X-Fedora \ ----------------------------------------------------- is deprecated and should be removed. * Scriptlets ----------------------------------------------------- if [ -x %{_bindir}/gtk-update-icon-cache ]; then ----------------------------------------------------- is redundant because execution of non-existing file simply exits with 127 and is ignored by || :
(In reply to comment #1) > Well, > > * BuildRequires > - Mockbuild fails on FC7 i386 (needs desktop-file-utils) > Oops, can't believe I forgot that, fixed. > * Documentation > - Please add other "README" files > I assume you mean INSTALL.txt ICON.txt and TODO.txt? INSTALL.txt and ICON.txt both contain installation instructions and thus should not be packaged. I've added TODO.txt > * Timestamps > - keep timestamps on image files and etc, i.e. use "cp -p" > or "install -p" > Fixed > * Desktop file entry > ----------------------------------------------------- > --add-category X-Fedora \ > ----------------------------------------------------- > is deprecated and should be removed. > > * Scriptlets > ----------------------------------------------------- > if [ -x %{_bindir}/gtk-update-icon-cache ]; then > ----------------------------------------------------- > is redundant because execution of non-existing file > simply exits with 127 and is ignored by || : I've been doing things like this for over a year now, I know there was some discussion about both of these but I never followed it close enough to learn the new guidelines, to busy with other Fedora stuff. I've read the new guidelines now, thanks for straightening me out on this -> Both fixed. Here is a new version with all this fixed: Spec URL: http://people.atrpms.net/~hdegoede/gemdropx.spec SRPM URL: http://people.atrpms.net/~hdegoede/gemdropx-0.9-2.fc7.src.rpm
(In reply to comment #2) > > * Documentation > > - Please add other "README" files > > > I assume you mean INSTALL.txt ICON.txt and TODO.txt? > INSTALL.txt and ICON.txt both contain installation instructions and thus should > not be packaged. I've added TODO.txt Ah.. I meant: ---------------------------------------- ./data/images/README ./data/sounds/README ./README.txt ./action/README.txt ---------------------------------------- These files explains where the image/sounds files came from and I think adding these files is kinder.
(In reply to comment #3) > (In reply to comment #2) > > > * Documentation > > > - Please add other "README" files > > > > > I assume you mean INSTALL.txt ICON.txt and TODO.txt? > > INSTALL.txt and ICON.txt both contain installation instructions and thus should > > not be packaged. I've added TODO.txt > > Ah.. I meant: > ---------------------------------------- > ./data/images/README > ./data/sounds/README > ./README.txt > ./action/README.txt > ---------------------------------------- > These files explains where the image/sounds files came > from and I think adding these files is kinder. I see, Good idea, new version with these files added is here: Spec URL: http://people.atrpms.net/~hdegoede/gemdropx.spec SRPM URL: http://people.atrpms.net/~hdegoede/gemdropx-0.9-2.fc7.src.rpm
Well, I will check 0.9-2 later. By the way, would you tell me in advance to which repository (FE-7/6/5) you want to import this package? (I currently don't know how the new review process will become... and.. do I have to ask the submitter in advance??)
Its intended for FE-6 and devel.
Okay. ---------------------------------------------------- This package is APPROVED by me with the following summary: * Owner: j.w.r.degoede * Name: gemdropx * Summary: Falling blocks puzzlegame * Branch: FC-devel FC-6 ----------------------------------------------------- Requesting cvs admin for making initial directories. Please wait until cvs admin answers on this bug.
Imported and build for FC-6 and devel, closing. p.s. Thanks for the review!
You are welcome!