Spec URL: https://hiwkby.fedorapeople.org/python-pyngus.spec SRPM URL: https://hiwkby.fedorapeople.org/python-pyngus-2.3.1-1.fc41.src.rpm Description: Callback API implemented over Proton A connection oriented messaging framework using QPID Proton. It provides a callback-based API for message passing. Fedora Account System Username: hiwkby This is a "re-review" request needed to claim ownership of a retired package. This package retired in Fedora39 due to mass build failure[1] because a dependent package lost its "Provides" information. I recently fixed the problem[2]. --- 1: https://bugzilla.redhat.com/show_bug.cgi?id=2184027 2: https://src.fedoraproject.org/rpms/qpid-proton/pull-request/5
Koji scratch build result(success) https://koji.fedoraproject.org/koji/taskinfo?taskID=115103259
Copr build: https://copr.fedorainfracloud.org/coprs/build/7179814 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270021-python-pyngus/fedora-rawhide-x86_64/07179814-python-pyngus/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'ASL 2.0'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-pyngus Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hello Benson, Thanks you very much for the review! I fixed the issue. Please see: Spec URL: https://hiwkby.fedorapeople.org/python-pyngus.spec SRPM URL: https://hiwkby.fedorapeople.org/python-pyngus-2.3.1-2.fc41.src.rpm Here is the diff between the old spec file and the new one. ``` $ diff -c python-pyngus.spec.old python-pyngus.spec *** python-pyngus.spec.old Mon Mar 18 08:47:20 2024 --- python-pyngus.spec Tue Mar 19 01:17:28 2024 *************** *** 2,11 **** Name: python-%{srcname} Version: 2.3.1 ! Release: 1%{?dist} Summary: Callback API implemented over Proton ! License: ASL 2.0 URL: https://github.com/kgiusti/%{srcname} # Upstream does not provides the latest version from git. # Please see: https://github.com/kgiusti/pyngus/issues/14 --- 2,11 ---- Name: python-%{srcname} Version: 2.3.1 ! Release: 2%{?dist} Summary: Callback API implemented over Proton ! License: Apache-2.0 URL: https://github.com/kgiusti/%{srcname} # Upstream does not provides the latest version from git. # Please see: https://github.com/kgiusti/pyngus/issues/14 *************** *** 46,51 **** --- 46,54 ---- %{python3_sitelib}/%{srcname}-*.dist-info/ %changelog + * Tue Mar 19 2024 Hirotaka Wakabayashi <hiwkby> - 2.3.1-2 + - Applies license-fedora2spdx + * Fri Mar 15 2024 Hirotaka Wakabayashi <hiwkby> - 2.3.1-1 - Untretire python-pyngus - Updates python-pyngus-2.3.1 ``` Koji scratch build result(success) https://koji.fedoraproject.org/koji/taskinfo?taskID=115138123 Thanks in advance, Hirotaka
Created attachment 2022400 [details] The .spec file difference from Copr build 7179814 to 7181296
Copr build: https://copr.fedorainfracloud.org/coprs/build/7181296 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270021-python-pyngus/fedora-rawhide-x86_64/07181296-python-pyngus/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-pyngus Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hello Benson, thanks for the review! (In reply to Fedora Review Service from comment #5) ...(snip)... > Found issues: > > - A package with this name already exists. Please check > https://src.fedoraproject.org/rpms/python-pyngus I think this is a false-positive issue because there is no package conflict but the package of this review request is exactly same with the above package, which is retired last year. To un-retire the above package, we should follow the Package Retirement Process as followings. ``` Retired Fedora packages (rawhide branch retired) require a re-review if they are retired for more than eight weeks or if there is no previous review of the package. Submit a review request (a new bugzilla ticket) and have the package approved by a reviewer as if it were new to Fedora. ``` https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/ Thanks in advance, Hirotaka
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-pyngus See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "*No copyright* Apache License". 8 files have unknown license. Detailed output of licensecheck in /home/fedora/2270021-python- pyngus/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.12, /usr/lib/python3.12/site- packages [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4137 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pyngus-2.3.1-2.fc41.noarch.rpm python-pyngus-2.3.1-2.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_9enmtlc')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pyngus/pyngus-2.3.1.tar.gz : CHECKSUM(SHA256) this package : d925868637fcaf2b6a2174137d39af909d1e95f5c8a27c816b55b5a204e9240d CHECKSUM(SHA256) upstream package : d925868637fcaf2b6a2174137d39af909d1e95f5c8a27c816b55b5a204e9240d Requires -------- python3-pyngus (rpmlib, GLIBC filtered): python(abi) python3.12dist(python-qpid-proton) Provides -------- python3-pyngus: python-pyngus python3-pyngus python3.12-pyngus python3.12dist(pyngus) python3dist(pyngus) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2270021 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Python, Shell-api Disabled plugins: PHP, Java, Perl, Haskell, fonts, SugarActivity, R, C/C++, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) The warning about existing repo is fine, applies to new packages to ensure there are no name collisions. b) Can some of the tests be run? As the tests are not distributed with the source on Pypi, will need to get source from GitHub. If tests can not be run, perhaps check the package imports: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests there is also a %pyproject_check_import macro c) Can you use the %pyproject_save_files and %{pyproject_files} macros: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file d) License is packaged twice at: /usr/share/licenses/python3-pyngus/LICENSE /usr/lib/python3.12/site-packages/pyngus-2.3.1.dist-info/LICENSE though this is ok as metadata for the file in dist-info is missing: $ rpm -qL python3-pyngus-2.3.1-2.fc41.noarch.rpm /usr/share/licenses/python3-pyngus/LICENSE
Hello Benson, Thanks for the comments, I have fixed the issues as followings. Spec URL: https://hiwkby.fedorapeople.org/python-pyngus.spec SRPM URL: https://hiwkby.fedorapeople.org/python-pyngus-2.3.1-3.fc41.src.rpm (In reply to Benson Muite from comment #7) > Package Review > ...(snip)... > > Comments: > a) The warning about existing repo is fine, applies to new packages to > ensure there are no name collisions. Thanks for your understanding. > b) Can some of the tests be run? As the tests are not distributed with the > source on Pypi, will need to get > source from GitHub. If tests can not be run, perhaps check the package > imports: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests > there is also a %pyproject_check_import macro This package uses sources from PyPI because the upstream distributes the latest version from PyPI. I am asking the upstream to add the latest version tag from GitHub. Please see: https://github.com/kgiusti/pyngus/issues/14 Here are the tests results in my development environment. Two test cases skipped that may require additional settings for SASL. ``` [build@0fc92489fe13 pyngus (master *)]$ PYTHONPATH=.:tests tests/test-runner -i "unit_tests.connection.CyrusTest.test_cyrus_sasl_ok" -i "unit_tests.connection.CyrusTest.test_cyrus_sasl_fail" /home/build/dev/fedora_packaging/python-pyngus/pyngus/tests/test-runner:26: DeprecationWarning: 'cgi' is deprecated and slated for removal in Python 3.13 import logging, optparse, os, struct, sys, time, traceback, types, cgi unit_tests.connection.APITest.test_abort ...................................................................................................................................................................... pass unit_tests.connection.APITest.test_accept_receiver_async ...................................................................................................................................................... pass unit_tests.connection.APITest.test_accept_receiver_dynamic_sync ............................................................................................................................................... pass unit_tests.connection.APITest.test_accept_receiver_sync ....................................................................................................................................................... pass unit_tests.connection.APITest.test_accept_sender_async ........................................................................................................................................................ pass unit_tests.connection.APITest.test_accept_sender_dynamic_sync ................................................................................................................................................. pass unit_tests.connection.APITest.test_accept_sender_sync ......................................................................................................................................................... pass unit_tests.connection.APITest.test_active_callback ............................................................................................................................................................ pass unit_tests.connection.APITest.test_connection_properties ...................................................................................................................................................... pass unit_tests.connection.APITest.test_create_destroy ............................................................................................................................................................. pass unit_tests.connection.APITest.test_create_receiver ............................................................................................................................................................ pass unit_tests.connection.APITest.test_create_sender .............................................................................................................................................................. pass unit_tests.connection.APITest.test_destroy_then_process ....................................................................................................................................................... start 2024-03-27 06:37:54,758 ERROR Connection.process() called on destroyed connection! 2024-03-27 06:37:54,760 ERROR Connection failed: Condition('amqp:resource-limit-exceeded', 'local-idle-timeout expired') 2024-03-27 06:37:54,761 ERROR Connection.process() called on destroyed connection! unit_tests.connection.APITest.test_destroy_then_process ....................................................................................................................................................... pass unit_tests.connection.APITest.test_io_input_close ............................................................................................................................................................. start 2024-03-27 06:37:54,784 ERROR Connection failed: Condition('amqp:connection:framing-error', 'connection aborted') unit_tests.connection.APITest.test_io_input_close ............................................................................................................................................................. pass unit_tests.connection.APITest.test_io_output_close ............................................................................................................................................................ skip unit_tests.common.Skipped: Skipping test - error deprecated? unit_tests.connection.APITest.test_non_reentrant_callback ..................................................................................................................................................... pass unit_tests.connection.APITest.test_open_close_polled .......................................................................................................................................................... pass unit_tests.connection.APITest.test_pipeline ................................................................................................................................................................... pass unit_tests.connection.APITest.test_properties_hostname ........................................................................................................................................................ pass unit_tests.connection.APITest.test_properties_idle_timeout .................................................................................................................................................... pass unit_tests.connection.APITest.test_reject_receiver_async ...................................................................................................................................................... pass unit_tests.connection.APITest.test_reject_receiver_no_condition_sync .......................................................................................................................................... pass unit_tests.connection.APITest.test_reject_receiver_sync ....................................................................................................................................................... pass unit_tests.connection.APITest.test_reject_sender_async ........................................................................................................................................................ pass unit_tests.connection.APITest.test_reject_sender_no_condition_sync ............................................................................................................................................ pass unit_tests.connection.APITest.test_reject_sender_sync ......................................................................................................................................................... pass unit_tests.connection.APITest.test_sasl_callbacks_old ......................................................................................................................................................... skip unit_tests.common.Skipped: Test does not apply unit_tests.connection.APITest.test_ssl_bad_no_cert ............................................................................................................................................................ pass unit_tests.connection.APITest.test_ssl_bad_no_peer_name ....................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_bad_verify_mode ........................................................................................................................................................ pass unit_tests.connection.APITest.test_ssl_client_auth_ok ......................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_client_name_fail ....................................................................................................................................................... start 2024-03-27 06:37:55,676 ERROR Connection failed: Condition('amqp:connection:framing-error', 'SSL Failure: error:0A000086:SSL routines::certificate verify failed') 2024-03-27 06:37:55,679 ERROR Connection failed: Condition('amqp:connection:framing-error', 'SSL Failure: error:0A000410:SSL routines::ssl/tls alert handshake failure') unit_tests.connection.APITest.test_ssl_client_name_fail ....................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_client_pw_fail ......................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_minimal ................................................................................................................................................................ pass unit_tests.connection.APITest.test_ssl_name_fail .............................................................................................................................................................. start 2024-03-27 06:37:56,220 ERROR Connection failed: Condition('amqp:connection:framing-error', 'SSL Failure: error:0A000410:SSL routines::ssl/tls alert handshake failure') 2024-03-27 06:37:56,221 ERROR Connection failed: Condition('amqp:connection:framing-error', 'SSL Failure: error:0A000086:SSL routines::certificate verify failed') unit_tests.connection.APITest.test_ssl_name_fail .............................................................................................................................................................. pass unit_tests.connection.APITest.test_ssl_no_verify_peer ......................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_ok ..................................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_ok_using_system_ca ..................................................................................................................................................... pass unit_tests.connection.APITest.test_ssl_pw_fail ................................................................................................................................................................ pass unit_tests.connection.APITest.test_user_context ............................................................................................................................................................... pass unit_tests.connection.SASLTest.test_sasl_disabled ............................................................................................................................................................. pass unit_tests.connection.SASLTest.test_sasl_force ................................................................................................................................................................ pass unit_tests.connection.SASLTest.test_sasl_force_false .......................................................................................................................................................... pass unit_tests.container.APITest.test_cleanup ..................................................................................................................................................................... pass unit_tests.container.APITest.test_create_connection ........................................................................................................................................................... pass unit_tests.container.APITest.test_create_destroy .............................................................................................................................................................. pass unit_tests.container.APITest.test_need_processing ............................................................................................................................................................. pass unit_tests.link.APITest.test_create_destroy ................................................................................................................................................................... pass unit_tests.link.APITest.test_credit_sync ...................................................................................................................................................................... pass unit_tests.link.APITest.test_dynamic_receiver_props ........................................................................................................................................................... pass unit_tests.link.APITest.test_multi_frame_message .............................................................................................................................................................. pass unit_tests.link.APITest.test_non_reentrant_callback ........................................................................................................................................................... start 2024-03-27 06:37:56,961 ERROR Endpoint state error: endpoint=src1, error=invalid event=REMOTE_OPENED in state=STATE_ACTIVE 2024-03-27 06:37:56,967 ERROR Endpoint state error: endpoint=src2, error=invalid event=LOCAL_OPENED in state=STATE_ACTIVE unit_tests.link.APITest.test_non_reentrant_callback ........................................................................................................................................................... pass unit_tests.link.APITest.test_pipeline_close ................................................................................................................................................................... pass unit_tests.link.APITest.test_receiver_abort ................................................................................................................................................................... pass unit_tests.link.APITest.test_receiver_close_cond_sync ......................................................................................................................................................... pass unit_tests.link.APITest.test_receiver_setup_sync .............................................................................................................................................................. pass unit_tests.link.APITest.test_send_abort ....................................................................................................................................................................... pass unit_tests.link.APITest.test_send_accepted .................................................................................................................................................................... pass unit_tests.link.APITest.test_send_close_on_ack ................................................................................................................................................................ pass unit_tests.link.APITest.test_send_deadline_idle ............................................................................................................................................................... pass unit_tests.link.APITest.test_send_expired_late_reply .......................................................................................................................................................... pass unit_tests.link.APITest.test_send_expired_no_callback ......................................................................................................................................................... pass unit_tests.link.APITest.test_send_expired_no_credit ........................................................................................................................................................... pass unit_tests.link.APITest.test_send_expired_no_reply ............................................................................................................................................................ pass unit_tests.link.APITest.test_send_modified .................................................................................................................................................................... pass unit_tests.link.APITest.test_send_presettled .................................................................................................................................................................. pass unit_tests.link.APITest.test_send_rejected .................................................................................................................................................................... pass unit_tests.link.APITest.test_send_released .................................................................................................................................................................... pass unit_tests.link.APITest.test_sender_close_cond_sync ........................................................................................................................................................... pass unit_tests.link.APITest.test_sender_setup_sync ................................................................................................................................................................ pass unit_tests.link.APITest.test_settle_modes ..................................................................................................................................................................... pass unit_tests.link.APITest.test_use_after_free ................................................................................................................................................................... pass Totals: 74 tests, 70 passed, 2 skipped, 2 ignored, 0 failed ``` > c) Can you use the %pyproject_save_files and %{pyproject_files} macros: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_example_spec_file Thanks for the comment, I fixed the spec file to use the macros. > d) License is packaged twice at: > /usr/share/licenses/python3-pyngus/LICENSE > /usr/lib/python3.12/site-packages/pyngus-2.3.1.dist-info/LICENSE > though this is ok as metadata for the file in dist-info is missing: > $ rpm -qL python3-pyngus-2.3.1-2.fc41.noarch.rpm > /usr/share/licenses/python3-pyngus/LICENSE Thanks for the checking. I changed the spec file to use %pyproject_files macro to handle %license tag. Koji scratch build result(success) https://koji.fedoraproject.org/koji/taskinfo?taskID=115497574 Thanks in advance, Hirotaka
There seems to be some problem with the following file. SRPM URL: https://hiwkby.fedorapeople.org/python-pyngus-2.3.1-3.fc41.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Created attachment 2023789 [details] The .spec file difference from Copr build 7181296 to 7220793
Copr build: https://copr.fedorainfracloud.org/coprs/build/7220793 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270021-python-pyngus/fedora-rawhide-x86_64/07220793-python-pyngus/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-pyngus Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-pyngus See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "*No copyright* Apache License". 8 files have unknown license. Detailed output of licensecheck in /home/fedora/2270021-python- pyngus/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.12/site-packages, /usr/lib/python3.12 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [-]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4137 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pyngus-2.3.1-3.fc41.noarch.rpm python-pyngus-2.3.1-3.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9yx76umc')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pyngus/pyngus-2.3.1.tar.gz : CHECKSUM(SHA256) this package : d925868637fcaf2b6a2174137d39af909d1e95f5c8a27c816b55b5a204e9240d CHECKSUM(SHA256) upstream package : d925868637fcaf2b6a2174137d39af909d1e95f5c8a27c816b55b5a204e9240d Requires -------- python3-pyngus (rpmlib, GLIBC filtered): python(abi) python3.12dist(python-qpid-proton) Provides -------- python3-pyngus: python-pyngus python3-pyngus python3.12-pyngus python3.12dist(pyngus) python3dist(pyngus) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2270021 Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Generic, Shell-api Disabled plugins: Haskell, Java, PHP, fonts, Ocaml, SugarActivity, Perl, C/C++, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please change: Source0: %{pypi_source %{srcname} %{version}} BuildArch: noarch %global _description \ to Source0: %{pypi_source %{srcname} %{version}} BuildArch: noarch BuildRequires: python3-devel %global _description \ b) It is possible to package leading git commit directly, rather than the pypi source if you want to include the tests: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_revision https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots alternatively modify %pyproject_save_files -l %{srcname} %files -n python3-%{srcname} -f %{pyproject_files} %doc README.md to %pyproject_save_files -l %{srcname} %check %pyproject_check_import %files -n python3-%{srcname} -f %{pyproject_files} %doc README.md
Hi Benson, Thank you for explaining in detail! I fixed the issues as followings. Spec URL: https://hiwkby.fedorapeople.org/python-pyngus.spec SRPM URL: https://hiwkby.fedorapeople.org/python-pyngus-2.3.0%5e20200513git60b6f10-1.20200513git60b6f10.fc41.src.rpm (In reply to Benson Muite from comment #13) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > ...(snip)... > > Comments: > a) Please change: > > Source0: %{pypi_source %{srcname} %{version}} > > BuildArch: noarch > > %global _description \ > > to > > Source0: %{pypi_source %{srcname} %{version}} > > BuildArch: noarch > BuildRequires: python3-devel > > %global _description \ I added the "BuildRequires: python3-devel" line. I changed the "Source" URL to include the tests. > b) It is possible to package leading git commit directly, rather than the > pypi source > if you want to include the tests: > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_commit_revision > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_snapshots > > alternatively modify > > %pyproject_save_files -l %{srcname} > > %files -n python3-%{srcname} -f %{pyproject_files} > %doc README.md > > > to > > %pyproject_save_files -l %{srcname} > > %check > %pyproject_check_import > > %files -n python3-%{srcname} -f %{pyproject_files} > %doc README.md I updated the version tag to use the commit hash associated with the "2.3.1" version on pypi. I also added the "%pyproject_check_import" macro and the lines to run tests. Koji scratch build result(success) https://koji.fedoraproject.org/koji/taskinfo?taskID=115750893 Thanks in advance, Hirotaka
Hello, here is the diff with the previous spec file. ``` *** python-pyngus.spec.old Fri Apr 5 06:57:10 2024 --- python-pyngus.spec Mon Apr 1 21:42:50 2024 *************** *** 1,17 **** %global srcname pyngus Name: python-%{srcname} ! Version: 2.3.1 ! Release: 3%{?dist} Summary: Callback API implemented over Proton License: Apache-2.0 URL: https://github.com/kgiusti/%{srcname} ! # Upstream does not provides the latest version from git. # Please see: https://github.com/kgiusti/pyngus/issues/14 ! Source0: %{pypi_source %{srcname} %{version}} BuildArch: noarch %global _description \ A connection oriented messaging framework using QPID Proton.\ --- 1,23 ---- %global srcname pyngus + %global commit 60b6f102e4dc2d976292aa974866c4acce492e27 + %global shortcommit %(c=%{commit}; echo ${c:0:7}) + %global snapshotdate 20200513 Name: python-%{srcname} ! # Uses the snapshot because the upstream does not provides the latest version from git. ! # Please see: https://github.com/kgiusti/pyngus/issues/14 ! Version: 2.3.0^%{snapshotdate}git%{shortcommit} ! Release: 1.%{snapshotdate}git%{shortcommit}%{?dist} Summary: Callback API implemented over Proton License: Apache-2.0 URL: https://github.com/kgiusti/%{srcname} ! # Uses the commit because the upstream does not provides the latest version from git. # Please see: https://github.com/kgiusti/pyngus/issues/14 ! Source: https://github.com/OWNER/PROJECT/archive/%{commit}/%{srcname}-%{shortcommit}.tar.gz BuildArch: noarch + BuildRequires: python3-devel %global _description \ A connection oriented messaging framework using QPID Proton.\ *************** *** 27,33 **** Python 3 version. %prep ! %autosetup -n %{srcname}-%{version} %generate_buildrequires %pyproject_buildrequires --- 33,39 ---- Python 3 version. %prep ! %autosetup -n %{srcname}-%{commit} %generate_buildrequires %pyproject_buildrequires *************** *** 38,60 **** %install %py3_shebang_fix setup.py %pyproject_install %pyproject_save_files -l %{srcname} %files -n python3-%{srcname} -f %{pyproject_files} %doc README.md %changelog ! * Tue Mar 26 2024 Hirotaka Wakabayashi <hiwkby> - 2.3.1-3 ! - Introduces new macros pyproject_save_files and pyproject_files ! - Fixes duplicated LICENSE files ! ! * Tue Mar 19 2024 Hirotaka Wakabayashi <hiwkby> - 2.3.1-2 ! - Applies license-fedora2spdx ! ! * Fri Mar 15 2024 Hirotaka Wakabayashi <hiwkby> - 2.3.1-1 - Untretire python-pyngus ! - Updates python-pyngus-2.3.1 * Fri Jul 21 2023 Fedora Release Engineering <releng> - 2.3.0-16 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild --- 44,65 ---- %install %py3_shebang_fix setup.py %pyproject_install + %py3_shebang_fix tests/test-runner tests/perf-test.py setup.py examples/perf-tool.py examples/rpc-server.py examples/server.py examples/send.py examples/recv.py examples/rpc-client.py %pyproject_save_files -l %{srcname} + %check + %pyproject_check_import + %py3_test_envvars PYTHONPATH=%{buildroot}:%{buildroot}/tests + PYTHONPATH=.:tests tests/test-runner -i "unit_tests.connection.CyrusTest.test_cyrus_sasl_ok" -i "unit_tests.connection.CyrusTest.test_cyrus_sasl_fail" + %files -n python3-%{srcname} -f %{pyproject_files} %doc README.md %changelog ! * Sat Mar 30 2024 Hirotaka Wakabayashi <hiwkby> - 2.3.0-1.20200513git60b6f10 - Untretire python-pyngus ! - Updates python-pyngus * Fri Jul 21 2023 Fedora Release Engineering <releng> - 2.3.0-16 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild ```
Spec URL: https://hiwkby.fedorapeople.org/python-pyngus.spec SRPM URL: https://hiwkby.fedorapeople.org/python-pyngus-2.3.0^20200513git60b6f10-2.20200513git60b6f10.fc41.src.rpm I uploaded the new spec file that fixed the wrong source package location. Koji scratch build result(success) https://koji.fedoraproject.org/koji/taskinfo?taskID=116251750
Here is the diff with the previous spec file. ``` $ diff -c python-pyngus.spec.old2 python-pyngus.spec *** python-pyngus.spec.old2 Fri Apr 12 05:59:07 2024 --- python-pyngus.spec Fri Apr 12 05:07:11 2024 *************** *** 7,20 **** # Uses the snapshot because the upstream does not provides the latest version from git. # Please see: https://github.com/kgiusti/pyngus/issues/14 Version: 2.3.0^%{snapshotdate}git%{shortcommit} ! Release: 1.%{snapshotdate}git%{shortcommit}%{?dist} Summary: Callback API implemented over Proton License: Apache-2.0 URL: https://github.com/kgiusti/%{srcname} # Uses the commit because the upstream does not provides the latest version from git. # Please see: https://github.com/kgiusti/pyngus/issues/14 ! Source: https://github.com/OWNER/PROJECT/archive/%{commit}/%{srcname}-%{shortcommit}.tar.gz BuildArch: noarch BuildRequires: python3-devel --- 7,20 ---- # Uses the snapshot because the upstream does not provides the latest version from git. # Please see: https://github.com/kgiusti/pyngus/issues/14 Version: 2.3.0^%{snapshotdate}git%{shortcommit} ! Release: 2.%{snapshotdate}git%{shortcommit}%{?dist} Summary: Callback API implemented over Proton License: Apache-2.0 URL: https://github.com/kgiusti/%{srcname} # Uses the commit because the upstream does not provides the latest version from git. # Please see: https://github.com/kgiusti/pyngus/issues/14 ! Source: https://github.com/kgiusti/pyngus/archive/%{commit}/%{srcname}-%{shortcommit}.tar.gz BuildArch: noarch BuildRequires: python3-devel *************** *** 57,62 **** --- 57,65 ---- %doc README.md %changelog + * Fri Apr 12 2024 Hirotaka Wakabayashi <hiwkby> - 2.3.0-2.20200513git60b6f10 + - Fixes the Source URL + * Sat Mar 30 2024 Hirotaka Wakabayashi <hiwkby> - 2.3.0-1.20200513git60b6f10 - Untretire python-pyngus - Updates python-pyngus ```
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-pyngus See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0". 15 files have unknown license. Detailed output of licensecheck in /home/fedora/2270021-python-pyngus/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.12/site-packages, /usr/lib/python3.12 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4137 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pyngus-2.3.0^20200513git60b6f10-2.20200513git60b6f10.fc41.noarch.rpm python-pyngus-2.3.0^20200513git60b6f10-2.20200513git60b6f10.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6b4rqslf')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/kgiusti/pyngus/archive/60b6f102e4dc2d976292aa974866c4acce492e27/pyngus-60b6f10.tar.gz : CHECKSUM(SHA256) this package : 08cccdfb892dafe825e22c0d1740f7c0848910c3398b3a0f01f29a92ffe97998 CHECKSUM(SHA256) upstream package : 08cccdfb892dafe825e22c0d1740f7c0848910c3398b3a0f01f29a92ffe97998 Requires -------- python3-pyngus (rpmlib, GLIBC filtered): python(abi) python3.12dist(python-qpid-proton) Provides -------- python3-pyngus: python-pyngus python3-pyngus python3.12-pyngus python3.12dist(pyngus) python3dist(pyngus) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2270021 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Python, Shell-api Disabled plugins: SugarActivity, PHP, C/C++, R, Haskell, fonts, Ocaml, Perl, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Thanks for the changes. Approved.
Hello Benson, I really appreciate your review!
Package is now in repositories, closing review.