travier wants to partially revert bootupd support again, per https://pagure.io/workstation-ostree-config/pull-request/498 , due to a couple of issues - bootupctl does not install EFI boot manager entries (we have a workaround for this in F40 currently, but it's not perfect) and does not write /etc/default/grub . See also https://gitlab.com/fedora/ostree/sig/-/issues/1 . He asked what is necessary to do this for F40 Beta, and I said an FE bug at least is needed, so I'm filing one so we can discuss it in the current meeting.
I think https://pagure.io/workstation-ostree-config/pull-request/498 alone would substantially complete this. We *could* also revert the anaconda patch, but it's probably not *necessary* at least for Beta.
Discussed during the 2024-03-18 blocker review meeting: [1] The decision to classify this bug as a AcceptedFreezeException (Beta) was made: "We know the old way works, and the atomic desktop images are not blocking, so we're willing to defer to the maintainer's idea of what's best here since the change is limited to the atomic desktop definitions." [1] https://meetbot.fedoraproject.org/blocker-review_matrix_fedoraproject-org/2024-03-18/f40-blocker-review.2024-03-18-16.01.log.html
To summarize, we have multiple issues: - The bootupd installation path in Anaconda does not update EFI boot entries anymore, and the workaround from https://github.com/rhinstaller/anaconda/pull/5508 is incomplete. See: https://github.com/coreos/bootupd/issues/630 - Given the way the bootupd installation path has been implemented in Anaconda, enabling bootupd also enables using static GRUB configs, which currently does not support dual booting: https://github.com/fedora-silverblue/issue-tracker/issues/530 - With static GRUB configs, /etc/default/grub is now ignored but grub2-mkconfig is still included in the image and will thus do nothing if run. This is needed for compatibility with older systems which haven't updated their bootloader yet. See: https://github.com/ostreedev/ostree/pull/3150 As it is unlikely that we'll be able to fix those issues for F40, we will remove bootupd from the images, which will revert Anaconda to the old installation path, and then we will re-add bootupd to the images after the release so that users can get their bootloaders updated.
(In reply to Adam Williamson from comment #1) > I think https://pagure.io/workstation-ostree-config/pull-request/498 alone would substantially complete this. We *could* also revert the anaconda patch, but it's probably not *necessary* at least for Beta. Yes, this change should be enough for the beta. We can revert the Anaconda patch after the freeze.
I've merged https://pagure.io/workstation-ostree-config/pull-request/498. This should land in tomorrow's build.
"With static GRUB configs, /etc/default/grub is now ignored but grub2-mkconfig is still included in the image and will thus do nothing if run." I'm not sure this is accurate. I think grub2-mkconfig still Does Stuff with no /etc/default/grub , but what it does may differ.
Ah yes indeed. It does nothing for the ostree part but it still does the rest, so this is likely dangerous / confusing for users.
Apologies- I missed this FE request and discussion. We'll need to make the same change in IoT as well.
Sorry Paul. I posted it that I would likely do it on Matrix but forgot to ping you for this one. My bad.
I've installed a fresh Kinoite system using the 40.20240319.0 ISO with EFI boot and got a system with a "Fedora" boot entry (note the capital letter) and a `/etc/default/grub` config file so we should be good here.