Bug 2270197 - Kiwi-built Beta candidate images do not have "Beta" in the name
Summary: Kiwi-built Beta candidate images do not have "Beta" in the name
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: kiwi
Version: 41
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedFreezeException
Depends On:
Blocks: F41BetaFreezeException
TreeView+ depends on / blocked
 
Reported: 2024-03-18 22:26 UTC by Adam Williamson
Modified: 2024-09-04 18:30 UTC (History)
8 users (show)

Fixed In Version: kiwi-10.0.7-1.fc40 kiwi-10.1.3-1.fc41
Clone Of:
Environment:
Last Closed: 2024-09-04 18:30:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Fedora Pagure cloud-sig issue 424 0 None None None 2024-08-20 11:47:12 UTC
Fedora Pagure koji issue 4177 0 None None None 2024-08-20 11:46:29 UTC
Fedora Pagure koji issue 4183 0 None None None 2024-08-25 01:02:26 UTC
Github OSInside kiwi issues 2509 0 None closed Allow customization of attributes that determine image file names via `result bundle` 2024-09-02 13:53:05 UTC
Github OSInside kiwi issues 2628 0 None closed Wrong file extension is used for tarball image artifacts when using custom bundle format 2024-09-02 13:52:57 UTC

Description Adam Williamson 2024-03-18 22:26:42 UTC
Kiwi-built images in Fedora 40 Beta candidates - e.g. all the ones in https://kojipkgs.fedoraproject.org/compose/40/Fedora-40-20240317.1/compose/Cloud/x86_64/images/ - do not have "Beta" in their filenames, and generally look (from the filenames) a whole lot like final release images. This can be confusing.

We should try and get the names to include "Beta" - they should be something like e.g. "Fedora-Cloud-Base-Generic.x86_64-40_Beta-1.7.qcow2" instead of "Fedora-Cloud-Base-Generic.x86_64-40-1.7.qcow2" . But it likely requires change in kiwi itself. Filing this bug to be nominated as an FE on the offchance we might manage to line up the pieces to fix this before we do the final Beta candidate compose. The Kiwi feature request ticket is https://github.com/OSInside/kiwi/issues/2509 . If we could get that, we would then I think need to tweak the Pungi kiwi phase to pass its "version" value through to Koji, and tweak the Koji kiwi plugin to specify it (and then maybe remove it from fedora-kiwi-descriptions, for clarity).

Comment 1 Neal Gompa 2024-03-18 22:28:31 UTC
We cannot remove the value in fedora-kiwi-descriptions without it failing validation.

Comment 2 Adam Williamson 2024-03-18 22:34:49 UTC
well, I guess if Kiwi made it possible to specify it at runtime like this, it could be made no longer compulsory in the "description"? but if we decide to keep it mandatory in the config and just allow it to be overridden at runtime, I could live with that, we can just comment the "description" setting to make it clear that it's not normally used...

Comment 3 Neal Gompa 2024-03-18 23:18:25 UTC
I would still attempt to keep it a reasonable value for local builds, but sure.

Comment 4 Neal Gompa 2024-03-20 13:01:17 UTC
Upstream code to fix this has been written: https://github.com/OSInside/kiwi/pull/2510

This will need changes to the koji kiwi plugin and pungi to use it.

Comment 5 Lubomír Sedlář 2024-03-20 13:39:31 UTC
If koji exposes the functionality by simply adding version option to kiwiBuild API call, then https://pagure.io/pungi/pull-request/1754 should handled it on Pungi side.

Comment 6 Adam Williamson 2024-03-20 14:52:22 UTC
That is not what it did, it did something actually better for us, but which will require a bit more change. See pull request comment for details.

Comment 7 Fedora Update System 2024-03-20 16:20:28 UTC
FEDORA-2024-fa154b7d3a (kiwi-10.0.7-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-fa154b7d3a

Comment 8 Fedora Update System 2024-03-21 01:35:23 UTC
FEDORA-2024-fa154b7d3a has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-fa154b7d3a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fa154b7d3a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Adam Williamson 2024-03-21 23:15:27 UTC
We signed off Beta today, so there's no point in Beta FE status any more. Clearing that nomination.

Comment 10 Fedora Update System 2024-03-23 00:41:29 UTC
FEDORA-2024-fa154b7d3a (kiwi-10.0.7-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Adam Williamson 2024-03-23 03:59:51 UTC
The Kiwi update alone does not fix this.

Comment 12 Neal Gompa 2024-08-20 11:46:30 UTC
The following PRs are needed to get this squared away:

* Koji: https://pagure.io/koji/pull-request/4157
* Pungi: https://pagure.io/pungi/pull-request/1754

Once these are merged, this bug should be resolved.

Comment 13 Adam Williamson 2024-08-22 16:36:46 UTC
I'm doing a build of Koji for F41 and Rawhide with the patches backported ATM. stg and prod koji use builds from the infra tag; I've asked Kevin if he can do an F40 infra tag build with the change.

Comment 14 Adam Williamson 2024-08-22 16:40:59 UTC
Neal: is this truly resolved just with those two patches, btw? Don't we then *also* need a pungi-fedora change to actually use the options pungi now provides and passes through to koji to kiwi? :D

Comment 15 Adam Williamson 2024-08-22 18:56:16 UTC
Update: pungi change is in 4.7.0 which is stable for f41 and rawhide, koji change has just been deployed by Kevin. So we should be ready to try this out.

Comment 16 Neal Gompa 2024-08-22 20:05:24 UTC
Pull request to set the format submitted: https://pagure.io/pungi-fedora/pull-request/1327

Comment 17 Neal Gompa 2024-08-25 01:00:20 UTC
One more round of fixes... https://pagure.io/koji/pull-request/4184

Comment 18 Neal Gompa 2024-08-25 01:01:12 UTC
This will also need pungi plumbing too...

Comment 19 Neal Gompa 2024-08-27 16:23:21 UTC
The pungi change has been prepared: https://pagure.io/pungi/pull-request/1780

Comment 20 packager-dashboard-bot 2024-09-02 13:26:58 UTC
Proposed as a Freeze Exception for 41-beta by Fedora user ngompa using the blocker tracking app because:

 This gets us the release with all the fixes in place for F41 composes.

Comment 21 Fedora Update System 2024-09-02 13:45:35 UTC
FEDORA-2024-8003545aeb (kiwi-10.1.3-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-8003545aeb

Comment 22 Fedora Update System 2024-09-03 03:49:24 UTC
FEDORA-2024-8003545aeb has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8003545aeb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8003545aeb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 23 Adam Williamson 2024-09-03 05:45:01 UTC
+3 in https://pagure.io/fedora-qa/blocker-review/issue/1634 , marking accepted.

Comment 24 Fedora Update System 2024-09-04 18:30:57 UTC
FEDORA-2024-8003545aeb (kiwi-10.1.3-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.