Spec URL: https://rathann.fedorapeople.org/review/gpac/gpac.spec SRPM URL: https://rathann.fedorapeople.org/review/gpac/gpac-2.2.1-7.fc41.src.rpm Description: GPAC is a multimedia framework based on the MPEG-4 Systems standard developed from scratch in ANSI C. The original development goal is to provide a clean, small and flexible alternative to the MPEG-4 Systems reference software. GPAC features the integration of recent multimedia standards (SVG/SMIL, VRML, X3D, SWF, 3GPP(2) tools and more) into a single framework. GPAC also features MPEG-4 Systems encoders/multiplexers, publishing tools for content distribution for MP4 and 3GPP(2) files and many tools for scene descriptions (MPEG4 <-> VRML <-> X3D converters, SWF -> MPEG-4, etc). Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/7179811 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270199-gpac/fedora-rawhide-x86_64/07179811-gpac/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://rathann.fedorapeople.org/review/gpac/gpac.spec SRPM URL: https://rathann.fedorapeople.org/review/gpac/gpac-2.4.0-2.fc41.src.rpm * Fri Jun 14 2024 Dominik Mierzejewski <dominik> - 2.4.0-2 - fix LTO type mismatch warning - backport upstream fix for xvidcore and freenect detection * Sun Apr 28 2024 Leigh Scott <leigh123linux> - 2.4.0-1 - Update to 2.4.0
Created attachment 2037374 [details] The .spec file difference from Copr build 7179811 to 7615902
Copr build: https://copr.fedorainfracloud.org/coprs/build/7615902 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270199-gpac/fedora-rawhide-x86_64/07615902-gpac/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me, package approved. Just a couple of questions: - Shall we add libfreenect to Fedora and then remove the %with_freenect conditional? - Do we need the static archive subpackage? - Regarding the bug mentioned: #config.h like but not only #Usual multilib bug https://bugzilla.rpmfusion.org/show_bug.cgi?id=270 sed -i -e '/GPAC_CONFIGURATION/d' %{buildroot}%{_includedir}/gpac/configuration.h I haven't checked in detail as the bug thread is very long and old (livna times), are you sure it still applies? Thanks!
(In reply to Simone Caronni from comment #5) > Looks good to me, package approved. Thanks! > Just a couple of questions: > > - Shall we add libfreenect to Fedora and then remove the %with_freenect > conditional? It's in Fedora already. I'll verify the support status in gpac. > - Do we need the static archive subpackage? Yes, it's useful not to link the whole gpac-libs (and bring its dependencies) to x264. Also, it helps break a dependency loop. > - Regarding the bug mentioned: > > #config.h like but not only > #Usual multilib bug https://bugzilla.rpmfusion.org/show_bug.cgi?id=270 > sed -i -e '/GPAC_CONFIGURATION/d' > %{buildroot}%{_includedir}/gpac/configuration.h > > I haven't checked in detail as the bug thread is very long and old (livna > times), are you sure it still applies? I think I checked it when I was preparing the Fedora package, but I'll re-check.
The Pagure repository was created at https://src.fedoraproject.org/rpms/gpac
FEDORA-2024-c6e66f2848 (gpac-2.4.0-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c6e66f2848
FEDORA-2024-c6e66f2848 (gpac-2.4.0-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.