Bug 2270307 - Review Request: rust-sequoia-gpg-agent - Library for interacting with GnuPG's gpg-agent
Summary: Review Request: rust-sequoia-gpg-agent - Library for interacting with GnuPG's...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/sequoia-gpg-...
Whiteboard:
Depends On: 2265676
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-03-19 14:56 UTC by Fabio Valentini
Modified: 2024-03-25 14:48 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-03-25 14:48:36 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-03-19 14:56:09 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-sequoia-gpg-agent.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-sequoia-gpg-agent-0.1.0-1.fc39.src.rpm

Description:
A library for interacting with GnuPG's gpg-agent.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2024-03-19 15:21:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7183087
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270307-rust-sequoia-gpg-agent/fedora-rawhide-x86_64/07183087-rust-sequoia-gpg-agent/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-03-19 15:49:06 UTC
PS: I need version 0.1 of this crate for sequoia-chameleon-gnupg.

Comment 3 Fabio Valentini 2024-03-19 17:59:50 UTC
PPS: This package currently fails to build in rawhide, because it depends on sequoia-cert-store v0.5.0. But I cannot update rust-sequoia-cert-store to version 0.5.0 because that update needs to be coordinated with other packages.

If necessary for the review, I can build the necessary packages in a koji side tag or in COPR.

Comment 4 Fabio Valentini 2024-03-19 23:18:52 UTC
Builds of dependencies and this package are now available in COPR:
https://copr.fedorainfracloud.org/coprs/decathorpe/sequoia-updates/monitor/

Comment 5 Michel Lind 2024-03-24 22:10:24 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (LGPL-2.0-or-later) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Fedora Admin user for bugzilla script actions 2024-03-25 11:43:26 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sequoia-gpg-agent

Comment 7 Fabio Valentini 2024-03-25 14:48:36 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-04871a4a74


Note You need to log in before you can comment on or make changes to this bug.