Spec URL: http://people.redhat.com/rafaels/specs/jrexx-1.1.1-3jpp.spec SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/jrexx-1.1.1-3jpp.src.rpm Description: jrexx is a powerful easy-to-use regular expression API for textual pattern matching. Technically jrexx uses a minimized deterministic FSA (finite state automaton) and compiles the textual representation of the regular expression into such an automaton. Besides the usual pattern matching functionality, jrexx provides an introspection API for exploration of the automaton's structure by 'states' and 'transitions'. Since the automaton is deterministic and minimized the pattern matching alogorithm is extremly fast (compared to the java regular expression API in JDK1.4) and works with huge patterns and input texts. Since FSA can be handled as sets, jrexx also offers all basic set operations for complement, union, intersection and difference, which is not provided by other regex implementations (as far as we know). Javadoc for jrexx.
Review comments: * incorrect buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * license text not included in package and marked with %doc * rpmlint on <this package>.srpm gives some output W: jrexx non-standard-group Development/Libraries/Java E: jrexx unknown-key GPG#c431416d W: jrexx setup-not-quiet * changelog should be in one of these formats: * Fri Jun 23 2006 Jesse Keating <jkeating> - 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating> 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating> - 0.6-4 - And fix the link syntax. * Vendor tag should not be used * some lines are > 80 characters * does not use macros appropriately and consistently - ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
Comments handled. No license txt but license is specified on web-site. There was no issue with changelog nor the macros. http://www.vermillionskye.com/downloads/jrexx-1.1.1-3jpp.1.src.rpm http://www.vermillionskye.com/downloads/jrexx.spec
Created attachment 147995 [details] patch to fix remaining issues Remove section free Remove Distribution
Patch applied. Also modified command line that was > 80 chars and modified changelog entries to use @ symbol. http://www.vermillionskye.com/downloads/jrexx-1.1.1-3jpp.1.src.rpm http://www.vermillionskye.com/downloads/jrexx.spec
(In reply to comment #4) > Patch applied. Also modified command line that was > 80 chars and modified > changelog entries to use @ symbol. > > http://www.vermillionskye.com/downloads/jrexx-1.1.1-3jpp.1.src.rpm > http://www.vermillionskye.com/downloads/jrexx.spec If you change the email addresses back, I think I'll approve it :)
Done. http://www.vermillionskye.com/downloads/jrexx-1.1.1-3jpp.1.src.rpm http://www.vermillionskye.com/downloads/jrexx.spec
APPROVED Thanks, Jeff! Matt, I believe you're going to be the owner, right? When you've built it, I'll close this rawhide.
Was someone going to make a CVS request and get this checked in?
Matt?
This was one of the packages that we thought was needed for maven2, but we later determined it wasn't required at this time. This package is no longer needed for maven at this time, since it has been reviewed and passed, I am setting the cvs request
New Package CVS Request ======================= Package Name: jrexx Short Description: Automaton based regluar expression API for Java Owners: mwringe Branches: devel
cvs done.
Build into devel. Closing as NEXTRELEASE