Bug 227077 - Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and scalability testing
Review Request: junitperf-1.9.1-2jpp - JUnit extension for performance and sc...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matt Wringe
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-02-02 12:43 EST by Rafael H. Schloming
Modified: 2014-12-01 18:13 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-03-07 15:40:41 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
overholt: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Rafael H. Schloming 2007-02-02 12:43:14 EST
Spec URL: http://people.redhat.com/rafaels/specs/junitperf-1.9.1-2jpp.spec
SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/junitperf-1.9.1-2jpp.src.rpm
Description: JUnitPerf is a collection of JUnit test decorators used to measure the
performance and scalability of functionality contained within existing
JUnit tests.

Javadoc for junitperf.

Demonstrations and samples for junitperf.
Comment 1 Thomas Fitzsimmons 2007-02-12 19:33:30 EST
- incorrect build root
- %{?dist} should be used
- remove javadoc %post and %postun sections

$ rpmlint /home/fitzsim/rpmbuild/SRPMS/junitperf-1.9.1-2jpp.src.rpm
W: junitperf non-standard-group Development/Testing
E: junitperf tag-not-utf8 %changelog
E: junitperf non-utf8-spec-file junitperf.spec
W: junitperf mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 89)

$ rpmlint /home/fitzsim/rpmbuild/RPMS/noarch/junitperf-1.9.1-2jpp.noarch.rpm
W: junitperf non-standard-group Development/Testing
E: junitperf tag-not-utf8 %changelog

$ rpmlint /home/fitzsim/rpmbuild/RPMS/noarch/junitperf-javadoc-1.9.1-2jpp.noarch.rpm
W: junitperf-javadoc non-standard-group Development/Documentation
E: junitperf-javadoc tag-not-utf8 %changelog
W: junitperf-javadoc dangerous-command-in-%post rm
W: junitperf-javadoc dangerous-command-in-%postun rm

$ rpmlint /home/fitzsim/rpmbuild/RPMS/noarch/junitperf-demo-1.9.1-2jpp.noarch.rpm
W: junitperf-demo non-standard-group Development/Testing
E: junitperf-demo tag-not-utf8 %changelog
W: junitperf-demo no-documentation

- remove Vendor tag
- 80 characters per line
Comment 2 Deepak Bhole 2007-02-15 17:18:58 EST
Fixed spec and srpm:

Comment 3 Andrew Overholt 2007-02-16 16:31:49 EST
* package is named appropriately
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* verify source and patches
* skim the summary and description for typos, etc.
* correct buildroot
* %{?dist} is used properly
* license text included in package and marked with %doc
* packages meet FHS
* rpmlint on <this package>.srpm gives no output
$ rpmlint junitperf-1.9.1-2jpp.1.src.rpm
W: junitperf non-standard-group Development/Testing

This is fine.

* changelog fine
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* use License and not Copyright 
* Summary tag does not end in a period
* no PreReq
* specfile is legible
* package successfully compiles and builds on at least x86
* BuildRequires are proper
* summary should be a short and concise description of the package
* description expands upon summary
* make sure lines are <= 80 characters
  . the lines that aren't, I'm okay with
* specfile written in American English
* no -doc sub-package necessary
* no libraries
* no rpath
* no config files
* not a GUI app
* no -devel sub-package
* macros used appropriately and consistently
* no locale data
* consider using cp -p to preserve timestamps
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* file permissions okay; %defattrs should be present
* %clean present
* %doc files do not affect runtime
* not a web apps
* verify the final provides and requires of the binary RPMs
* run rpmlint on the binary RPMs
$ rpmlint junitperf-*.noarch.rpm
W: junitperf non-standard-group Development/Testing
W: junitperf-demo non-standard-group Development/Testing
W: junitperf-demo no-documentation

These are all fine

* package should include license text in the package and mark it with %doc
* package should build on i386
* package should build in mock

Comment 4 Matt Wringe 2007-03-06 10:48:00 EST
New Package CVS Request
Package Name: junitpref
Short Description: JUnit extension for performance and scalability testing
Owners: mwringe@redhat.com
Branches: devel
Comment 5 Matt Wringe 2007-03-06 17:03:55 EST
I seem to have made a typo in the above comment, it should have been "junitperf"
instead of "junitpref". Can I please get this renamed properly in cvs.


Matt Wringe
Comment 6 Dennis Gilmore 2007-03-07 14:21:38 EST
Comment 7 Matt Wringe 2007-03-07 15:40:41 EST
Build into plague. Marking as NEXTRELEASE
Comment 8 Mat Booth 2011-07-31 13:41:39 EDT
Package Change Request
Package Name: junitperf
New Branches: el6
Owners: mbooth
Comment 9 Jon Ciesla 2011-07-31 15:37:35 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.