Red Hat Bugzilla – Bug 227090
Review Request: nekohtml-0.9.5-4jpp - HTML scanner and tag balancer
Last modified: 2014-12-01 18:14:00 EST
Spec URL: http://people.redhat.com/rafaels/specs/nekohtml-0.9.5-4jpp.spec SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/nekohtml-0.9.5-4jpp.src.rpm Description: NekoHTML is a simple HTML scanner and tag balancer that enables application programmers to parse HTML documents and access the information using standard XML interfaces. The parser can scan HTML files and "fix up" many common mistakes that human (and computer) authors make in writing HTML documents. NekoHTML adds missing parent elements; automatically closes elements with optional end tags; and can handle mismatched inline element tags. NekoHTML is written using the Xerces Native Interface (XNI) that is the foundation of the Xerces2 implementation. This enables you to use the NekoHTML parser with existing XNI tools without modification or rewriting code. Javadoc for nekohtml. Demonstrations and samples for nekohtml.
Review comments: * Apache-like license is not proper license name. * license is not open source-compatible. - use acronyms for licences where common * correct buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * rpmlint on <this package>.srpm gives some output W: nekohtml non-standard-group Text Processing/Markup/HTML W: nekohtml invalid-license Apache-like E: nekohtml unknown-key GPG#c431416d * changelog should be in one of these formats: * Fri Jun 23 2006 Jesse Keating <jkeating@redhat.com> - 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating@redhat.com> 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating@redhat.com> - 0.6-4 - And fix the link syntax. * Vendor tag should not be used * use macros appropriately and consistently - ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS * split Requires(pre,post) into two separate lines
Comments addressed. http://www.vermillionskye.com/downloads/nekohtml-0.9.5-4jpp.1.src.rpm http://www.vermillionskye.com/donwloads/nekohtml.spec
Created attachment 148012 [details] Small patch to spec file Looks good overall, minor fixes to the spec file are attached in the patch. The unversioned javadoc link is not necessary and it probably best to add a requires/requires(postun) on jpackage-utils for %{_javadir}/%{_javadoc} ownership
New patch applied. Removed requires postun as this was deemed unnecessary by Andrew. I also put back the changelog entries I had changed as the old format for e-mail address is ok. The %doc statement was changed to the new agreed format of %{_javadocdir}/* http://www.vermillionskye.com/downloads/nekohtml-0.9.5-4jpp.1.src.rpm http://www.vermillionskye.com/downloads/nekohtml.spec
Looks good to me. Built fine in mock. I am going to approve this. Please build it into rawhide and once I can confirm it has made it through I will close it.
New Package CVS Request ======================= Package Name: nekohtml Short Description: HTML scanner and tag balancer Owners: mwringe@redhat.com Branches: devel InitialCC:
cvs module added