Spec URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SPECS/holidays.spec SRPM URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SRPMS/python-holidays-0.41-1.fc39.src.rpm Description: python-holidays A fast, efficient Python library for generating country- and subdivision- (e.g. state or province) specific sets of government-designated holidays on the fly. It aims to make determining whether a specific date is a holiday as fast and flexible as possible.:PyPI: :alt: PyPI version Fedora Account System Username: timarthurlee This is my first package and I will need a sponsor. I am submitting this as a part of the 2023 Friendly Fedora capstone project team at UMass Lowell
Copr build: https://copr.fedorainfracloud.org/coprs/build/7216870 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271625-python-holidays/fedora-rawhide-x86_64/07216870-python-holidays/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I have resolved the issues and tested with Koji build locally. Below are the links to the new files. Spec URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SPECS/holidays.spec SRPM URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SRPMS/python-holidays-0.41-1.fc39.src.rpm
Spec URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SPECS/python-holidays.spec SRPM URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SRPMS/python-holidays-0.41-1.fc39.src.rpm I have updated the filename of the spec file to match the srpm file.
Hi Tim, thank you for submitting the package and thus bringing it to my attention. I suspect I'll use that in the future (in work unrelated to Fedora). If you are still interested in maintaining this in Fedora, I can review your package. I notice that you are using the old "201x-era" macros and not the %pyproject-based ones. If possible I would prefer the new macros for new spec files in Fedora as shown in https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file. Is there a particular reason why you used the old macros? Also let me know if you need help, I can lend you a hand while you start contributing (though my free time is a bit limited as usual).
Tim, are you still interested in submitting this package?
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.