Spec URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SPECS/numba.spec SRPM URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SRPMS/python-numba-0.59.0-1.fc39.src.rpm Description: A Just-In-Time Compiler for Numerical Functions in Python Fedora Account System Username: timarthurlee This is one of my first packages and I will need a sponsor. I am submitting this as a part of the 2023 Friendly Fedora capstone project team at UMass Lowell.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7216918 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271634-python-numba/fedora-rawhide-x86_64/07216918-python-numba/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Welcome to Fedora. Will review, but you will need to find someone else to sponsor. To get sponsored, it can help to do a few mock reviews. See: https://docs.fedoraproject.org/en-US/package-maintainers/How_to_Get_Sponsored_into_the_Packager_Group/ https://docs.pagure.org/fedora-sponsors/interests#Python The package seems like it BuildRequires GCC.
Spec URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SPECS/python-numba.spec SRPM URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SRPMS/python-numba-0.59.0-1.fc39.src.rpm I have updated the filename of the spec file to match the srpm file.
*** Bug 2273016 has been marked as a duplicate of this bug. ***
Spec URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SPECS/python-numba.spec SRPM URL: https://github.com/timarthurlee/uml-redhat-capstone-2023/raw/main/rpmbuild/SRPMS/python-numba-0.59.0-1.fc39.src.rpm I have updated the spec file and it now successfully builds in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=115841194
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python3-numba : /usr/lib64/python3.12/site- packages/numba/_arraystruct.h python3-numba : /usr/lib64/python3.12/site- packages/numba/_devicearray.h python3-numba : /usr/lib64/python3.12/site- packages/numba/_hashtable.h python3-numba : /usr/lib64/python3.12/site- packages/numba/_numba_common.h python3-numba : /usr/lib64/python3.12/site-packages/numba/_pymodule.h python3-numba : /usr/lib64/python3.12/site-packages/numba/_typeof.h python3-numba : /usr/lib64/python3.12/site-packages/numba/_unicodetype_db.h python3-numba : /usr/lib64/python3.12/site-packages/numba/capsulethunk.h python3-numba : /usr/lib64/python3.12/site-packages/numba/cext/cext.h python3-numba : /usr/lib64/python3.12/site-packages/numba/cext/dictobject.h python3-numba : /usr/lib64/python3.12/site-packages/numba/cext/listobject.h python3-numba : /usr/lib64/python3.12/site- packages/numba/core/runtime/nrt.h python3-numba : /usr/lib64/python3.12/site-packages/numba/core/runtime/nrt_external.h python3-numba : /usr/lib64/python3.12/site- packages/numba/cuda/cuda_fp16.h python3-numba : /usr/lib64/python3.12/site-packages/numba/mathnames.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/python3-numba/README.rst See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'BSD'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License", "MIT License", "*No copyright* Public domain", "BSD 3-Clause License". 910 files have unknown license. Detailed output of licensecheck in /home/fedora/2271634-python-numba/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/python3.12, /usr/lib64/python3.12/site-packages [ ]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2270 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-numba [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-numba-0.59.0-1.fc41.aarch64.rpm python-numba-debugsource-0.59.0-1.fc41.aarch64.rpm python-numba-0.59.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpx0k0del2')] checks: 32, packages: 3 python-numba.src: W: summary-not-capitalized compiling Python code using LLVM python3-numba.aarch64: W: summary-not-capitalized compiling Python code using LLVM python3-numba.aarch64: E: non-executable-script /usr/lib64/python3.12/site-packages/numba/misc/appdirs.py 644 /usr/bin/env python python3-numba.aarch64: W: no-manual-page-for-binary numba python3-numba.aarch64: W: files-duplicate /usr/lib64/python3.12/site-packages/numba/cuda/tests/nocuda/__init__.py /usr/lib64/python3.12/site-packages/numba/cuda/tests/cudadrv/__init__.py:/usr/lib64/python3.12/site-packages/numba/cuda/tests/cudapy/__init__.py python3-numba.aarch64: W: files-duplicate /usr/lib64/python3.12/site-packages/numba/cuda/tests/doc_examples/__init__.py /usr/lib64/python3.12/site-packages/numba/cuda/tests/cudasim/__init__.py python3-numba.aarch64: W: files-duplicate /usr/lib64/python3.12/site-packages/numba/tests/npyufunc/__init__.py /usr/lib64/python3.12/site-packages/numba/tests/doc_examples/__init__.py:/usr/lib64/python3.12/site-packages/numba/tests/gdb/__init__.py python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_arraystruct.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_devicearray.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_dynfunc.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_dynfuncmod.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_hashtable.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_helperlib.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_helpermod.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_lapack.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_numba_common.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_pymodule.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_random.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_typeof.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_unicodetype_db.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/capsulethunk.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/cext.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/dictobject.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/dictobject.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/listobject.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/listobject.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/utils.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/_nrt_python.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/_nrt_pythonmod.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/nrt.cpp python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/nrt.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/nrt_external.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cuda/cuda_fp16.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cuda/cuda_fp16.hpp python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/mathnames.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/mviewbuf.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/pycc/modulemixin.c 3 packages and 0 specfiles checked; 1 errors, 36 warnings, 13 filtered, 1 badness; has taken 3.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-numba.aarch64: W: summary-not-capitalized compiling Python code using LLVM python3-numba.aarch64: E: non-executable-script /usr/lib64/python3.12/site-packages/numba/misc/appdirs.py 644 /usr/bin/env python python3-numba.aarch64: W: no-manual-page-for-binary numba python3-numba.aarch64: W: files-duplicate /usr/lib64/python3.12/site-packages/numba/cuda/tests/nocuda/__init__.py /usr/lib64/python3.12/site-packages/numba/cuda/tests/cudadrv/__init__.py:/usr/lib64/python3.12/site-packages/numba/cuda/tests/cudapy/__init__.py python3-numba.aarch64: W: files-duplicate /usr/lib64/python3.12/site-packages/numba/cuda/tests/doc_examples/__init__.py /usr/lib64/python3.12/site-packages/numba/cuda/tests/cudasim/__init__.py python3-numba.aarch64: W: files-duplicate /usr/lib64/python3.12/site-packages/numba/tests/npyufunc/__init__.py /usr/lib64/python3.12/site-packages/numba/tests/doc_examples/__init__.py:/usr/lib64/python3.12/site-packages/numba/tests/gdb/__init__.py python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_arraystruct.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_devicearray.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_dynfunc.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_dynfuncmod.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_hashtable.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_helperlib.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_helpermod.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_lapack.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_numba_common.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_pymodule.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_random.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_typeof.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/_unicodetype_db.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/capsulethunk.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/cext.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/dictobject.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/dictobject.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/listobject.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/listobject.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cext/utils.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/_nrt_python.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/_nrt_pythonmod.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/nrt.cpp python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/nrt.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/core/runtime/nrt_external.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cuda/cuda_fp16.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/cuda/cuda_fp16.hpp python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/mathnames.h python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/mviewbuf.c python3-numba.aarch64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/numba/pycc/modulemixin.c 2 packages and 0 specfiles checked; 1 errors, 35 warnings, 9 filtered, 1 badness; has taken 3.1 s Unversioned so-files -------------------- python3-numba: /usr/lib64/python3.12/site-packages/numba/_devicearray.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/_dispatcher.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/_dynfunc.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/_helperlib.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/core/runtime/_nrt_python.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/core/typeconv/_typeconv.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/cuda/cudadrv/_extras.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/experimental/jitclass/_box.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/mviewbuf.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/np/ufunc/_internal.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/np/ufunc/_num_threads.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/np/ufunc/omppool.cpython-312-aarch64-linux-gnu.so python3-numba: /usr/lib64/python3.12/site-packages/numba/np/ufunc/workqueue.cpython-312-aarch64-linux-gnu.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/n/numba/numba-0.59.0.tar.gz : CHECKSUM(SHA256) this package : 12b9b064a3e4ad00e2371fc5212ef0396c80f41caec9b5ec391c8b04b6eaf2a8 CHECKSUM(SHA256) upstream package : 12b9b064a3e4ad00e2371fc5212ef0396c80f41caec9b5ec391c8b04b6eaf2a8 Requires -------- python3-numba (rpmlib, GLIBC filtered): (python3.12dist(llvmlite) < 0.43~~ with python3.12dist(llvmlite) >= 0.42~~dev0) (python3.12dist(numpy) < 1.27~~ with python3.12dist(numpy) >= 1.22) (python3dist(llvmlite) >= 0.42~~dev0 with python3dist(llvmlite) < 0.43~~) (python3dist(numpy) >= 1.22 with python3dist(numpy) < 1.27~~) /usr/bin/python3 ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) rtld(GNU_HASH) python-numba-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-numba: python-numba python3-numba python3-numba(aarch-64) python3.12-numba python3.12dist(numba) python3dist(numba) python-numba-debugsource: python-numba-debugsource python-numba-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2271634 Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Shell-api, Generic, C/C++ Disabled plugins: Java, PHP, SugarActivity, R, Ocaml, Haskell, Perl, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) License seems like it should be BSD-2-Clause AND BSD-3-Clause AND MIT, see: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names it is also helpful to add a short summary of which sets of files have which licenses in the spec file. b) Is it possible to use the newer python macros: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ c) Is it possble to run any tests? d) RPM build warnings: File listed twice: /usr/share/doc/python3-numba/README.rst File listed twice: /usr/share/licenses/python3-numba/LICENSE File listed twice: /usr/share/licenses/python3-numba/LICENSES.third-party
I will look into the other items but regarding the tests, there appears to be a bug in the source code test files. It generates an error during build. I was only able to build it without the tests.
Just a word of caution about Numba – a new Python minor version is released about the same time as the first Fedora release containing it (e.g. Python 3.13 in Fedora 41). I’ve lost the link, but upstream indicates that three to six months is normally needed after the final release of a new Python minor version for Numba to support it – and since Numba is so tightly coupled to Python internals, this isn’t something we can reasonably help with or patch downstream as we do for many packages. So if we do package Numba, we can expect to have roughly an entire Fedora release cycle where Numba doesn’t support the system Python, each time Python releases a new minor version. Basically, we would have a working Numba package in every other Fedora release, which would wreak havoc on dependent packages.
Do you still expect to package this?
If not I can take it over.
(In reply to Gwyn Ciesla from comment #10) > If not I can take it over. If you do, heed the warning in https://bugzilla.redhat.com/show_bug.cgi?id=2271634#c8. Upstream did catch up with Python 3.13 a lot faster than they caught up with previous Python releases. In this case, according to https://github.com/numba/numba/issues/9413 and https://github.com/numba/numba/pull/9682, we could have probably built a patched pre-release snapshot in time for F41 final. Still not ideal, but better than waiting 6-12 months after the CPython final release to have any kind of support. Also note that numba pins numpy to a particular minor version and is apparently usually incompatible with new minor releases (!) of numpy according to https://github.com/numba/numba/issues/9708#issuecomment-2296088965. All in all, this package would be wonderful to have, but also a guaranteed headache.
Duly noted. I work with upstreams who consider 3.9 bleeding edge, so this is a dance with which I am well familiar.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
Should I reopen this review or move it to mine and reopen that?
Either is fine. Let me know once ready for review.
Ok, I'll do mine.