Bug 2271976 - Review Request: cosmic-comp - Compositor for the COSMIC desktop environment
Summary: Review Request: cosmic-comp - Compositor for the COSMIC desktop environment
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/pop-os/cosmic-comp
Whiteboard:
Depends On:
Blocks: COSMICDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2024-03-28 00:33 UTC by Ryan Brue
Modified: 2024-05-14 19:50 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-05-14 19:50:18 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7223504 to 7225498 (678 bytes, patch)
2024-03-28 04:42 UTC, Fedora Review Service
no flags Details | Diff

Description Ryan Brue 2024-03-28 00:33:52 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07223383-cosmic-comp/cosmic-comp.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07223383-cosmic-comp/cosmic-comp-0.1.0~20240327.23-1.fc41.src.rpm
Description: cosmic-comp is a rust wayland compositor based on smithay. It is also the compositor used in the upcoming COSMIC desktop environment.
Fedora Account System Username: ryanabx

This is the first COSMIC package of many that I'd like to bring into Fedora Rawhide ahead of eventually requesting a COSMIC spin of Fedora.

Comment 1 Fedora Review Service 2024-03-28 00:34:17 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ryan Brue 2024-03-28 00:42:15 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07223383-cosmic-comp/cosmic-comp.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07223383-cosmic-comp/cosmic-comp-0.1.0~20240327.23-1.fc41.src.rpm
Description: cosmic-comp is a rust wayland compositor based on smithay. It is also the compositor used in the upcoming COSMIC desktop environment.
Fedora Account System Username: ryanabx

This is the first COSMIC package of many that I'd like to bring into Fedora Rawhide ahead of eventually requesting a COSMIC spin of Fedora.

Comment 3 Neal Gompa 2024-03-28 01:06:24 UTC
Taking this review.

Comment 4 Fedora Review Service 2024-03-28 01:46:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7223504
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271976-cosmic-comp/fedora-rawhide-x86_64/07223504-cosmic-comp/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Ryan Brue 2024-03-28 03:40:19 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07225434-cosmic-comp/cosmic-comp.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07225434-cosmic-comp/cosmic-comp-0.1.0~20240328.03-1.fc41.src.rpm
Description: cosmic-comp is a rust wayland compositor based on smithay. It is also the compositor used in the upcoming COSMIC desktop environment.
Fedora Account System Username: ryanabx

This is the first COSMIC package of many that I'd like to bring into Fedora Rawhide ahead of eventually requesting a COSMIC spin of Fedora.

Comment 6 Fedora Review Service 2024-03-28 04:42:32 UTC
Created attachment 2023970 [details]
The .spec file difference from Copr build 7223504 to 7225498

Comment 7 Fedora Review Service 2024-03-28 04:42:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7225498
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271976-cosmic-comp/fedora-rawhide-x86_64/07225498-cosmic-comp/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Neal Gompa 2024-03-29 16:11:35 UTC
Initial spec review:

> Version:        %{ver}~%{date}

This does not contain the snapshot version data expected. e.g. something like "Version: %{ver}~git%{date}.%{sub %{commit} 1 7}" to ensure full snapshot versioning is present.

> Source:         cosmic-comp-%{ver}.tar.xz
> Source:         cosmic-comp-%{ver}-vendor.tar.xz

This should probably be versioned with %{commit} instead. Also, please add notes/scripts for how the tarballs are generated as comments or additional sources so it's captured in the SRPM.

> # %%license cargo-vendor.txt

Why is this commented out?

Comment 9 Fabio Valentini 2024-03-29 16:19:04 UTC
> > # %%license cargo-vendor.txt
>
> Why is this commented out?

IIUC this is commented out due to an edge case that triggers the RPM generator for bundled Provides to fail.

But if it is commented out, the "Provides: bundled(crate(foo)) = x.y.z" need to be added manually.

Comment 10 Ryan Brue 2024-04-23 05:19:49 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338624-cosmic-comp/cosmic-comp.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338624-cosmic-comp/cosmic-comp-0.1.0~git20240423.04.9022747-1.fc41.src.rpm
Description: cosmic-comp is a rust wayland compositor based on smithay. It is also the compositor used in the upcoming COSMIC desktop environment.
Fedora Account System Username: ryanabx

Comment 11 Neal Gompa 2024-04-25 19:52:33 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* GNU General Public
     License, Version 3", "GNU General Public License, Version 3",
     "Historical Permission Notice and Disclaimer - sell variant and/or NTP
     License (legal disclaimer)", "*No copyright* Mozilla Public License
     2.0", "*No copyright* Apache License 2.0", "MIT License", "BSD
     0-Clause License", "*No copyright* MIT License", "*No copyright* The
     Unlicense", "Apache License 2.0", "*No copyright* Creative Commons CC0
     1.0", "BSD 2-Clause License", "*No copyright* Apache License (v2.0) or
     MIT license and/or MIT License", "Apache License 2.0 and/or MIT
     License", "zlib License", "*No copyright* zlib License", "Apache
     License (v2.0) or MIT license", "*No copyright* Apache License (v2.0)
     or MIT license", "*No copyright* BSD 3-Clause License and/or Creative
     Commons Attribution 3.0 and/or MIT License", "Apache License (v2.0) or
     MIT license and/or BSD 3-Clause License", "BSD 3-Clause License", "ISC
     License", "Apache License 2.0 and/or BSD 3-Clause License", "*No
     copyright* SIL Open Font License", "*No copyright* Boost Software
     License 1.0", "*No copyright* Apache License (v2.0) or bsd_
     3-clause_clause", "Unicode License Agreement - Data Files and Software
     (2016)", "*No copyright* Apache License 2.0 and/or MIT License", "SIL
     Open Font License 1.1", "*No copyright* SIL Open Font License 1.1",
     "Mozilla Public License 2.0", "*No copyright* ISC License", "*No
     copyright* Artistic License 2.0", "GNU General Public License, Version
     2", "*No copyright* W3C License", "Apache License 2.0 and/or Boost
     Software License 1.0", "GNU Lesser General Public License, Version
     2.1", "W3C Software and Document Notice and License (2015-05-13)",
     "Apache License 2.0 and/or MIT License [generated file]", "Historical
     Permission Notice and Disclaimer - sell variant", "BSD 2-Clause with
     views sentence", "Khronos License", "*No copyright* BSD 2-Clause
     License and/or Mozilla Public License 2.0", "*No copyright* Public
     domain", "*No copyright* BSD 3-Clause License", "*No copyright*
     Creative Commons Attribution-ShareAlike 4.0", "MIT Open Group
     variant", "*No copyright* GNU General Public License, Version 2", "CMU
     License". 25548 files have unknown license. Detailed output of
     licensecheck in /home/ngompa/2271976-cosmic-comp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /etc/cosmic-comp
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/cosmic-comp
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
     Note: Especially check following dirs for bundled code:
     /home/ngompa/2271976-cosmic-comp/upstream-
     unpacked/Source1/vendor/input-sys/include,
     /home/ngompa/2271976-cosmic-comp/upstream-unpacked/Source1/vendor/gbm-
     sys/include, /home/ngompa/2271976-cosmic-comp/upstream-
     unpacked/Source1/vendor/pin-project/tests/include,
     /home/ngompa/2271976-cosmic-comp/upstream-
     unpacked/Source1/vendor/ash/src/extensions/ext,
     /home/ngompa/2271976-cosmic-comp/upstream-
     unpacked/Source1/vendor/qoi/ext, /home/ngompa/2271976-cosmic-
     comp/upstream-unpacked/Source1/vendor/bitflags/src/external,
     /home/ngompa/2271976-cosmic-comp/upstream-
     unpacked/Source1/vendor/uuid/src/external,
     /home/ngompa/2271976-cosmic-comp/upstream-
     unpacked/Source1/vendor/zerocopy/src/third_party,
     /home/ngompa/2271976-cosmic-comp/upstream-unpacked/Source1/vendor/pin-
     project-lite/tests/include
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: cosmic-comp-0.1.0~git20240423.04.9022747-1.fc41.x86_64.rpm
          cosmic-comp-debuginfo-0.1.0~git20240423.04.9022747-1.fc41.x86_64.rpm
          cosmic-comp-debugsource-0.1.0~git20240423.04.9022747-1.fc41.x86_64.rpm
          cosmic-comp-0.1.0~git20240423.04.9022747-1.fc41.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp4rgc93go')]
checks: 32, packages: 4

cosmic-comp.src: E: summary-too-long Compositor for the COSMIC Desktop Environment. Can also be used as a standalone compositor.
cosmic-comp.x86_64: E: summary-too-long Compositor for the COSMIC Desktop Environment. Can also be used as a standalone compositor.
cosmic-comp.src: W: summary-ended-with-dot Compositor for the COSMIC Desktop Environment. Can also be used as a standalone compositor.
cosmic-comp.x86_64: W: summary-ended-with-dot Compositor for the COSMIC Desktop Environment. Can also be used as a standalone compositor.
cosmic-comp.x86_64: W: no-manual-page-for-binary cosmic-comp
cosmic-comp.x86_64: W: no-documentation
cosmic-comp.spec: W: invalid-url Source1: cosmic-comp-90227471bf66b4f63554905becfcf3308f3fedeb-vendor.tar.xz
cosmic-comp.spec: W: invalid-url Source0: cosmic-comp-90227471bf66b4f63554905becfcf3308f3fedeb.tar.xz
cosmic-comp-debugsource.x86_64: E: files-duplicated-waste 199355
cosmic-comp.x86_64: E: explicit-lib-dependency libseat
cosmic-comp.src: E: description-line-too-long Compositor for the COSMIC Desktop Environment. Can also be used as a standalone compositor..
cosmic-comp.x86_64: E: description-line-too-long Compositor for the COSMIC Desktop Environment. Can also be used as a standalone compositor..
 4 packages and 0 specfiles checked; 6 errors, 6 warnings, 40 filtered, 6 badness; has taken 2.2 s 




Rpmlint (debuginfo)
-------------------
Checking: cosmic-comp-debuginfo-0.1.0~git20240423.04.9022747-1.fc41.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpi2b28rp5')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 1.0 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

cosmic-comp.x86_64: E: summary-too-long Compositor for the COSMIC Desktop Environment. Can also be used as a standalone compositor.
cosmic-comp.x86_64: W: summary-ended-with-dot Compositor for the COSMIC Desktop Environment. Can also be used as a standalone compositor.
cosmic-comp.x86_64: W: no-manual-page-for-binary cosmic-comp
cosmic-comp.x86_64: W: no-documentation
cosmic-comp-debugsource.x86_64: E: files-duplicated-waste 199355
cosmic-comp.x86_64: E: explicit-lib-dependency libseat
cosmic-comp.x86_64: E: description-line-too-long Compositor for the COSMIC Desktop Environment. Can also be used as a standalone compositor..
 3 packages and 0 specfiles checked; 4 errors, 3 warnings, 37 filtered, 4 badness; has taken 0.7 s 



Requires
--------
cosmic-comp (rpmlib, GLIBC filtered):
    config(cosmic-comp)
    libc.so.6()(64bit)
    libgbm.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3)(64bit)
    libgcc_s.so.1(GCC_4.2.0)(64bit)
    libinput.so.10()(64bit)
    libinput.so.10(LIBINPUT_0.12.0)(64bit)
    libinput.so.10(LIBINPUT_0.14.0)(64bit)
    libinput.so.10(LIBINPUT_0.19.0)(64bit)
    libinput.so.10(LIBINPUT_0.20.0)(64bit)
    libinput.so.10(LIBINPUT_0.21.0)(64bit)
    libinput.so.10(LIBINPUT_1.1)(64bit)
    libinput.so.10(LIBINPUT_1.19)(64bit)
    libinput.so.10(LIBINPUT_1.2)(64bit)
    libinput.so.10(LIBINPUT_1.3)(64bit)
    libinput.so.10(LIBINPUT_1.4)(64bit)
    libinput.so.10(LIBINPUT_1.5)(64bit)
    libinput.so.10(LIBINPUT_1.7)(64bit)
    libm.so.6()(64bit)
    libpixman-1.so.0()(64bit)
    libseat
    libseat.so.1()(64bit)
    libudev.so.1()(64bit)
    libudev.so.1(LIBUDEV_183)(64bit)
    libxkbcommon.so.0()(64bit)
    libxkbcommon.so.0(V_0.5.0)(64bit)
    rtld(GNU_HASH)

cosmic-comp-debuginfo (rpmlib, GLIBC filtered):

cosmic-comp-debugsource (rpmlib, GLIBC filtered):



Provides
--------
cosmic-comp:
    bundled(crate(ab_glyph))
    bundled(crate(ab_glyph_rasterizer))
    bundled(crate(addr2line))
    bundled(crate(adler))
    bundled(crate(ahash))
    bundled(crate(aho-corasick))
    bundled(crate(aliasable))
    bundled(crate(almost))
    bundled(crate(android-activity))
    bundled(crate(android-properties))
    bundled(crate(android-tzdata))
    bundled(crate(android_system_properties))
    bundled(crate(anyhow))
    bundled(crate(appendlist))
    bundled(crate(apply))
    bundled(crate(approx))
    bundled(crate(arc-swap))
    bundled(crate(arrayref))
    bundled(crate(arrayvec))
    bundled(crate(as-raw-xcb-connection))
    bundled(crate(ash))
    bundled(crate(async-broadcast))
    bundled(crate(async-channel))
    bundled(crate(async-executor))
    bundled(crate(async-fs))
    bundled(crate(async-io))
    bundled(crate(async-lock))
    bundled(crate(async-process))
    bundled(crate(async-recursion))
    bundled(crate(async-signal))
    bundled(crate(async-task))
    bundled(crate(async-trait))
    bundled(crate(atomic-waker))
    bundled(crate(atomicwrites))
    bundled(crate(autocfg))
    bundled(crate(backtrace))
    bundled(crate(base64))
    bundled(crate(bit_field))
    bundled(crate(bitflags))
    bundled(crate(block))
    bundled(crate(block-buffer))
    bundled(crate(block-sys))
    bundled(crate(block2))
    bundled(crate(blocking))
    bundled(crate(bumpalo))
    bundled(crate(bytemuck))
    bundled(crate(bytemuck_derive))
    bundled(crate(byteorder))
    bundled(crate(bytes))
    bundled(crate(calloop))
    bundled(crate(calloop-wayland-source))
    bundled(crate(cc))
    bundled(crate(cesu8))
    bundled(crate(cfg-if))
    bundled(crate(cfg_aliases))
    bundled(crate(cgmath))
    bundled(crate(chrono))
    bundled(crate(clipboard-win))
    bundled(crate(clipboard_macos))
    bundled(crate(clipboard_wayland))
    bundled(crate(clipboard_x11))
    bundled(crate(cocoa))
    bundled(crate(cocoa-foundation))
    bundled(crate(color_quant))
    bundled(crate(combine))
    bundled(crate(concurrent-queue))
    bundled(crate(const-random))
    bundled(crate(const-random-macro))
    bundled(crate(core-foundation))
    bundled(crate(core-foundation-sys))
    bundled(crate(core-graphics))
    bundled(crate(core-graphics-types))
    bundled(crate(cosmic-config))
    bundled(crate(cosmic-config-derive))
    bundled(crate(cosmic-protocols))
    bundled(crate(cosmic-text))
    bundled(crate(cosmic-theme))
    bundled(crate(cpufeatures))
    bundled(crate(crc32fast))
    bundled(crate(crossbeam-channel))
    bundled(crate(crossbeam-deque))
    bundled(crate(crossbeam-epoch))
    bundled(crate(crossbeam-utils))
    bundled(crate(crunchy))
    bundled(crate(crypto-common))
    bundled(crate(css-color))
    bundled(crate(csscolorparser))
    bundled(crate(ctor))
    bundled(crate(cursor-icon))
    bundled(crate(darling))
    bundled(crate(darling_core))
    bundled(crate(darling_macro))
    bundled(crate(dashmap))
    bundled(crate(data-url))
    bundled(crate(deranged))
    bundled(crate(derivative))
    bundled(crate(derive_setters))
    bundled(crate(digest))
    bundled(crate(dirs))
    bundled(crate(dirs-sys))
    bundled(crate(dispatch))
    bundled(crate(displaydoc))
    bundled(crate(dlib))
    bundled(crate(dlv-list))
    bundled(crate(downcast-rs))
    bundled(crate(drm))
    bundled(crate(drm-ffi))
    bundled(crate(drm-fourcc))
    bundled(crate(drm-sys))
    bundled(crate(ecolor))
    bundled(crate(edid-rs))
    bundled(crate(egui))
    bundled(crate(egui_extras))
    bundled(crate(egui_glow))
    bundled(crate(egui_plot))
    bundled(crate(either))
    bundled(crate(emath))
    bundled(crate(encoding_rs))
    bundled(crate(enum-map))
    bundled(crate(enum-map-derive))
    bundled(crate(enumflags2))
    bundled(crate(enumflags2_derive))
    bundled(crate(epaint))
    bundled(crate(equivalent))
    bundled(crate(errno))
    bundled(crate(error-code))
    bundled(crate(euclid))
    bundled(crate(event-listener))
    bundled(crate(event-listener-strategy))
    bundled(crate(exr))
    bundled(crate(fast-srgb8))
    bundled(crate(fastrand))
    bundled(crate(fdeflate))
    bundled(crate(filetime))
    bundled(crate(find-crate))
    bundled(crate(flate2))
    bundled(crate(float-cmp))
    bundled(crate(fluent))
    bundled(crate(fluent-bundle))
    bundled(crate(fluent-langneg))
    bundled(crate(fluent-syntax))
    bundled(crate(flume))
    bundled(crate(fnv))
    bundled(crate(font-types))
    bundled(crate(fontconfig-parser))
    bundled(crate(fontdb))
    bundled(crate(foreign-types))
    bundled(crate(foreign-types-macros))
    bundled(crate(foreign-types-shared))
    bundled(crate(form_urlencoded))
    bundled(crate(fraction))
    bundled(crate(freedesktop-icons))
    bundled(crate(fsevent-sys))
    bundled(crate(futures))
    bundled(crate(futures-channel))
    bundled(crate(futures-core))
    bundled(crate(futures-executor))
    bundled(crate(futures-io))
    bundled(crate(futures-lite))
    bundled(crate(futures-macro))
    bundled(crate(futures-sink))
    bundled(crate(futures-task))
    bundled(crate(futures-util))
    bundled(crate(gbm))
    bundled(crate(gbm-sys))
    bundled(crate(generator))
    bundled(crate(generic-array))
    bundled(crate(gethostname))
    bundled(crate(getrandom))
    bundled(crate(gif))
    bundled(crate(gimli))
    bundled(crate(gl_generator))
    bundled(crate(glam))
    bundled(crate(glow))
    bundled(crate(grid))
    bundled(crate(half))
    bundled(crate(hashbrown))
    bundled(crate(heck))
    bundled(crate(hermit-abi))
    bundled(crate(hex))
    bundled(crate(hmac))
    bundled(crate(home))
    bundled(crate(i18n-config))
    bundled(crate(i18n-embed))
    bundled(crate(i18n-embed-fl))
    bundled(crate(i18n-embed-impl))
    bundled(crate(iana-time-zone))
    bundled(crate(iana-time-zone-haiku))
    bundled(crate(iced))
    bundled(crate(iced_core))
    bundled(crate(iced_futures))
    bundled(crate(iced_graphics))
    bundled(crate(iced_renderer))
    bundled(crate(iced_runtime))
    bundled(crate(iced_style))
    bundled(crate(iced_tiny_skia))
    bundled(crate(iced_widget))
    bundled(crate(icrate))
    bundled(crate(id_tree))
    bundled(crate(ident_case))
    bundled(crate(idna))
    bundled(crate(image))
    bundled(crate(imagesize))
    bundled(crate(indexmap))
    bundled(crate(inotify))
    bundled(crate(inotify-sys))
    bundled(crate(input))
    bundled(crate(input-sys))
    bundled(crate(instant))
    bundled(crate(intl-memoizer))
    bundled(crate(intl_pluralrules))
    bundled(crate(io-lifetimes))
    bundled(crate(itoa))
    bundled(crate(jni))
    bundled(crate(jni-sys))
    bundled(crate(jobserver))
    bundled(crate(jpeg-decoder))
    bundled(crate(js-sys))
    bundled(crate(kamadak-exif))
    bundled(crate(keyframe))
    bundled(crate(khronos_api))
    bundled(crate(known-folders))
    bundled(crate(kqueue))
    bundled(crate(kqueue-sys))
    bundled(crate(kurbo))
    bundled(crate(lazy_static))
    bundled(crate(lebe))
    bundled(crate(libc))
    bundled(crate(libcosmic))
    bundled(crate(libloading))
    bundled(crate(libm))
    bundled(crate(libredox))
    bundled(crate(libseat))
    bundled(crate(libseat-sys))
    bundled(crate(libsystemd))
    bundled(crate(libudev-sys))
    bundled(crate(linux-raw-sys))
    bundled(crate(locale_config))
    bundled(crate(lock_api))
    bundled(crate(log))
    bundled(crate(log-panics))
    bundled(crate(loom))
    bundled(crate(lyon_geom))
    bundled(crate(lyon_path))
    bundled(crate(malloc_buf))
    bundled(crate(matchers))
    bundled(crate(memchr))
    bundled(crate(memmap2))
    bundled(crate(memoffset))
    bundled(crate(mime))
    bundled(crate(mime_guess))
    bundled(crate(minimal-lexical))
    bundled(crate(miniz_oxide))
    bundled(crate(mint))
    bundled(crate(mio))
    bundled(crate(mutate_once))
    bundled(crate(nanorand))
    bundled(crate(ndk))
    bundled(crate(ndk-context))
    bundled(crate(ndk-sys))
    bundled(crate(nix))
    bundled(crate(nohash-hasher))
    bundled(crate(nom))
    bundled(crate(notify))
    bundled(crate(nu-ansi-term))
    bundled(crate(num))
    bundled(crate(num-bigint))
    bundled(crate(num-complex))
    bundled(crate(num-integer))
    bundled(crate(num-iter))
    bundled(crate(num-rational))
    bundled(crate(num-traits))
    bundled(crate(num_cpus))
    bundled(crate(num_enum))
    bundled(crate(num_enum_derive))
    bundled(crate(num_threads))
    bundled(crate(objc))
    bundled(crate(objc-foundation))
    bundled(crate(objc-sys))
    bundled(crate(objc2))
    bundled(crate(objc2-encode))
    bundled(crate(objc_id))
    bundled(crate(object))
    bundled(crate(once_cell))
    bundled(crate(option-ext))
    bundled(crate(orbclient))
    bundled(crate(ordered-float))
    bundled(crate(ordered-multimap))
    bundled(crate(ordered-stream))
    bundled(crate(ouroboros))
    bundled(crate(ouroboros_macro))
    bundled(crate(overload))
    bundled(crate(owned_ttf_parser))
    bundled(crate(palette))
    bundled(crate(palette_derive))
    bundled(crate(parking))
    bundled(crate(parking_lot))
    bundled(crate(parking_lot_core))
    bundled(crate(paste))
    bundled(crate(percent-encoding))
    bundled(crate(phf))
    bundled(crate(phf_generator))
    bundled(crate(phf_macros))
    bundled(crate(phf_shared))
    bundled(crate(pico-args))
    bundled(crate(pin-project))
    bundled(crate(pin-project-internal))
    bundled(crate(pin-project-lite))
    bundled(crate(pin-utils))
    bundled(crate(piper))
    bundled(crate(pixman))
    bundled(crate(pixman-sys))
    bundled(crate(pkg-config))
    bundled(crate(png))
    bundled(crate(polling))
    bundled(crate(powerfmt))
    bundled(crate(ppv-lite86))
    bundled(crate(proc-macro-crate))
    bundled(crate(proc-macro-error))
    bundled(crate(proc-macro-error-attr))
    bundled(crate(proc-macro2))
    bundled(crate(profiling))
    bundled(crate(profiling-procmacros))
    bundled(crate(qoi))
    bundled(crate(quick-xml))
    bundled(crate(quote))
    bundled(crate(rand))
    bundled(crate(rand_chacha))
    bundled(crate(rand_core))
    bundled(crate(rangemap))
    bundled(crate(raw-window-handle))
    bundled(crate(rayon))
    bundled(crate(rayon-core))
    bundled(crate(rctree))
    bundled(crate(read-fonts))
    bundled(crate(redox_syscall))
    bundled(crate(redox_users))
    bundled(crate(regex))
    bundled(crate(regex-automata))
    bundled(crate(regex-syntax))
    bundled(crate(renderdoc))
    bundled(crate(renderdoc-sys))
    bundled(crate(resvg))
    bundled(crate(rgb))
    bundled(crate(ron))
    bundled(crate(roxmltree))
    bundled(crate(rust-embed))
    bundled(crate(rust-embed-impl))
    bundled(crate(rust-embed-utils))
    bundled(crate(rust-ini))
    bundled(crate(rustc-demangle))
    bundled(crate(rustc-hash))
    bundled(crate(rustix))
    bundled(crate(rustversion))
    bundled(crate(rustybuzz))
    bundled(crate(ryu))
    bundled(crate(same-file))
    bundled(crate(sanitize-filename))
    bundled(crate(scan_fmt))
    bundled(crate(scoped-tls))
    bundled(crate(scopeguard))
    bundled(crate(self_cell))
    bundled(crate(sendfd))
    bundled(crate(serde))
    bundled(crate(serde_derive))
    bundled(crate(serde_json))
    bundled(crate(serde_repr))
    bundled(crate(serde_spanned))
    bundled(crate(sha1))
    bundled(crate(sha2))
    bundled(crate(sharded-slab))
    bundled(crate(signal-hook-registry))
    bundled(crate(simd-adler32))
    bundled(crate(simplecss))
    bundled(crate(siphasher))
    bundled(crate(slab))
    bundled(crate(slotmap))
    bundled(crate(smallvec))
    bundled(crate(smithay))
    bundled(crate(smithay-client-toolkit))
    bundled(crate(smithay-clipboard))
    bundled(crate(smithay-egui))
    bundled(crate(smol_str))
    bundled(crate(snowflake))
    bundled(crate(socket2))
    bundled(crate(softbuffer))
    bundled(crate(spin))
    bundled(crate(static_assertions))
    bundled(crate(strict-num))
    bundled(crate(strsim))
    bundled(crate(subtle))
    bundled(crate(svgtypes))
    bundled(crate(swash))
    bundled(crate(syn))
    bundled(crate(sys-locale))
    bundled(crate(taffy))
    bundled(crate(tempfile))
    bundled(crate(thiserror))
    bundled(crate(thiserror-impl))
    bundled(crate(thread_local))
    bundled(crate(tiff))
    bundled(crate(time))
    bundled(crate(time-core))
    bundled(crate(time-macros))
    bundled(crate(tiny-keccak))
    bundled(crate(tiny-skia))
    bundled(crate(tiny-skia-path))
    bundled(crate(tiny-xlib))
    bundled(crate(tinystr))
    bundled(crate(tinyvec))
    bundled(crate(tinyvec_macros))
    bundled(crate(toml))
    bundled(crate(toml_datetime))
    bundled(crate(toml_edit))
    bundled(crate(tracing))
    bundled(crate(tracing-attributes))
    bundled(crate(tracing-core))
    bundled(crate(tracing-journald))
    bundled(crate(tracing-log))
    bundled(crate(tracing-subscriber))
    bundled(crate(tracy-client))
    bundled(crate(tracy-client-sys))
    bundled(crate(ttf-parser))
    bundled(crate(type-map))
    bundled(crate(typenum))
    bundled(crate(udev))
    bundled(crate(uds_windows))
    bundled(crate(unic-langid))
    bundled(crate(unic-langid-impl))
    bundled(crate(unicase))
    bundled(crate(unicode-bidi))
    bundled(crate(unicode-bidi-mirroring))
    bundled(crate(unicode-ccc))
    bundled(crate(unicode-ident))
    bundled(crate(unicode-linebreak))
    bundled(crate(unicode-normalization))
    bundled(crate(unicode-properties))
    bundled(crate(unicode-script))
    bundled(crate(unicode-segmentation))
    bundled(crate(unicode-vo))
    bundled(crate(url))
    bundled(crate(usvg))
    bundled(crate(usvg-parser))
    bundled(crate(usvg-text-layout))
    bundled(crate(usvg-tree))
    bundled(crate(uuid))
    bundled(crate(valuable))
    bundled(crate(version_check))
    bundled(crate(waker-fn))
    bundled(crate(walkdir))
    bundled(crate(wasi))
    bundled(crate(wasm-bindgen))
    bundled(crate(wasm-bindgen-backend))
    bundled(crate(wasm-bindgen-futures))
    bundled(crate(wasm-bindgen-macro))
    bundled(crate(wasm-bindgen-macro-support))
    bundled(crate(wasm-bindgen-shared))
    bundled(crate(wasm-timer))
    bundled(crate(wayland-backend))
    bundled(crate(wayland-client))
    bundled(crate(wayland-csd-frame))
    bundled(crate(wayland-cursor))
    bundled(crate(wayland-egl))
    bundled(crate(wayland-protocols))
    bundled(crate(wayland-protocols-misc))
    bundled(crate(wayland-protocols-plasma))
    bundled(crate(wayland-protocols-wlr))
    bundled(crate(wayland-scanner))
    bundled(crate(wayland-server))
    bundled(crate(wayland-sys))
    bundled(crate(web-sys))
    bundled(crate(web-time))
    bundled(crate(weezl))
    bundled(crate(winapi))
    bundled(crate(winapi-i686-pc-windows-gnu))
    bundled(crate(winapi-util))
    bundled(crate(winapi-x86_64-pc-windows-gnu))
    bundled(crate(window_clipboard))
    bundled(crate(windows))
    bundled(crate(windows-core))
    bundled(crate(windows-sys))
    bundled(crate(windows-targets))
    bundled(crate(windows_aarch64_gnullvm))
    bundled(crate(windows_aarch64_msvc))
    bundled(crate(windows_i686_gnu))
    bundled(crate(windows_i686_msvc))
    bundled(crate(windows_x86_64_gnu))
    bundled(crate(windows_x86_64_gnullvm))
    bundled(crate(windows_x86_64_msvc))
    bundled(crate(winit))
    bundled(crate(winnow))
    bundled(crate(wio))
    bundled(crate(x11-dl))
    bundled(crate(x11rb))
    bundled(crate(x11rb-protocol))
    bundled(crate(xcursor))
    bundled(crate(xdg))
    bundled(crate(xdg-home))
    bundled(crate(xdg-user))
    bundled(crate(xkbcommon))
    bundled(crate(xkbcommon-dl))
    bundled(crate(xkeysym))
    bundled(crate(xml-rs))
    bundled(crate(xmlparser))
    bundled(crate(xmlwriter))
    bundled(crate(xxhash-rust))
    bundled(crate(yazi))
    bundled(crate(zbus))
    bundled(crate(zbus_macros))
    bundled(crate(zbus_names))
    bundled(crate(zeno))
    bundled(crate(zerocopy))
    bundled(crate(zerocopy-derive))
    bundled(crate(zune-inflate))
    bundled(crate(zvariant))
    bundled(crate(zvariant_derive))
    bundled(crate(zvariant_utils))
    config(cosmic-comp)
    cosmic-comp
    cosmic-comp(x86-64)

cosmic-comp-debuginfo:
    cosmic-comp-debuginfo
    cosmic-comp-debuginfo(x86-64)
    debuginfo(build-id)

cosmic-comp-debugsource:
    cosmic-comp-debugsource
    cosmic-comp-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2271976 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: Perl, fonts, R, Haskell, Ocaml, SugarActivity, Python, PHP, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 12 Neal Gompa 2024-04-25 19:58:43 UTC
(In reply to Neal Gompa from comment #11)
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> 
> 
> Issues:
> =======
> - If your application is a C or C++ application you must list a
>   BuildRequires against gcc, gcc-c++ or clang.
>   Note: No gcc, gcc-c++ or clang found in BuildRequires
>   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
> 
> 

I don't think this applies here?

> ===== MUST items =====
> 
> C/C++:
> [-]: Provides: bundled(gnulib) in place as required.
>      Note: Sources not installed
> [x]: Package does not contain kernel modules.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Package contains no static executables.
> [x]: Rpath absent or only used for internal libs.
> 
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
>      other legal requirements as defined in the legal section of Packaging
>      Guidelines.
> [x]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "Unknown or generated", "*No copyright* GNU General Public
>      License, Version 3", "GNU General Public License, Version 3",
>      "Historical Permission Notice and Disclaimer - sell variant and/or NTP
>      License (legal disclaimer)", "*No copyright* Mozilla Public License
>      2.0", "*No copyright* Apache License 2.0", "MIT License", "BSD
>      0-Clause License", "*No copyright* MIT License", "*No copyright* The
>      Unlicense", "Apache License 2.0", "*No copyright* Creative Commons CC0
>      1.0", "BSD 2-Clause License", "*No copyright* Apache License (v2.0) or
>      MIT license and/or MIT License", "Apache License 2.0 and/or MIT
>      License", "zlib License", "*No copyright* zlib License", "Apache
>      License (v2.0) or MIT license", "*No copyright* Apache License (v2.0)
>      or MIT license", "*No copyright* BSD 3-Clause License and/or Creative
>      Commons Attribution 3.0 and/or MIT License", "Apache License (v2.0) or
>      MIT license and/or BSD 3-Clause License", "BSD 3-Clause License", "ISC
>      License", "Apache License 2.0 and/or BSD 3-Clause License", "*No
>      copyright* SIL Open Font License", "*No copyright* Boost Software
>      License 1.0", "*No copyright* Apache License (v2.0) or bsd_
>      3-clause_clause", "Unicode License Agreement - Data Files and Software
>      (2016)", "*No copyright* Apache License 2.0 and/or MIT License", "SIL
>      Open Font License 1.1", "*No copyright* SIL Open Font License 1.1",
>      "Mozilla Public License 2.0", "*No copyright* ISC License", "*No
>      copyright* Artistic License 2.0", "GNU General Public License, Version
>      2", "*No copyright* W3C License", "Apache License 2.0 and/or Boost
>      Software License 1.0", "GNU Lesser General Public License, Version
>      2.1", "W3C Software and Document Notice and License (2015-05-13)",
>      "Apache License 2.0 and/or MIT License [generated file]", "Historical
>      Permission Notice and Disclaimer - sell variant", "BSD 2-Clause with
>      views sentence", "Khronos License", "*No copyright* BSD 2-Clause
>      License and/or Mozilla Public License 2.0", "*No copyright* Public
>      domain", "*No copyright* BSD 3-Clause License", "*No copyright*
>      Creative Commons Attribution-ShareAlike 4.0", "MIT Open Group
>      variant", "*No copyright* GNU General Public License, Version 2", "CMU
>      License". 25548 files have unknown license. Detailed output of
>      licensecheck in /home/ngompa/2271976-cosmic-comp/licensecheck.txt
> [x]: License file installed when any subpackage combination is installed.
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /etc/cosmic-comp
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /etc/cosmic-comp

Adding "%dir %{_sysconfdir}/cosmic-comp" to the %files section fixes this.


> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
>      Note: Especially check following dirs for bundled code:
>      /home/ngompa/2271976-cosmic-comp/upstream-
>      unpacked/Source1/vendor/input-sys/include,
>      /home/ngompa/2271976-cosmic-comp/upstream-unpacked/Source1/vendor/gbm-
>      sys/include, /home/ngompa/2271976-cosmic-comp/upstream-
>      unpacked/Source1/vendor/pin-project/tests/include,
>      /home/ngompa/2271976-cosmic-comp/upstream-
>      unpacked/Source1/vendor/ash/src/extensions/ext,
>      /home/ngompa/2271976-cosmic-comp/upstream-
>      unpacked/Source1/vendor/qoi/ext, /home/ngompa/2271976-cosmic-
>      comp/upstream-unpacked/Source1/vendor/bitflags/src/external,
>      /home/ngompa/2271976-cosmic-comp/upstream-
>      unpacked/Source1/vendor/uuid/src/external,
>      /home/ngompa/2271976-cosmic-comp/upstream-
>      unpacked/Source1/vendor/zerocopy/src/third_party,
>      /home/ngompa/2271976-cosmic-comp/upstream-unpacked/Source1/vendor/pin-
>      project-lite/tests/include
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [-]: Package contains desktop file if it is a GUI application.
> [-]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
>      names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [-]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [x]: Useful -debuginfo package or justification otherwise.
> [x]: Package is not known to require an ExcludeArch tag.
> [x]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
>      one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
>      Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
>      license(s) in its own file, then that file, containing the text of the
>      license(s) for the package is included in %license.
> [x]: The License field must be a valid SPDX expression.
> [x]: Package does not own files or directories owned by other packages.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install.
> [x]: %config files are marked noreplace or the reason is justified.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package must not depend on deprecated() packages.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>      work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: No %config files under /usr.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
>      provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
>      %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Large documentation must go in a -doc subpackage. Large could be size
>      (~1MB) or number of files.
>      Note: Documentation size is 0 bytes in 0 files.
> [x]: Packages must not store files under /srv, /opt or /usr/local
> 
> ===== SHOULD items =====
> 
> Generic:
> [x]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.
> [x]: Final provides and requires are sane (see attachments).
> [x]: Package functions as described.
> [x]: Latest version is packaged.
> [x]: Package does not include license text files separate from upstream.
> [!]: SourceX tarball generation or download is documented.
>      Note: Package contains tarball without URL, check comments

Your custom tarball generation needs to be documented somehow. Or if it's not custom anymore, change it to point to fetch them from GitHub directly, like so:

Source0: %{url}/archive/%{commit}/%{name}-%{commit}.tar.gz

> [-]: Sources are verified with gpgverify first in %prep if upstream
>      publishes signatures.
>      Note: gpgverify is not used.
> [x]: Package should compile and build into binary rpms on all supported
>      architectures.
> [x]: %check is present and all tests pass.
> [x]: Packages should try to preserve timestamps of original installed
>      files.
> [x]: Reviewer should test that the package builds in mock.
> [x]: Buildroot is not present
> [x]: Package has no %clean section with rm -rf %{buildroot} (or
>      $RPM_BUILD_ROOT)
> [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
> [x]: Fully versioned dependency in subpackages if applicable.
> [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> [x]: SourceX is a working URL.
> [x]: Spec use %global instead of %define unless justified.
> 
> ===== EXTRA items =====
> 
> Generic:
> [x]: Rpmlint is run on debuginfo package(s).
>      Note: No rpmlint messages.
> [x]: Rpmlint is run on all installed packages.
>      Note: There are rpmlint messages (see attachment).
> [x]: Large data in /usr/share should live in a noarch subpackage if package
>      is arched.
> [x]: Spec file according to URL is the same as in SRPM.
> 
> 
> Rpmlint
> -------
> Checking: cosmic-comp-0.1.0~git20240423.04.9022747-1.fc41.x86_64.rpm
>          
> cosmic-comp-debuginfo-0.1.0~git20240423.04.9022747-1.fc41.x86_64.rpm
>          
> cosmic-comp-debugsource-0.1.0~git20240423.04.9022747-1.fc41.x86_64.rpm
>           cosmic-comp-0.1.0~git20240423.04.9022747-1.fc41.src.rpm
> ============================ rpmlint session starts
> ============================
> rpmlint: 2.5.0
> configuration:
>     /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
>     /etc/xdg/rpmlint/fedora-legacy-licenses.toml
>     /etc/xdg/rpmlint/fedora-spdx-licenses.toml
>     /etc/xdg/rpmlint/fedora.toml
>     /etc/xdg/rpmlint/scoring.toml
>     /etc/xdg/rpmlint/users-groups.toml
>     /etc/xdg/rpmlint/warn-on-functions.toml
> rpmlintrc: [PosixPath('/tmp/tmp4rgc93go')]
> checks: 32, packages: 4
> 
> cosmic-comp.src: E: summary-too-long Compositor for the COSMIC Desktop
> Environment. Can also be used as a standalone compositor.
> cosmic-comp.x86_64: E: summary-too-long Compositor for the COSMIC Desktop
> Environment. Can also be used as a standalone compositor.
> cosmic-comp.src: W: summary-ended-with-dot Compositor for the COSMIC Desktop
> Environment. Can also be used as a standalone compositor.
> cosmic-comp.x86_64: W: summary-ended-with-dot Compositor for the COSMIC
> Desktop Environment. Can also be used as a standalone compositor.
> cosmic-comp.x86_64: W: no-manual-page-for-binary cosmic-comp
> cosmic-comp.x86_64: W: no-documentation
> cosmic-comp.spec: W: invalid-url Source1:
> cosmic-comp-90227471bf66b4f63554905becfcf3308f3fedeb-vendor.tar.xz
> cosmic-comp.spec: W: invalid-url Source0:
> cosmic-comp-90227471bf66b4f63554905becfcf3308f3fedeb.tar.xz
> cosmic-comp-debugsource.x86_64: E: files-duplicated-waste 199355
> cosmic-comp.x86_64: E: explicit-lib-dependency libseat
> cosmic-comp.src: E: description-line-too-long Compositor for the COSMIC
> Desktop Environment. Can also be used as a standalone compositor..
> cosmic-comp.x86_64: E: description-line-too-long Compositor for the COSMIC
> Desktop Environment. Can also be used as a standalone compositor..
>  4 packages and 0 specfiles checked; 6 errors, 6 warnings, 40 filtered, 6
> badness; has taken 2.2 s 
> 

This is easily fixed by reflowing some of the text in the description.

Comment 13 Neal Gompa 2024-04-25 20:20:12 UTC
You also need to document how the vendor tarball is made.

Comment 14 Ryan Brue 2024-04-28 17:21:19 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377353-cosmic-comp/cosmic-comp.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377353-cosmic-comp/cosmic-comp-0.1.0~git20240426.18.9022747-1.fc41.src.rpm
Description: cosmic-comp is a rust wayland compositor based on smithay. It is also the compositor used in the upcoming COSMIC desktop environment.
Fedora Account System Username: ryanabx

Comment 15 Neal Gompa 2024-04-28 17:23:48 UTC
This looks good now.

PACKAGE APPROVED.

Comment 16 Neal Gompa 2024-04-28 17:26:13 UTC
Since this is your first package, I've sponsored you to become a packager in the Fedora contributor community. Welcome and enjoy!

Comment 17 Fedora Admin user for bugzilla script actions 2024-04-29 07:02:02 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-comp

Comment 18 Fedora Update System 2024-05-14 19:34:40 UTC
FEDORA-2024-318b055a25 (cosmic-comp-0.1.0~git20240514.00.36bf611-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-318b055a25

Comment 19 Fedora Update System 2024-05-14 19:50:18 UTC
FEDORA-2024-318b055a25 (cosmic-comp-0.1.0~git20240514.00.36bf611-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.