Bug 2271985 - Review Request: xdg-desktop-portal-cosmic - XDG Desktop Portals implementation for the COSMIC desktop environment
Summary: Review Request: xdg-desktop-portal-cosmic - XDG Desktop Portals implementatio...
Keywords:
Status: RELEASE_PENDING
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/pop-os/xdg-desktop...
Whiteboard:
Depends On:
Blocks: COSMICDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2024-03-28 02:39 UTC by Ryan Brue
Modified: 2024-09-28 19:42 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7225421 to 7494023 (2.73 KB, patch)
2024-05-26 21:54 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8010429 to 8086840 (2.35 KB, patch)
2024-09-28 05:11 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2024-03-28 03:29:54 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7225421
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271985-xdg-desktop-portal-cosmic/fedora-rawhide-x86_64/07225421-xdg-desktop-portal-cosmic/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fedora Review Service 2024-05-26 21:54:42 UTC
Created attachment 2035246 [details]
The .spec file difference from Copr build 7225421 to 7494023

Comment 6 Fedora Review Service 2024-05-26 21:54:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7494023
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271985-xdg-desktop-portal-cosmic/fedora-rawhide-x86_64/07494023-xdg-desktop-portal-cosmic/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fedora Review Service 2024-09-12 01:35:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8010429
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271985-xdg-desktop-portal-cosmic/fedora-rawhide-x86_64/08010429-xdg-desktop-portal-cosmic/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- Not a valid SPDX expression '0BSD OR MIT OR Apache-2.0 AND Apache-2.0 AND Apache-2.0 OR MIT AND Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT AND BSD-2-Clause AND BSD-3-Clause AND BSL-1.0 AND CC0-1.0 AND GPL-3.0 AND GPL-3.0-or-later AND ISC AND MIT AND MIT OR Apache-2.0 AND MIT OR Apache-2.0 OR CC0-1.0 AND MIT OR Apache-2.0 OR Zlib AND MIT OR Zlib OR Apache-2.0 AND MPL-2.0 AND Unlicense OR MIT AND Zlib AND Zlib OR Apache-2.0 OR MIT'.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Fedora Review Service 2024-09-28 05:11:30 UTC
Created attachment 2049235 [details]
The .spec file difference from Copr build 8010429 to 8086840

Comment 11 Fedora Review Service 2024-09-28 05:11:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8086840
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271985-xdg-desktop-portal-cosmic/fedora-rawhide-x86_64/08086840-xdg-desktop-portal-cosmic/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 12 Neal Gompa 2024-09-28 16:40:15 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines (using vendored crates for now)

Package APPROVED.

===

Recommended post-import tasks:

- set up package on release-monitoring.org:

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- add @cosmic-sig with "admin" access as package co-maintainer

- set bugzilla assignee overrides to @cosmic-sig

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 13 Fedora Admin user for bugzilla script actions 2024-09-28 19:42:40 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/xdg-desktop-portal-cosmic


Note You need to log in before you can comment on or make changes to this bug.