Bug 2271986 - Review Request: cosmic-edit - Text editor for the COSMIC desktop environment
Summary: Review Request: cosmic-edit - Text editor for the COSMIC desktop environment
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/pop-os/cosmic-edit
Whiteboard:
Depends On:
Blocks: COSMICDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2024-03-28 02:41 UTC by Ryan Brue
Modified: 2025-11-17 16:56 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-11-17 16:56:29 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7225423 to 8010430 (4.40 KB, patch)
2024-09-12 01:50 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8010430 to 8086843 (2.49 KB, patch)
2024-09-28 04:59 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2024-03-28 03:38:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7225423
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271986-cosmic-edit/fedora-rawhide-x86_64/07225423-cosmic-edit/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fedora Review Service 2024-09-12 01:50:32 UTC
Created attachment 2046454 [details]
The .spec file difference from Copr build 7225423 to 8010430

Comment 6 Fedora Review Service 2024-09-12 01:50:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8010430
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271986-cosmic-edit/fedora-rawhide-x86_64/08010430-cosmic-edit/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fedora Review Service 2024-09-28 04:59:16 UTC
Created attachment 2049233 [details]
The .spec file difference from Copr build 8010430 to 8086843

Comment 9 Fedora Review Service 2024-09-28 04:59:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8086843
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271986-cosmic-edit/fedora-rawhide-x86_64/08086843-cosmic-edit/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Neal Gompa 2024-09-28 16:41:31 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines (using vendored crates for now)

Package APPROVED.

===

Recommended post-import tasks:

- set up package on release-monitoring.org:

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- add @cosmic-sig with "admin" access as package co-maintainer

- set bugzilla assignee overrides to @cosmic-sig

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 11 Fedora Admin user for bugzilla script actions 2024-09-28 19:43:07 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-edit

Comment 12 Package Review 2025-11-17 16:56:29 UTC
Package is now in repositories, closing review.


Note You need to log in before you can comment on or make changes to this bug.