Bug 2271987 - Review Request: cosmic-files - File manager for the COSMIC desktop environment
Summary: Review Request: cosmic-files - File manager for the COSMIC desktop environment
Keywords:
Status: RELEASE_PENDING
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/pop-os/cosmic-files
Whiteboard:
Depends On:
Blocks: COSMICDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2024-03-28 02:44 UTC by Ryan Brue
Modified: 2024-09-28 19:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7225427 to 8010431 (4.45 KB, patch)
2024-09-12 01:58 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8010431 to 8086846 (2.92 KB, patch)
2024-09-28 05:24 UTC, Fedora Review Service
no flags Details | Diff

Description Ryan Brue 2024-03-28 02:44:06 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07225351-cosmic-files/cosmic-files.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07225351-cosmic-files/cosmic-files-0.1.0~20240328.02-1.fc41.src.rpm
Description: cosmic-files is a file manager for the COSMIC desktop environment, created using libcosmic toolkit
Fedora Account System Username: ryanabx

Comment 1 Fedora Review Service 2024-03-28 03:04:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7225427
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271987-cosmic-files/fedora-rawhide-x86_64/07225427-cosmic-files/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ryan Brue 2024-04-28 17:27:28 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377360-cosmic-files/cosmic-files.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377360-cosmic-files/cosmic-files-0.1.0~git20240426.18.49f130b-1.fc41.src.rpm
Description: cosmic-files is a file manager for the COSMIC desktop environment, created using libcosmic toolkit
Fedora Account System Username: ryanabx

Comment 3 Ryan Brue 2024-09-11 17:06:58 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004520-cosmic-files/cosmic-files.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004520-cosmic-files/cosmic-files-0.1.0~%5E20240910git15c93cc-1.fc42.src.rpm
Description: cosmic-files is a file manager for the COSMIC desktop environment, created using libcosmic toolkit
Fedora Account System Username: ryanabx

Comment 4 Fedora Review Service 2024-09-12 01:58:53 UTC
Created attachment 2046455 [details]
The .spec file difference from Copr build 7225427 to 8010431

Comment 5 Fedora Review Service 2024-09-12 01:58:55 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8010431
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271987-cosmic-files/fedora-rawhide-x86_64/08010431-cosmic-files/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Ryan Brue 2024-09-28 03:50:30 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085290-cosmic-files/cosmic-files.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085290-cosmic-files/cosmic-files-1.0.0~alpha.2-1.fc42.src.rpm
Description: cosmic-files is a file manager for the COSMIC desktop environment, created using libcosmic toolkit
Fedora Account System Username: ryanabx

Comment 7 Fedora Review Service 2024-09-28 05:24:50 UTC
Created attachment 2049237 [details]
The .spec file difference from Copr build 8010431 to 8086846

Comment 8 Fedora Review Service 2024-09-28 05:24:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8086846
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271987-cosmic-files/fedora-rawhide-x86_64/08086846-cosmic-files/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Neal Gompa 2024-09-28 16:42:45 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines (using vendored crates for now)

Package APPROVED.

===

Recommended post-import tasks:

- set up package on release-monitoring.org:

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- add @cosmic-sig with "admin" access as package co-maintainer

- set bugzilla assignee overrides to @cosmic-sig

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 10 Fedora Admin user for bugzilla script actions 2024-09-28 19:43:28 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-files


Note You need to log in before you can comment on or make changes to this bug.