Bug 2272141 - Review Request: cosmic-store - app store for the COSMIC desktop environment
Summary: Review Request: cosmic-store - app store for the COSMIC desktop environment
Keywords:
Status: RELEASE_PENDING
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/pop-os/cosmic-store
Whiteboard:
Depends On:
Blocks: COSMICDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2024-03-29 02:01 UTC by Ryan Brue
Modified: 2024-09-28 19:46 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7231035 to 8010441 (4.44 KB, patch)
2024-09-12 01:28 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8010441 to 8086881 (2.49 KB, patch)
2024-09-28 04:44 UTC, Fedora Review Service
no flags Details | Diff

Description Ryan Brue 2024-03-29 02:01:56 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07227890-cosmic-store/cosmic-store.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07227890-cosmic-store/cosmic-store-0.1.0~20240328.17-1.fc41.src.rpm
Description: cosmic-store is a work-in-progress app store for the COSMIC desktop environment, like gnome-software and kde-discover
Fedora Account System Username: ryanabx

Comment 1 Ryan Brue 2024-04-23 05:33:29 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338642-cosmic-store/cosmic-store.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338642-cosmic-store/cosmic-store-0.1.0~git20240423.04.7407be1-1.fc41.src.rpm
Description: cosmic-store is a work-in-progress app store for the COSMIC desktop environment, like gnome-software and kde-discover
Fedora Account System Username: ryanabx

Comment 2 Ryan Brue 2024-04-28 17:36:25 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377936-cosmic-store/cosmic-store.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377936-cosmic-store/cosmic-store-0.1.0~git20240426.23.225ebca-1.fc41.src.rpm
Description: cosmic-store is a work-in-progress app store for the COSMIC desktop environment, like gnome-software and kde-discover
Fedora Account System Username: ryanabx

Comment 3 Ryan Brue 2024-09-11 17:20:59 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08000186-cosmic-store/cosmic-store.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08000186-cosmic-store/cosmic-store-0.1.0~%5E20240906git8ffd810-1.fc42.src.rpm
Description: cosmic-store is a work-in-progress app store for the COSMIC desktop environment, like gnome-software and kde-discover
Fedora Account System Username: ryanabx

Comment 4 Fedora Review Service 2024-09-12 01:28:30 UTC
Created attachment 2046452 [details]
The .spec file difference from Copr build 7231035 to 8010441

Comment 5 Fedora Review Service 2024-09-12 01:28:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8010441
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272141-cosmic-store/fedora-rawhide-x86_64/08010441-cosmic-store/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- License file license.rs is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Ryan Brue 2024-09-28 03:57:36 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085274-cosmic-store/cosmic-store.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085274-cosmic-store/cosmic-store-1.0.0~alpha.2-1.fc42.src.rpm
Description: cosmic-store is a work-in-progress app store for the COSMIC desktop environment, like gnome-software and kde-discover
Fedora Account System Username: ryanabx

Comment 7 Fedora Review Service 2024-09-28 04:44:56 UTC
Created attachment 2049231 [details]
The .spec file difference from Copr build 8010441 to 8086881

Comment 8 Fedora Review Service 2024-09-28 04:44:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8086881
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272141-cosmic-store/fedora-rawhide-x86_64/08086881-cosmic-store/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- License file license.rs is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Neal Gompa 2024-09-28 17:02:54 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines (using vendored crates for now)

Package APPROVED.

===

Recommended post-import tasks:

- set up package on release-monitoring.org:

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- add @cosmic-sig with "admin" access as package co-maintainer

- set bugzilla assignee overrides to @cosmic-sig

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 10 Fedora Admin user for bugzilla script actions 2024-09-28 19:46:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-store


Note You need to log in before you can comment on or make changes to this bug.