Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07231024-cosmic-icons/cosmic-icons.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07231024-cosmic-icons/cosmic-icons-0.1.0~20240329.01-1.fc41.src.rpm Description: cosmic-icons is the icon theme for the COSMIC desktop environment, dependent on pop-icon-theme Fedora Account System Username: ryanabx
Copr build: https://copr.fedorainfracloud.org/coprs/build/7231040 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272143-cosmic-icons/fedora-rawhide-x86_64/07231040-cosmic-icons/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338632-cosmic-icons/cosmic-icons.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338632-cosmic-icons/cosmic-icons-0.1.0~git20240423.04.ee87327-1.fc41.src.rpm Description: cosmic-icons is the icon theme for the COSMIC desktop environment, dependent on pop-icon-theme Fedora Account System Username: ryanabx
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377361-cosmic-icons/cosmic-icons.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377361-cosmic-icons/cosmic-icons-0.1.0~git20240426.18.ee87327-1.fc41.src.rpm Description: cosmic-icons is the icon theme for the COSMIC desktop environment, dependent on pop-icon-theme Fedora Account System Username: ryanabx
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07493838-cosmic-icon-theme/cosmic-icon-theme.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07493838-cosmic-icon-theme/cosmic-icon-theme-0.1.0~git20240526.18.9aad1ab-1.fc41.src.rpm Description: cosmic-icon-theme is the icon theme for the COSMIC desktop environment, dependent on pop-icon-theme Fedora Account System Username: ryanabx
Taking this review.
Spec review: > %define debug_package %{nil} This should be replaced with "BuildArch: noarch" instead. > Source: cosmic-icon-theme-%{commit}.tar.xz Is there a reason this can't use a proper SourceURL to get the sources?
Packaging guidelines reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_revision
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07497312-cosmic-icon-theme/cosmic-icon-theme.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07497312-cosmic-icon-theme/cosmic-icon-theme-0.1.0~git20240528.04.9aad1ab-1.fc41.src.rpm Description: cosmic-icon-theme is the icon theme for the COSMIC desktop environment, dependent on pop-icon-theme Fedora Account System Username: ryanabx
> %dir %{_datadir}/icons/Cosmic > %{_datadir}/icons/Cosmic/scalable/* > %{_datadir}/icons/Cosmic/index.theme This can be simplified to "%{_datadir}/icons/Cosmic/"
> BuildArch: noarch Can you move this to be next to BuildRequires lines? It's weird being at the very top.
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07500455-cosmic-icon-theme/cosmic-icon-theme.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07500455-cosmic-icon-theme/cosmic-icon-theme-0.1.0~git20240528.19.9aad1ab-1.fc41.src.rpm Description: cosmic-icon-theme is the icon theme for the COSMIC desktop environment, dependent on pop-icon-theme Fedora Account System Username: ryanabx
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled and recorded * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-icon-theme
FEDORA-2024-5760098c44 (cosmic-icon-theme-0.1.0~^20240717.183339git73be037-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5760098c44
FEDORA-2024-5760098c44 (cosmic-icon-theme-0.1.0~^20240717.183339git73be037-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.