Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07227887-cosmic-session/cosmic-session.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07227887-cosmic-session/cosmic-session-0.1.0~20240328.17-1.fc41.src.rpm Description: cosmic-session is the session manager for the COSMIC desktop environment. Note: the package requires most of the other COSMIC components in order to run. Fedora Account System Username: ryanabx
Copr build: https://copr.fedorainfracloud.org/coprs/build/7231191 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272146-cosmic-session/fedora-rawhide-x86_64/07231191-cosmic-session/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Systemd user unit service file(s) in cosmic-session Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338639-cosmic-session/cosmic-session.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338639-cosmic-session/cosmic-session-0.1.0~git20240423.04.54c0955-1.fc41.src.rpm Description: cosmic-session is the session manager for the COSMIC desktop environment. Note: the package requires most of the other COSMIC components in order to run. Fedora Account System Username: ryanabx
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377368-cosmic-session/cosmic-session.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377368-cosmic-session/cosmic-session-0.1.0~git20240426.18.54c0955-1.fc41.src.rpm Description: cosmic-session is the session manager for the COSMIC desktop environment. Note: the package requires most of the other COSMIC components in order to run. Fedora Account System Username: ryanabx
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004516-cosmic-session/cosmic-session.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004516-cosmic-session/cosmic-session-0.1.0~%5E20240902git39c7f93-1.fc42.src.rpm Description: cosmic-session is the session manager for the COSMIC desktop environment. Note: the package requires most of the other COSMIC components in order to run. Fedora Account System Username: ryanabx
Created attachment 2046445 [details] The .spec file difference from Copr build 7231191 to 8010446
Copr build: https://copr.fedorainfracloud.org/coprs/build/8010446 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272146-cosmic-session/fedora-rawhide-x86_64/08010446-cosmic-session/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Systemd user unit service file(s) in cosmic-session Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085287-cosmic-session/cosmic-session.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085287-cosmic-session/cosmic-session-1.0.0~alpha.2-1.fc42.src.rpm Description: cosmic-session is the session manager for the COSMIC desktop environment. Note: the package requires most of the other COSMIC components in order to run. Fedora Account System Username: ryanabx
Created attachment 2049217 [details] The .spec file difference from Copr build 8010446 to 8086889
Copr build: https://copr.fedorainfracloud.org/coprs/build/8086889 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272146-cosmic-session/fedora-rawhide-x86_64/08086889-cosmic-session/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Systemd user unit service file(s) in cosmic-session Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines (using vendored crates for now) Package APPROVED. === Extra notes: - These all require everything to be at the minimum of the same version for all the cosmic components. Please add ">= %{version}" to all of the cosmic-* package Requires lines in the spec on import. === Recommended post-import tasks: - set up package on release-monitoring.org: - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - add @cosmic-sig with "admin" access as package co-maintainer - set bugzilla assignee overrides to @cosmic-sig - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-session