Spec URL: https://farchord.fedorapeople.org/reviews/marknote/marknote.spec SRPM URL: https://farchord.fedorapeople.org/reviews/marknote/marknote-1.0.0-1.fc40.src.rpm Description: Marknote lets you create rich text notes and easily organise them into notebooks. You can personalise your notebooks by choosing an icon and accent color for each one, making it easy to distinguish between them and keep your notes at your fingertips. Fedora Account System Username: farchord
Taking this review.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled and recorded * No serious issues from rpmlint Note: fedora-review brought up spelling errors. Please switch "organise" and "personalise" to "organize" and "personalize" respectively on import (we use en_US for descriptions). PACKAGE APPROVED.
Thank you for the review, Neal
The Pagure repository was created at https://src.fedoraproject.org/rpms/marknote
I have a question here, which how to properly do license analysis. The license field in .spec file: > License: BSD-3-Clause AND CC-BY-SA-4.0 AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND GPL-3.0-or-later AND LGPL-2.0-only AND LGPL-2.1-or-later AND LGPL-3.0-only Looking at the files of parent direcory: .gitlab-ci.yml : # SPDX-License-Identifier: CC0-1.0 .kde-ci.yml : # SPDX-License-Identifier: CC0-1.0 CMakeLists.txt : # SPDX-License-Identifier: BSD-3-Clause org.kde.marknote.desktop : # SPDX-License-Identifier: CC0-1.0 org.kde.marknote.metainfo.xml : SPDX-License-Identifier: CC0-1.0 src/CMakeLists.txt : # SPDX-License-Identifier: BSD-3-Clause src/Messages.sh : # SPDX-License-Identifier: CC0-1.0 src/documenthandler.cpp : // SPDX-License-Identifier: BSD-3-Clause src/documenthandler.h : // SPDX-License-Identifier: BSD-3-Clause src/main.cpp : SPDX-License-Identifier: GPL-2.0-or-later src/nestedlisthelper.cpp : * SPDX-License-Identifier: LGPL-2.1-or-later src/nestedlisthelper_p.h : * SPDX-License-Identifier: LGPL-2.1-or-later src/notebooksmodel.cpp : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/notebooksmodel.h : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/notesmodel.cpp : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/notesmodel.h : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/texteditor.cpp : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/texteditor.h : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/qml/AddNotebookDialog.qml : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/qml/EditPage.qml : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/qml/Main.qml : SPDX-License-Identifier: GPL-2.0-or-later src/qml/NotesPage.qml : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/qml/WelcomePage.qml : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/qml/components/ActionButton.qml : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/qml/components/BottomDrawer.qml : // SPDX-License-Identifier: LGPL-2.0-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-GPL src/qml/components/DoubleActionButton.qml : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL Here obviously, LicenseRef-KDE-Accepted-GPL -> GPL-2.0-only OR GPL-3.0-only, LicenseRef-KDE-Accepted-LGPL - LGPL-2.1-only OR LGPL-3.0-only. https://docs.fedoraproject.org/en-US/legal/update-existing-packages/#_licenseref_kde_accepted In addition, org.kde.marknote.svg is CC-BY-SA-4.0, https://invent.kde.org/office/marknote/-/blob/master/.reuse/dep5#L10-12 What file is GPL-3.0-or-later? I only see it here, https://invent.kde.org/office/marknote/-/blob/master/.reuse/dep5#L14-16
I only use a script to print these file name and its "SPDX-License-Identifier" line. It may have something wrong.
(In reply to Felix Wang from comment #5) > I have a question here, which how to properly do license analysis. The > license field in .spec file: > > License: BSD-3-Clause AND CC-BY-SA-4.0 AND CC0-1.0 AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND GPL-3.0-or-later AND LGPL-2.0-only AND LGPL-2.1-or-later AND LGPL-3.0-only > > Looking at the files of parent direcory: > > .gitlab-ci.yml : # SPDX-License-Identifier: CC0-1.0 > .kde-ci.yml : # SPDX-License-Identifier: CC0-1.0 > CMakeLists.txt : # SPDX-License-Identifier: BSD-3-Clause > org.kde.marknote.desktop : # SPDX-License-Identifier: CC0-1.0 > org.kde.marknote.metainfo.xml : SPDX-License-Identifier: CC0-1.0 > src/CMakeLists.txt : # SPDX-License-Identifier: BSD-3-Clause > src/Messages.sh : # SPDX-License-Identifier: CC0-1.0 > src/documenthandler.cpp : // SPDX-License-Identifier: BSD-3-Clause > src/documenthandler.h : // SPDX-License-Identifier: BSD-3-Clause > src/main.cpp : SPDX-License-Identifier: GPL-2.0-or-later > src/nestedlisthelper.cpp : * SPDX-License-Identifier: LGPL-2.1-or-later > src/nestedlisthelper_p.h : * SPDX-License-Identifier: LGPL-2.1-or-later > src/notebooksmodel.cpp : // SPDX-License-Identifier: GPL-2.0-only OR > GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/notebooksmodel.h : // SPDX-License-Identifier: GPL-2.0-only OR > GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/notesmodel.cpp : // SPDX-License-Identifier: GPL-2.0-only OR > GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/notesmodel.h : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only > OR LicenseRef-KDE-Accepted-GPL > src/texteditor.cpp : // SPDX-License-Identifier: GPL-2.0-only OR > GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/texteditor.h : // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only > OR LicenseRef-KDE-Accepted-GPL > src/qml/AddNotebookDialog.qml : // SPDX-License-Identifier: GPL-2.0-only OR > GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/qml/EditPage.qml : // SPDX-License-Identifier: GPL-2.0-only OR > GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/qml/Main.qml : SPDX-License-Identifier: GPL-2.0-or-later > src/qml/NotesPage.qml : // SPDX-License-Identifier: GPL-2.0-only OR > GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/qml/WelcomePage.qml : // SPDX-License-Identifier: GPL-2.0-only OR > GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/qml/components/ActionButton.qml : // SPDX-License-Identifier: > GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/qml/components/BottomDrawer.qml : // SPDX-License-Identifier: > LGPL-2.0-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > src/qml/components/DoubleActionButton.qml : // SPDX-License-Identifier: > GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL > > Here obviously, LicenseRef-KDE-Accepted-GPL -> GPL-2.0-only OR GPL-3.0-only, > LicenseRef-KDE-Accepted-LGPL - LGPL-2.1-only OR LGPL-3.0-only. > https://docs.fedoraproject.org/en-US/legal/update-existing-packages/ > #_licenseref_kde_accepted > > In addition, org.kde.marknote.svg is CC-BY-SA-4.0, > https://invent.kde.org/office/marknote/-/blob/master/.reuse/dep5#L10-12 > > What file is GPL-3.0-or-later? I only see it here, > https://invent.kde.org/office/marknote/-/blob/master/.reuse/dep5#L14-16 Actually, we ignore any of the 'LicenseRef's from the KDE foundation after checking with the licensing team.