Spec URL: https://principis.fedorapeople.org/kzones.spec SRPM URL: https://principis.fedorapeople.org/kzones-0.7-1.fc39.src.rpm Description: KDE KWin Script for snapping windows into zones. Handy when using a (super) ultrawide monitor, an alternative to PowerToys FancyZones and Windows 11 snap layouts. Fedora Account System Username: principis
Changed requires to kwin >= 6.0. kzones 0.7 does not work on Plasma 5. I plan to build kzones 0.6 for f39 and f38. Also removed the random qt lines... Spec URL: https://principis.fedorapeople.org/kzones.spec SRPM URL: https://principis.fedorapeople.org/kzones-0.7-1.fc39.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/fedora/2272451-kzones/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7384037 bytes in 8 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3". 16 files have unknown license. Detailed output of licensecheck in /home/fedora/2272451-kzones/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/kwin, /usr/share/kwin/scripts [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [=]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kzones- docs [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: kzones-0.7-1.fc41.noarch.rpm kzones-docs-0.7-1.fc41.noarch.rpm kzones-0.7-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpphcgvbg7')] checks: 32, packages: 3 kzones.noarch: E: spelling-error ('ultrawide', '%description -l en_US ultrawide -> ultra wide, ultra-wide, ultramodern') kzones.src: E: spelling-error ('ultrawide', '%description -l en_US ultrawide -> ultra wide, ultra-wide, ultramodern') kzones.noarch: W: no-documentation 3 packages and 0 specfiles checked; 2 errors, 1 warnings, 10 filtered, 2 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 kzones.noarch: E: spelling-error ('ultrawide', '%description -l en_US ultrawide -> ultra wide, ultra-wide, ultramodern') kzones.noarch: W: no-documentation 2 packages and 0 specfiles checked; 1 errors, 1 warnings, 6 filtered, 1 badness; has taken 0.2 s Source checksums ---------------- https://github.com/gerritdevriese/kzones/archive/v0.7/kzones-0.7.tar.gz : CHECKSUM(SHA256) this package : 11f77e7893786b10343c63f31745c981b80e31a341ee0acc64cc9cd2c0936e9f CHECKSUM(SHA256) upstream package : baea1b5eb4d8e50be2023c09aa684f716b3e7fd0f371a6a7f062f3c4f0f5adad diff -r also reports differences Requires -------- kzones (rpmlib, GLIBC filtered): kwin kzones-docs (rpmlib, GLIBC filtered): Provides -------- kzones: kzones kzones-docs: kzones-docs Diff spec file in url and in SRPM --------------------------------- --- /home/fedora/2272451-kzones/srpm/kzones.spec 2024-05-02 08:21:50.488543237 +0000 +++ /home/fedora/2272451-kzones/srpm-unpacked/kzones.spec 2024-04-01 00:00:00.000000000 +0000 @@ -16,4 +16,8 @@ Requires: kwin >= 6.0 +%if %{with tests} +BuildRequires: pkgconfig(Qt%{qtver}Test) +%endif + %description KDE KWin Script for snapping windows into zones. Handy when using a (super) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2272451 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, Java, Perl, PHP, Haskell, Ocaml, Python, SugarActivity, R, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments a) Is kwin also required for the build? b) Docs subpackage should require main package or also have the license file c) Please check correct source is used
Thanks for the review! (In reply to Benson Muite from comment #2) > Comments > a) Is kwin also required for the build? No, there is nothing to build, just copying files. > b) Docs subpackage should require main package or also have the license file Done. > c) Please check correct source is used (weird...) Done. Spec URL: https://principis.fedorapeople.org/kzones.spec SRPM URL: https://principis.fedorapeople.org/kzones-0.7-1.fc41.src.rpm
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/8453619 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272451-kzones/fedora-rawhide-x86_64/08453619-kzones/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Comments: a) To ensure directory ownership, please change %license LICENSE.md %{_datadir}/kwin/scripts/%{name} to %license LICENSE.md %dir %{_datadir}/kwin %dir %{_datadir}/kwin/scripts %{_datadir}/kwin/scripts/%{name} b) Please update to latest release 0.9 c) It otherwise seems ok. Please fix (a) and (b) before import. Approved.