Bug 2272468 - cephfs-top: include the missing fields in --dump output
Summary: cephfs-top: include the missing fields in --dump output
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: CephFS
Version: 7.1
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
: 7.1
Assignee: Jos Collin
QA Contact: Hemanth Kumar
Akash Raj
URL:
Whiteboard:
Depends On: 2184991
Blocks: 2267614 2298578 2298579
TreeView+ depends on / blocked
 
Reported: 2024-04-01 12:40 UTC by Jos Collin
Modified: 2024-07-18 07:59 UTC (History)
9 users (show)

Fixed In Version: ceph-18.2.1-122.el9cp
Doc Type: Bug Fix
Doc Text:
.Missing fields, such as `date`, `client_count`, `filters` are added to the `--dump` output. With this fix, missing fields, such as `date`, `client_count`, `filters` are added to the `--dump` output.
Clone Of: 2184991
Environment:
Last Closed: 2024-06-13 14:30:52 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHCEPH-8705 0 None None None 2024-04-01 12:44:16 UTC
Red Hat Product Errata RHSA-2024:3925 0 None None None 2024-06-13 14:30:57 UTC

Description Jos Collin 2024-04-01 12:40:05 UTC
+++ This bug was initially created as a clone of Bug #2184991 +++

Description of problem:
It would be nice if cephfs-top dumps it's computed values to stdout in json format. The json should contain all the fields & corresponding values displayed on the cephfs-top screen for each client, so currently there are 20 fields for a client. When cephfs-top is run with this new option, the ncurses mode would be disabled. This would be really useful if some other module want to access these values exported from cephfs-top, especially for writing qa tests.

--- Additional comment from Hemanth Kumar on 2023-09-12 06:27:20 UTC ---

Hi Venky,

As I see this feature is available Upstream(https://docs.ceph.com/en/quincy/cephfs/cephfs-top/#command-line-options) - Is it possible to backport it downstream so that we can automate the cephfs-top TCs?

Currently - cephfs-top testing is done manually and this "cephfs-top --dump" command will help us in covering the feature through automation.

--- Additional comment from Venky Shankar on 2023-09-12 10:40:42 UTC ---

(In reply to Hemanth Kumar from comment #1)
> Hi Venky,
> 
> As I see this feature is available
> Upstream(https://docs.ceph.com/en/quincy/cephfs/cephfs-top/#command-line-
> options) - Is it possible to backport it downstream so that we can automate
> the cephfs-top TCs?
> 
> Currently - cephfs-top testing is done manually and this "cephfs-top --dump"
> command will help us in covering the feature through automation.

Generally, we do not backport test case changes to downstream, but given that this involves changing cephfs-top itself as an aid to writing tests, I think that's a fair point.

Will try to pick this up for z3.

--- Additional comment from Hemanth Kumar on 2023-09-12 10:59:54 UTC ---

(In reply to Venky Shankar from comment #2)
> (In reply to Hemanth Kumar from comment #1)
> > Hi Venky,
> > 
> > As I see this feature is available
> > Upstream(https://docs.ceph.com/en/quincy/cephfs/cephfs-top/#command-line-
> > options) - Is it possible to backport it downstream so that we can automate
> > the cephfs-top TCs?
> > 
> > Currently - cephfs-top testing is done manually and this "cephfs-top --dump"
> > command will help us in covering the feature through automation.
> 
> Generally, we do not backport test case changes to downstream, but given
> that this involves changing cephfs-top itself as an aid to writing tests, I
> think that's a fair point.
> 
> Will try to pick this up for z3.

Thanks for considering this Venky.

--- Additional comment from Jos Collin on 2023-11-08 04:39:48 UTC ---

rebased MR https://gitlab.cee.redhat.com/ceph/ceph/-/merge_requests/378.

--- Additional comment from Venky Shankar on 2023-11-08 09:40:53 UTC ---

Not urgent for z3.

--- Additional comment from Venky Shankar on 2024-01-04 12:07:54 UTC ---

This is a test only enhancement. Not really required for downstream release.

--- Additional comment from Hemanth Kumar on 2024-04-01 05:22:30 UTC ---

Hi Venky,

Can we have this options available in downstream builds, we are planning to have the automation coverage for cephfs-top as well as helps in cephfs mds metrics test coverage.

--- Additional comment from Venky Shankar on 2024-04-01 09:09:10 UTC ---

(In reply to Hemanth Kumar from comment #7)
> Hi Venky,
> 
> Can we have this options available in downstream builds, we are planning to
> have the automation coverage for cephfs-top as well as helps in cephfs mds
> metrics test coverage.

If it helps automating, then sure. When there is a z6, this can be taken in.

We need this BZ to be clones for 7.0/7.1 as well then.

Jos, please do the needful and refresh the MR.

Comment 8 errata-xmlrpc 2024-06-13 14:30:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Critical: Red Hat Ceph Storage 7.1 security, enhancements, and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:3925


Note You need to log in before you can comment on or make changes to this bug.