+ package name is OK
+ license is acceptable for Fedora: GPL-2.0-or-later
+ builds and installs OK
+ BR/P/R look correct
+ no scriptlets needed or present
+ rpmlint finds no big issue
+ tests passed

Approved.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[ ]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[ ]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64, /usr/include, /usr,
     /usr/src/debug, /usr/share, /usr/lib64/pkgconfig, /usr/bin,
     /usr/share/man/man1, /usr/share/licenses, /usr/share/man, /usr/lib,
     /usr/src, /usr/share/doc
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64, /usr/share/man,
     /usr/share/doc, /usr/include, /usr/share/man/man1, /usr/src, /usr,
     /usr/lib64/pkgconfig, /usr/lib, /usr/src/debug, /usr/bin, /usr/share,
     /usr/share/licenses
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 386 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     ffmpegthumbnailer-libs , ffmpegthumbnailer-devel
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: ffmpegthumbnailer-2.2.2-1.20240105git1b5a779.fc41.x86_64.rpm
          ffmpegthumbnailer-libs-2.2.2-1.20240105git1b5a779.fc41.x86_64.rpm
          ffmpegthumbnailer-devel-2.2.2-1.20240105git1b5a779.fc41.x86_64.rpm
          ffmpegthumbnailer-debuginfo-2.2.2-1.20240105git1b5a779.fc41.x86_64.rpm
          ffmpegthumbnailer-debugsource-2.2.2-1.20240105git1b5a779.fc41.x86_64.rpm
          ffmpegthumbnailer-2.2.2-1.20240105git1b5a779.fc41.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpjss7p5h5')]
checks: 32, packages: 6

ffmpegthumbnailer.src: E: spelling-error ('videoformats', '%description -l en_US videoformats -> video formats, video-formats, performative')
ffmpegthumbnailer.x86_64: E: spelling-error ('videoformats', '%description -l en_US videoformats -> video formats, video-formats, performative')
ffmpegthumbnailer-devel.x86_64: W: no-documentation
ffmpegthumbnailer.x86_64: E: incorrect-fsf-address /usr/share/licenses/ffmpegthumbnailer/COPYING
ffmpegthumbnailer-devel.x86_64: E: incorrect-fsf-address /usr/include/libffmpegthumbnailer/ffmpegthumbnailertypes.h
ffmpegthumbnailer-devel.x86_64: E: incorrect-fsf-address /usr/include/libffmpegthumbnailer/filmstripfilter.h
ffmpegthumbnailer-devel.x86_64: E: incorrect-fsf-address /usr/include/libffmpegthumbnailer/ifilter.h
ffmpegthumbnailer-devel.x86_64: E: incorrect-fsf-address /usr/include/libffmpegthumbnailer/imagetypes.h
ffmpegthumbnailer-devel.x86_64: E: incorrect-fsf-address /usr/include/libffmpegthumbnailer/videoframe.h
ffmpegthumbnailer-devel.x86_64: E: incorrect-fsf-address /usr/include/libffmpegthumbnailer/videothumbnailer.h
ffmpegthumbnailer-devel.x86_64: E: incorrect-fsf-address /usr/include/libffmpegthumbnailer/videothumbnailerc.h
 6 packages and 0 specfiles checked; 10 errors, 1 warnings, 60 filtered, 10 badness; has taken 0.5 s 




Rpmlint (debuginfo)
-------------------
Checking: ffmpegthumbnailer-libs-debuginfo-2.2.2-1.20240105git1b5a779.fc41.x86_64.rpm
          ffmpegthumbnailer-debuginfo-2.2.2-1.20240105git1b5a779.fc41.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpi8pxkaqb')]
checks: 32, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 15 filtered, 0 badness; has taken 0.2 s 





Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "ffmpegthumbnailer-devel".
(none): E: there is no installed rpm "ffmpegthumbnailer-libs".
(none): E: there is no installed rpm "ffmpegthumbnailer-libs-debuginfo".
(none): E: there is no installed rpm "ffmpegthumbnailer-debuginfo".
(none): E: there is no installed rpm "ffmpegthumbnailer-debugsource".
(none): E: there is no installed rpm "ffmpegthumbnailer".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 6

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/dirkvdb/ffmpegthumbnailer/archive/1b5a77983240bcf00a4ef7702c07bcd8f4e5f97c/ffmpegthumbnailer-1b5a77983240bcf00a4ef7702c07bcd8f4e5f97c.tar.gz :
  CHECKSUM(SHA256) this package     : 12e10076616c17b89286246b77d4318f242229aee2974d3c479bf8f46203a05c
  CHECKSUM(SHA256) upstream package : 12e10076616c17b89286246b77d4318f242229aee2974d3c479bf8f46203a05c


Requires
--------
ffmpegthumbnailer (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libffmpegthumbnailer.so.4()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

ffmpegthumbnailer-libs (rpmlib, GLIBC filtered):
    libavcodec.so.60()(64bit)
    libavcodec.so.60(LIBAVCODEC_60)(64bit)
    libavfilter.so.9()(64bit)
    libavfilter.so.9(LIBAVFILTER_9)(64bit)
    libavformat.so.60()(64bit)
    libavformat.so.60(LIBAVFORMAT_60)(64bit)
    libavutil.so.58()(64bit)
    libavutil.so.58(LIBAVUTIL_58)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libjpeg.so.62()(64bit)
    libjpeg.so.62(LIBJPEG_6.2)(64bit)
    libm.so.6()(64bit)
    libpng16.so.16()(64bit)
    libpng16.so.16(PNG16_0)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

ffmpegthumbnailer-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    ffmpegthumbnailer-libs
    libffmpegthumbnailer.so.4()(64bit)

ffmpegthumbnailer-debuginfo (rpmlib, GLIBC filtered):

ffmpegthumbnailer-debugsource (rpmlib, GLIBC filtered):



Provides
--------
ffmpegthumbnailer:
    ffmpegthumbnailer
    ffmpegthumbnailer(x86-64)

ffmpegthumbnailer-libs:
    ffmpegthumbnailer-libs
    ffmpegthumbnailer-libs(x86-64)
    libffmpegthumbnailer.so.4()(64bit)

ffmpegthumbnailer-devel:
    ffmpegthumbnailer-devel
    ffmpegthumbnailer-devel(x86-64)
    pkgconfig(libffmpegthumbnailer)

ffmpegthumbnailer-debuginfo:
    debuginfo(build-id)
    ffmpegthumbnailer-debuginfo
    ffmpegthumbnailer-debuginfo(x86-64)

ffmpegthumbnailer-debugsource:
    ffmpegthumbnailer-debugsource
    ffmpegthumbnailer-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name ffmpegthumbnailer --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: R, fonts, Python, PHP, Haskell, SugarActivity, Ocaml, Java, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

The Pagure repository was created at https://src.fedoraproject.org/rpms/ffmpegthumbnailer

FEDORA-2024-38a428fe31 (ffmpegthumbnailer-2.2.2-1.20240105git1b5a779.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-38a428fe31

FEDORA-2024-38a428fe31 (ffmpegthumbnailer-2.2.2-1.20240105git1b5a779.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Thanks for getting this package into Fedora. Please note that:
1. It is included in RPM Fusion, so it would've been nice to announce your intent to get it into Fedora
   and ask RPM Fusion maintainer(s) if they're interested in (co)maintaining. No issue, though. I've
   just notified one of RPM Fusion admins and ffmpegthumbnailer is now retired there.
2. There's a Multimedia SIG in Fedora that aims to share maintenance of Fedora multimedia stack.
   Since your package depends on FFmpeg, we encourage you to add @multimedia-sig group as co-maintainers
   to your package to have your package rebuilt and/or fixed by one of us in case it's necessary when we
   update FFmpeg. You're also welcome to join our Matrix room at #multimedia:fedoraproject.org.

(In reply to Dominik 'Rathann' Mierzejewski from comment #5)
> Thanks for getting this package into Fedora. Please note that:
> 1. It is included in RPM Fusion, so it would've been nice to announce your
> intent to get it into Fedora
>    and ask RPM Fusion maintainer(s) if they're interested in
> (co)maintaining. No issue, though. I've
>    just notified one of RPM Fusion admins and ffmpegthumbnailer is now
> retired there.
> 2. There's a Multimedia SIG in Fedora that aims to share maintenance of
> Fedora multimedia stack.
>    Since your package depends on FFmpeg, we encourage you to add
> @multimedia-sig group as co-maintainers
>    to your package to have your package rebuilt and/or fixed by one of us in
> case it's necessary when we
>    update FFmpeg. You're also welcome to join our Matrix room at
> #multimedia:fedoraproject.org.

Thanks for your advice. I have granted multimedia-sig group with commit rights.