python-aiohttp-cors fails to build with pytest 8. + /usr/bin/python3 -m pytest -v --ignore tests/integration/test_real_browser.py ============================= test session starts ============================== platform linux -- Python 3.12.2, pytest-8.1.1, pluggy-1.4.0 -- /usr/bin/python3 cachedir: .pytest_cache rootdir: /builddir/build/BUILD/aiohttp-cors-0.7.0 plugins: aiohttp-1.0.5, asyncio-0.21.0 asyncio: mode=Mode.STRICT collecting ... collected 93 items INTERNALERROR> Traceback (most recent call last): INTERNALERROR> File "/usr/lib/python3.12/site-packages/_pytest/main.py", line 285, in wrap_session INTERNALERROR> session.exitstatus = doit(config, session) or 0 INTERNALERROR> ^^^^^^^^^^^^^^^^^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/_pytest/main.py", line 338, in _main INTERNALERROR> config.hook.pytest_collection(session=session) INTERNALERROR> File "/usr/lib/python3.12/site-packages/pluggy/_hooks.py", line 501, in __call__ INTERNALERROR> return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) INTERNALERROR> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/pluggy/_manager.py", line 119, in _hookexec INTERNALERROR> return self._inner_hookexec(hook_name, methods, kwargs, firstresult) INTERNALERROR> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/pluggy/_callers.py", line 138, in _multicall INTERNALERROR> raise exception.with_traceback(exception.__traceback__) INTERNALERROR> File "/usr/lib/python3.12/site-packages/pluggy/_callers.py", line 121, in _multicall INTERNALERROR> teardown.throw(exception) # type: ignore[union-attr] INTERNALERROR> ^^^^^^^^^^^^^^^^^^^^^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/_pytest/logging.py", line 793, in pytest_collection INTERNALERROR> return (yield) INTERNALERROR> ^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/pluggy/_callers.py", line 121, in _multicall INTERNALERROR> teardown.throw(exception) # type: ignore[union-attr] INTERNALERROR> ^^^^^^^^^^^^^^^^^^^^^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/_pytest/warnings.py", line 120, in pytest_collection INTERNALERROR> return (yield) INTERNALERROR> ^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/pluggy/_callers.py", line 121, in _multicall INTERNALERROR> teardown.throw(exception) # type: ignore[union-attr] INTERNALERROR> ^^^^^^^^^^^^^^^^^^^^^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/_pytest/config/__init__.py", line 1415, in pytest_collection INTERNALERROR> return (yield) INTERNALERROR> ^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/pluggy/_callers.py", line 102, in _multicall INTERNALERROR> res = hook_impl.function(*args) INTERNALERROR> ^^^^^^^^^^^^^^^^^^^^^^^^^ INTERNALERROR> File "/usr/lib/python3.12/site-packages/_pytest/main.py", line 349, in pytest_collection INTERNALERROR> session.perform_collect() INTERNALERROR> File "/usr/lib/python3.12/site-packages/_pytest/main.py", line 815, in perform_collect INTERNALERROR> self.config.pluginmanager.check_pending() INTERNALERROR> File "/usr/lib/python3.12/site-packages/pluggy/_manager.py", line 384, in check_pending INTERNALERROR> raise PluginValidationError( INTERNALERROR> pluggy._manager.PluginValidationError: unknown hook 'pytest_cmdline_preparse' in plugin <module 'conftest' from '/builddir/build/BUILD/aiohttp-cors-0.7.0/conftest.py'> https://docs.pytest.org/en/stable/deprecations.html#implementing-the-pytest-cmdline-preparse-hook https://docs.pytest.org/en/stable/changelog.html For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/thrnciar/pytest/fedora-rawhide-x86_64/07247689-python-aiohttp-cors/ For all our attempts to build python-aiohttp-cors with pytest 8, see: https://copr.fedorainfracloud.org/coprs/thrnciar/pytest/package/python-aiohttp-cors/ Let us know here if you have any questions. Pytest 8 is planned to be included in Fedora 41. And this bugzilla is a heads up before we merge new pytest into rawhide. For more info see a Fedora Change proposal https://fedoraproject.org/wiki/Changes/Pytest_8 We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.
PR: https://src.fedoraproject.org/rpms/python-aiohttp-cors/pull-request/3
Merged in rawhide. But please forward your patch upstream, they might merge it or suggest another approach (if even python3.5 is still relevant, even el7 soon EOL is at python 3.6)
I've opened upstream PR - https://github.com/aio-libs/aiohttp-cors/pull/482