Bug 2274601 - Review Request: golang-github-containerd - An open and reliable container runtime
Summary: Review Request: golang-github-containerd - An open and reliable container run...
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sergio Basto
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2177352
TreeView+ depends on / blocked
 
Reported: 2024-04-11 20:07 UTC by Maxwell G
Modified: 2024-04-12 21:44 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
sergio: fedora-review+


Attachments (Terms of Use)

Comment 1 Sergio Basto 2024-04-12 16:27:42 UTC
[fedora-review-service-build]

Comment 2 Sergio Basto 2024-04-12 20:54:06 UTC
ackage Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


===== MUST items =====

C/C++:
[ ]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[ ]: Package does not contain kernel modules.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Unknown or generated", "*No
     copyright* Apache License 2.0", "Apache License 2.0", "*No copyright*
     Apache License 2.0 and/or Creative Commons Attribution 4.0", "BSD
     2-Clause License", "MIT License", "BSD 3-Clause License", "Apache
     License 2.0 and/or MIT License", "BSD 3-Clause License and/or MIT
     License", "*No copyright* MIT License", "ISC License", "Apache License
     2.0 and/or Creative Commons Attribution 4.0", "*No copyright* Mozilla
     Public License 2.0", "Apache License 2.0 and/or GNU Lesser General
     Public License, Version 3", "*No copyright* BSD 2-Clause License",
     "Apache License 2.0 [generated file]". 2298 files have unknown
     license. Detailed output of licensecheck in /var/lib/copr-
     rpmbuild/results/golang-github-containerd/licensecheck.txt
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/gocode/src, /usr/share,
     /usr/share/licenses, /usr, /usr/share/gocode, /usr/share/doc
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gocode/src,
     /usr/share, /usr/share/licenses, /usr, /usr/share/gocode,
     /usr/share/doc
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
     Note: Especially check following dirs for bundled code: /var/lib/copr-
     rpmbuild/results/golang-github-containerd/upstream-
     unpacked/Source0/containerd-1.6.23/vendor/k8s.io/apimachinery/third_party
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 713064 bytes in 36 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: golang-github-containerd-devel-1.6.23-1.fc41.noarch.rpm
          golang-github-containerd-1.6.23-1.fc41.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpiuk7vody')]
checks: 32, packages: 2

golang-github-containerd.spec:24: W: unversioned-explicit-provides deprecated()
golang-github-containerd-devel.noarch: W: self-obsoletion containerd-devel < 1.6.23-6 obsoletes containerd-devel = 1.6.23-1.fc41
golang-github-containerd.spec: W: no-%build-section
golang-github-containerd-devel.noarch: W: hidden-file-or-dir /usr/share/doc/golang-github-containerd-devel/docs/.editorconfig
golang-github-containerd-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/containerd/containerd/.goipath
golang-github-containerd-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/containerd/containerd/cmd/containerd/command/config_windows.go /usr/share/gocode/src/github.com/containerd/containerd/cmd/containerd/command/config_linux.go
golang-github-containerd-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/containerd/containerd/integration/util/util_unsupported.go /usr/share/gocode/src/github.com/containerd/containerd/integration/remote/util/util_unsupported.go
golang-github-containerd-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/containerd/containerd/runtime/v2/shim/shim_freebsd.go /usr/share/gocode/src/github.com/containerd/containerd/runtime/v2/shim/shim_darwin.go
 2 packages and 0 specfiles checked; 0 errors, 8 warnings, 7 filtered, 0 badness; has taken 0.8 s 




Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "golang-github-containerd-devel".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/containerd/containerd/archive/v1.6.23/containerd-1.6.23.tar.gz :
  CHECKSUM(SHA256) this package     : baca7a206e7b48e54c70b5aceafe0109d5b5a31dbc7602626afbbb705442c66f
  CHECKSUM(SHA256) upstream package : baca7a206e7b48e54c70b5aceafe0109d5b5a31dbc7602626afbbb705442c66f


Requires
--------
golang-github-containerd-devel (rpmlib, GLIBC filtered):
    go-filesystem
    golang(github.com/containerd/aufs/plugin)
    golang(github.com/containerd/btrfs)
    golang(github.com/containerd/cgroups)
    golang(github.com/containerd/cgroups/stats/v1)
    golang(github.com/containerd/cgroups/v2)
    golang(github.com/containerd/cgroups/v2/stats)
    golang(github.com/containerd/console)
    golang(github.com/containerd/continuity)
    golang(github.com/containerd/continuity/fs)
    golang(github.com/containerd/continuity/fs/fstest)
    golang(github.com/containerd/continuity/sysx)
    golang(github.com/containerd/fifo)
    golang(github.com/containerd/go-cni)
    golang(github.com/containerd/go-runc)
    golang(github.com/containerd/imgcrypt)
    golang(github.com/containerd/imgcrypt/images/encryption)
    golang(github.com/containerd/nri)
    golang(github.com/containerd/nri/types/v1)
    golang(github.com/containerd/ttrpc)
    golang(github.com/containerd/ttrpc/plugin)
    golang(github.com/containerd/typeurl)
    golang(github.com/containerd/zfs/plugin)
    golang(github.com/containernetworking/cni/pkg/invoke)
    golang(github.com/containernetworking/cni/pkg/skel)
    golang(github.com/containernetworking/cni/pkg/version)
    golang(github.com/containernetworking/plugins/pkg/ns)
    golang(github.com/coreos/go-systemd/v22/daemon)
    golang(github.com/davecgh/go-spew/spew)
    golang(github.com/docker/go-events)
    golang(github.com/docker/go-metrics)
    golang(github.com/docker/go-units)
    golang(github.com/emicklei/go-restful/v3)
    golang(github.com/fsnotify/fsnotify)
    golang(github.com/gogo/googleapis/google/rpc)
    golang(github.com/gogo/protobuf/gogoproto)
    golang(github.com/gogo/protobuf/proto)
    golang(github.com/gogo/protobuf/protoc-gen-gogo/descriptor)
    golang(github.com/gogo/protobuf/protoc-gen-gogo/generator)
    golang(github.com/gogo/protobuf/sortkeys)
    golang(github.com/gogo/protobuf/types)
    golang(github.com/gogo/protobuf/vanity)
    golang(github.com/gogo/protobuf/vanity/command)
    golang(github.com/google/uuid)
    golang(github.com/grpc-ecosystem/go-grpc-middleware)
    golang(github.com/grpc-ecosystem/go-grpc-prometheus)
    golang(github.com/hashicorp/go-multierror)
    golang(github.com/imdario/mergo)
    golang(github.com/intel/goresctrl/pkg/rdt)
    golang(github.com/klauspost/compress/zstd)
    golang(github.com/moby/locker)
    golang(github.com/moby/sys/mountinfo)
    golang(github.com/moby/sys/signal)
    golang(github.com/moby/sys/symlink)
    golang(github.com/opencontainers/go-digest)
    golang(github.com/opencontainers/go-digest/digestset)
    golang(github.com/opencontainers/image-spec/identity)
    golang(github.com/opencontainers/image-spec/specs-go)
    golang(github.com/opencontainers/image-spec/specs-go/v1)
    golang(github.com/opencontainers/runc/libcontainer/user)
    golang(github.com/opencontainers/runtime-spec/specs-go)
    golang(github.com/opencontainers/selinux/go-selinux)
    golang(github.com/opencontainers/selinux/go-selinux/label)
    golang(github.com/pelletier/go-toml)
    golang(github.com/prometheus/client_golang/prometheus)
    golang(github.com/sirupsen/logrus)
    golang(github.com/stretchr/testify/require)
    golang(github.com/tchap/go-patricia/patricia)
    golang(github.com/urfave/cli)
    golang(github.com/vishvananda/netlink)
    golang(go.etcd.io/bbolt)
    golang(go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc)
    golang(go.opentelemetry.io/otel)
    golang(go.opentelemetry.io/otel/attribute)
    golang(go.opentelemetry.io/otel/exporters/otlp/otlptrace)
    golang(go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc)
    golang(go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp)
    golang(go.opentelemetry.io/otel/propagation)
    golang(go.opentelemetry.io/otel/sdk/resource)
    golang(go.opentelemetry.io/otel/sdk/trace)
    golang(go.opentelemetry.io/otel/semconv/v1.4.0)
    golang(go.opentelemetry.io/otel/trace)
    golang(golang.org/x/net/context)
    golang(golang.org/x/net/context/ctxhttp)
    golang(golang.org/x/sync/errgroup)
    golang(golang.org/x/sync/semaphore)
    golang(golang.org/x/sys/execabs)
    golang(golang.org/x/sys/unix)
    golang(google.golang.org/grpc)
    golang(google.golang.org/grpc/backoff)
    golang(google.golang.org/grpc/codes)
    golang(google.golang.org/grpc/credentials)
    golang(google.golang.org/grpc/credentials/insecure)
    golang(google.golang.org/grpc/grpclog)
    golang(google.golang.org/grpc/health)
    golang(google.golang.org/grpc/health/grpc_health_v1)
    golang(google.golang.org/grpc/metadata)
    golang(google.golang.org/grpc/status)
    golang(gotest.tools/v3/assert)
    golang(gotest.tools/v3/assert/cmp)
    golang(k8s.io/api/core/v1)
    golang(k8s.io/apimachinery/pkg/api/errors)
    golang(k8s.io/apimachinery/pkg/api/resource)
    golang(k8s.io/apimachinery/pkg/apis/meta/v1)
    golang(k8s.io/apimachinery/pkg/types)
    golang(k8s.io/apimachinery/pkg/util/httpstream)
    golang(k8s.io/apimachinery/pkg/util/httpstream/spdy)
    golang(k8s.io/apimachinery/pkg/util/net)
    golang(k8s.io/apimachinery/pkg/util/remotecommand)
    golang(k8s.io/apimachinery/pkg/util/runtime)
    golang(k8s.io/apimachinery/pkg/util/sets)
    golang(k8s.io/apiserver/pkg/server/httplog)
    golang(k8s.io/apiserver/pkg/util/wsstream)
    golang(k8s.io/client-go/tools/remotecommand)
    golang(k8s.io/client-go/util/cert)
    golang(k8s.io/component-base/logs/logreduction)
    golang(k8s.io/cri-api/pkg/apis/runtime/v1)
    golang(k8s.io/cri-api/pkg/apis/runtime/v1alpha2)
    golang(k8s.io/klog/v2)
    golang(k8s.io/utils/clock)
    golang(k8s.io/utils/exec)



Provides
--------
golang-github-containerd-devel:
    containerd-devel
    deprecated()
    golang(github.com/containerd/containerd)
    golang(github.com/containerd/containerd/api)
    golang(github.com/containerd/containerd/api/events)
    golang(github.com/containerd/containerd/api/services/containers/v1)
    golang(github.com/containerd/containerd/api/services/content/v1)
    golang(github.com/containerd/containerd/api/services/diff/v1)
    golang(github.com/containerd/containerd/api/services/events/v1)
    golang(github.com/containerd/containerd/api/services/images/v1)
    golang(github.com/containerd/containerd/api/services/introspection/v1)
    golang(github.com/containerd/containerd/api/services/leases/v1)
    golang(github.com/containerd/containerd/api/services/namespaces/v1)
    golang(github.com/containerd/containerd/api/services/snapshots/v1)
    golang(github.com/containerd/containerd/api/services/tasks/v1)
    golang(github.com/containerd/containerd/api/services/ttrpc/events/v1)
    golang(github.com/containerd/containerd/api/services/version/v1)
    golang(github.com/containerd/containerd/api/types)
    golang(github.com/containerd/containerd/api/types/task)
    golang(github.com/containerd/containerd/archive)
    golang(github.com/containerd/containerd/archive/compression)
    golang(github.com/containerd/containerd/archive/tarheader)
    golang(github.com/containerd/containerd/archive/tartest)
    golang(github.com/containerd/containerd/cio)
    golang(github.com/containerd/containerd/cmd/containerd/command)
    golang(github.com/containerd/containerd/cmd/ctr/app)
    golang(github.com/containerd/containerd/cmd/ctr/commands)
    golang(github.com/containerd/containerd/cmd/ctr/commands/containers)
    golang(github.com/containerd/containerd/cmd/ctr/commands/content)
    golang(github.com/containerd/containerd/cmd/ctr/commands/events)
    golang(github.com/containerd/containerd/cmd/ctr/commands/images)
    golang(github.com/containerd/containerd/cmd/ctr/commands/install)
    golang(github.com/containerd/containerd/cmd/ctr/commands/leases)
    golang(github.com/containerd/containerd/cmd/ctr/commands/namespaces)
    golang(github.com/containerd/containerd/cmd/ctr/commands/oci)
    golang(github.com/containerd/containerd/cmd/ctr/commands/plugins)
    golang(github.com/containerd/containerd/cmd/ctr/commands/pprof)
    golang(github.com/containerd/containerd/cmd/ctr/commands/run)
    golang(github.com/containerd/containerd/cmd/ctr/commands/shim)
    golang(github.com/containerd/containerd/cmd/ctr/commands/snapshots)
    golang(github.com/containerd/containerd/cmd/ctr/commands/tasks)
    golang(github.com/containerd/containerd/cmd/ctr/commands/version)
    golang(github.com/containerd/containerd/containers)
    golang(github.com/containerd/containerd/content)
    golang(github.com/containerd/containerd/content/local)
    golang(github.com/containerd/containerd/content/proxy)
    golang(github.com/containerd/containerd/content/testsuite)
    golang(github.com/containerd/containerd/contrib/apparmor)
    golang(github.com/containerd/containerd/contrib/nvidia)
    golang(github.com/containerd/containerd/contrib/seccomp)
    golang(github.com/containerd/containerd/contrib/seccomp/kernelversion)
    golang(github.com/containerd/containerd/contrib/snapshotservice)
    golang(github.com/containerd/containerd/defaults)
    golang(github.com/containerd/containerd/diff)
    golang(github.com/containerd/containerd/diff/apply)
    golang(github.com/containerd/containerd/diff/walking)
    golang(github.com/containerd/containerd/diff/walking/plugin)
    golang(github.com/containerd/containerd/errdefs)
    golang(github.com/containerd/containerd/events)
    golang(github.com/containerd/containerd/events/exchange)
    golang(github.com/containerd/containerd/events/plugin)
    golang(github.com/containerd/containerd/filters)
    golang(github.com/containerd/containerd/gc)
    golang(github.com/containerd/containerd/gc/scheduler)
    golang(github.com/containerd/containerd/identifiers)
    golang(github.com/containerd/containerd/images)
    golang(github.com/containerd/containerd/images/archive)
    golang(github.com/containerd/containerd/images/converter)
    golang(github.com/containerd/containerd/images/converter/uncompress)
    golang(github.com/containerd/containerd/integration)
    golang(github.com/containerd/containerd/integration/cri-api/pkg/apis)
    golang(github.com/containerd/containerd/integration/remote)
    golang(github.com/containerd/containerd/integration/remote/util)
    golang(github.com/containerd/containerd/integration/util)
    golang(github.com/containerd/containerd/labels)
    golang(github.com/containerd/containerd/leases)
    golang(github.com/containerd/containerd/leases/proxy)
    golang(github.com/containerd/containerd/log)
    golang(github.com/containerd/containerd/log/logtest)
    golang(github.com/containerd/containerd/metadata)
    golang(github.com/containerd/containerd/metadata/boltutil)
    golang(github.com/containerd/containerd/metrics)
    golang(github.com/containerd/containerd/metrics/cgroups)
    golang(github.com/containerd/containerd/metrics/cgroups/common)
    golang(github.com/containerd/containerd/metrics/cgroups/v1)
    golang(github.com/containerd/containerd/metrics/cgroups/v2)
    golang(github.com/containerd/containerd/metrics/types/v1)
    golang(github.com/containerd/containerd/metrics/types/v2)
    golang(github.com/containerd/containerd/mount)
    golang(github.com/containerd/containerd/namespaces)
    golang(github.com/containerd/containerd/oci)
    golang(github.com/containerd/containerd/pkg/apparmor)
    golang(github.com/containerd/containerd/pkg/atomic)
    golang(github.com/containerd/containerd/pkg/atomicfile)
    golang(github.com/containerd/containerd/pkg/cap)
    golang(github.com/containerd/containerd/pkg/cri)
    golang(github.com/containerd/containerd/pkg/cri/annotations)
    golang(github.com/containerd/containerd/pkg/cri/config)
    golang(github.com/containerd/containerd/pkg/cri/constants)
    golang(github.com/containerd/containerd/pkg/cri/io)
    golang(github.com/containerd/containerd/pkg/cri/labels)
    golang(github.com/containerd/containerd/pkg/cri/opts)
    golang(github.com/containerd/containerd/pkg/cri/server)
    golang(github.com/containerd/containerd/pkg/cri/server/bandwidth)
    golang(github.com/containerd/containerd/pkg/cri/server/testing)
    golang(github.com/containerd/containerd/pkg/cri/store)
    golang(github.com/containerd/containerd/pkg/cri/store/container)
    golang(github.com/containerd/containerd/pkg/cri/store/image)
    golang(github.com/containerd/containerd/pkg/cri/store/label)
    golang(github.com/containerd/containerd/pkg/cri/store/sandbox)
    golang(github.com/containerd/containerd/pkg/cri/store/snapshot)
    golang(github.com/containerd/containerd/pkg/cri/store/stats)
    golang(github.com/containerd/containerd/pkg/cri/store/truncindex)
    golang(github.com/containerd/containerd/pkg/cri/streaming)
    golang(github.com/containerd/containerd/pkg/cri/streaming/portforward)
    golang(github.com/containerd/containerd/pkg/cri/streaming/remotecommand)
    golang(github.com/containerd/containerd/pkg/cri/util)
    golang(github.com/containerd/containerd/pkg/dialer)
    golang(github.com/containerd/containerd/pkg/failpoint)
    golang(github.com/containerd/containerd/pkg/ioutil)
    golang(github.com/containerd/containerd/pkg/kmutex)
    golang(github.com/containerd/containerd/pkg/netns)
    golang(github.com/containerd/containerd/pkg/oom)
    golang(github.com/containerd/containerd/pkg/oom/v1)
    golang(github.com/containerd/containerd/pkg/oom/v2)
    golang(github.com/containerd/containerd/pkg/os)
    golang(github.com/containerd/containerd/pkg/os/testing)
    golang(github.com/containerd/containerd/pkg/process)
    golang(github.com/containerd/containerd/pkg/progress)
    golang(github.com/containerd/containerd/pkg/registrar)
    golang(github.com/containerd/containerd/pkg/runtimeoptions/v1)
    golang(github.com/containerd/containerd/pkg/schedcore)
    golang(github.com/containerd/containerd/pkg/seccomp)
    golang(github.com/containerd/containerd/pkg/seed)
    golang(github.com/containerd/containerd/pkg/seutil)
    golang(github.com/containerd/containerd/pkg/shutdown)
    golang(github.com/containerd/containerd/pkg/snapshotters)
    golang(github.com/containerd/containerd/pkg/stdio)
    golang(github.com/containerd/containerd/pkg/testutil)
    golang(github.com/containerd/containerd/pkg/timeout)
    golang(github.com/containerd/containerd/pkg/ttrpcutil)
    golang(github.com/containerd/containerd/pkg/userns)
    golang(github.com/containerd/containerd/platforms)
    golang(github.com/containerd/containerd/plugin)
    golang(github.com/containerd/containerd/protobuf)
    golang(github.com/containerd/containerd/protobuf/plugin)
    golang(github.com/containerd/containerd/protobuf/plugin/fieldpath)
    golang(github.com/containerd/containerd/reference)
    golang(github.com/containerd/containerd/reference/docker)
    golang(github.com/containerd/containerd/remotes)
    golang(github.com/containerd/containerd/remotes/docker)
    golang(github.com/containerd/containerd/remotes/docker/auth)
    golang(github.com/containerd/containerd/remotes/docker/config)
    golang(github.com/containerd/containerd/remotes/docker/schema1)
    golang(github.com/containerd/containerd/remotes/errors)
    golang(github.com/containerd/containerd/rootfs)
    golang(github.com/containerd/containerd/runtime)
    golang(github.com/containerd/containerd/runtime/linux/runctypes)
    golang(github.com/containerd/containerd/runtime/opts)
    golang(github.com/containerd/containerd/runtime/restart)
    golang(github.com/containerd/containerd/runtime/restart/monitor)
    golang(github.com/containerd/containerd/runtime/v1)
    golang(github.com/containerd/containerd/runtime/v1/linux)
    golang(github.com/containerd/containerd/runtime/v1/shim)
    golang(github.com/containerd/containerd/runtime/v1/shim/client)
    golang(github.com/containerd/containerd/runtime/v1/shim/v1)
    golang(github.com/containerd/containerd/runtime/v2)
    golang(github.com/containerd/containerd/runtime/v2/logging)
    golang(github.com/containerd/containerd/runtime/v2/runc)
    golang(github.com/containerd/containerd/runtime/v2/runc/manager)
    golang(github.com/containerd/containerd/runtime/v2/runc/options)
    golang(github.com/containerd/containerd/runtime/v2/runc/task)
    golang(github.com/containerd/containerd/runtime/v2/runc/task/plugin)
    golang(github.com/containerd/containerd/runtime/v2/runc/v1)
    golang(github.com/containerd/containerd/runtime/v2/runc/v2)
    golang(github.com/containerd/containerd/runtime/v2/shim)
    golang(github.com/containerd/containerd/runtime/v2/task)
    golang(github.com/containerd/containerd/services)
    golang(github.com/containerd/containerd/services/containers)
    golang(github.com/containerd/containerd/services/content)
    golang(github.com/containerd/containerd/services/content/contentserver)
    golang(github.com/containerd/containerd/services/diff)
    golang(github.com/containerd/containerd/services/events)
    golang(github.com/containerd/containerd/services/healthcheck)
    golang(github.com/containerd/containerd/services/images)
    golang(github.com/containerd/containerd/services/introspection)
    golang(github.com/containerd/containerd/services/leases)
    golang(github.com/containerd/containerd/services/namespaces)
    golang(github.com/containerd/containerd/services/opt)
    golang(github.com/containerd/containerd/services/server)
    golang(github.com/containerd/containerd/services/server/config)
    golang(github.com/containerd/containerd/services/snapshots)
    golang(github.com/containerd/containerd/services/tasks)
    golang(github.com/containerd/containerd/services/version)
    golang(github.com/containerd/containerd/snapshots)
    golang(github.com/containerd/containerd/snapshots/benchsuite)
    golang(github.com/containerd/containerd/snapshots/btrfs)
    golang(github.com/containerd/containerd/snapshots/btrfs/plugin)
    golang(github.com/containerd/containerd/snapshots/devmapper)
    golang(github.com/containerd/containerd/snapshots/devmapper/blkdiscard)
    golang(github.com/containerd/containerd/snapshots/devmapper/dmsetup)
    golang(github.com/containerd/containerd/snapshots/devmapper/plugin)
    golang(github.com/containerd/containerd/snapshots/native)
    golang(github.com/containerd/containerd/snapshots/native/plugin)
    golang(github.com/containerd/containerd/snapshots/overlay)
    golang(github.com/containerd/containerd/snapshots/overlay/overlayutils)
    golang(github.com/containerd/containerd/snapshots/overlay/plugin)
    golang(github.com/containerd/containerd/snapshots/proxy)
    golang(github.com/containerd/containerd/snapshots/storage)
    golang(github.com/containerd/containerd/snapshots/testsuite)
    golang(github.com/containerd/containerd/sys)
    golang(github.com/containerd/containerd/sys/reaper)
    golang(github.com/containerd/containerd/tracing)
    golang(github.com/containerd/containerd/tracing/plugin)
    golang(github.com/containerd/containerd/version)
    golang-github-containerd-devel
    golang-ipath(github.com/containerd/containerd)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name golang-github-containerd --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: Perl, PHP, SugarActivity, fonts, R, Python, Haskell, Java, Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH



concerd about: 

- golang-github-containerd.spec:24: W: unversioned-explicit-provides deprecated()
please add a version 

- golang-github-containerd-devel.noarch: W: self-obsoletion containerd-devel < 1.6.23-6 obsoletes containerd-devel = 1.6.23-1.fc41
why obsolete a package with same name ?

Comment 3 Maxwell G 2024-04-12 21:10:17 UTC
> - golang-github-containerd.spec:24: W: unversioned-explicit-provides deprecated()

`Provides: deprecated()` has a special meaning. It should not have a version.

> why obsolete a package with same name ?

This is the classic Obsoletes + Provides combination to rename a package. rpmlint is wrong here.

Comment 4 Sergio Basto 2024-04-12 21:43:15 UTC
OK

Package APPROVED

Comment 5 Fedora Admin user for bugzilla script actions 2024-04-12 21:44:25 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-containerd

Comment 6 Maxwell G 2024-04-12 21:44:59 UTC
Thanks!


Note You need to log in before you can comment on or make changes to this bug.