Bug 2274656 - Review Request: docker-buildx - Docker CLI plugin for extended build capabilities with BuildKit
Summary: Review Request: docker-buildx - Docker CLI plugin for extended build capabili...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2274561 2274832
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-04-12 01:21 UTC by Maxwell G
Modified: 2024-08-22 23:31 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-08-22 23:31:44 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Maxwell G 2024-04-12 01:21:30 UTC
Spec URL: https://gotmax23.fedorapeople.org/reviews/docker-buildx/docker-buildx.spec
SRPM URL: https://gotmax23.fedorapeople.org/reviews/docker-buildx/docker-buildx-0.13.1-1.fc39.src.rpm

Description:
Docker CLI plugin for extended build capabilities with BuildKit.

Comment 5 Maxwell G 2024-08-04 19:08:12 UTC
Oops

Comment 6 Mikel Olasagasti Uranga 2024-08-05 08:38:35 UTC
Before importing skip the following files:

/usr/share/licenses/docker-buildx/vendor/go.opentelemetry.io/otel/get_main_pkgs.sh
/usr/share/licenses/docker-buildx/vendor/go.opentelemetry.io/otel/verify_examples.sh
/usr/share/licenses/docker-buildx/vendor/google.golang.org/grpc/regenerate.sh

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 7 Sergio Basto 2024-08-05 16:11:49 UTC
ah , I'd add buildkit vendored and use golang-github-moby-buildkit as devel package

Comment 8 Fedora Admin user for bugzilla script actions 2024-08-22 22:40:57 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/docker-buildx

Comment 9 Fedora Update System 2024-08-22 23:29:46 UTC
FEDORA-2024-2ea0a88e22 (docker-buildx-0.16.2-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2ea0a88e22

Comment 10 Fedora Update System 2024-08-22 23:31:44 UTC
FEDORA-2024-2ea0a88e22 (docker-buildx-0.16.2-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.