Bug 2274742 - Review Request: golang-github-mfridman-interpolate - Substitute variables in strings from environment variables
Summary: Review Request: golang-github-mfridman-interpolate - Substitute variables in ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-04-12 15:51 UTC by Kai A. Hiller
Modified: 2024-05-01 17:17 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-05-01 17:17:10 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Kai A. Hiller 2024-04-12 15:51:59 UTC
Spec URL: https://v02460.fedorapeople.org/golang-github-mfridman-interpolate.spec
SRPM URL: https://v02460.fedorapeople.org/golang-github-mfridman-interpolate-0.0.2-1.fc41.src.rpm
Description: A Go library that helps substitute variables in strings from environment variables.
Fedora Account System Username: v02460

Comment 1 Mikel Olasagasti Uranga 2024-04-13 11:33:03 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 2 Fedora Admin user for bugzilla script actions 2024-04-19 17:22:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-mfridman-interpolate


Note You need to log in before you can comment on or make changes to this bug.