Spec URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers.spec SRPM URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc39/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc39.src.rpm Description: Vulkan layers to support additional APIs via Monado. Fedora Account System Username: jsteffan
[fedora-review-service-build] trigger.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Creative Commons CC0 1.0", "Boost Software License 1.0", "*No copyright* Boost Software License 1.0", "Unknown or generated", "MIT License", "*No copyright* Creative Commons CC0 1.0". 5 files have unknown license. Detailed output of licensecheck in /tmp/2274947-monado-vulkan-layers/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/vulkan, /usr/lib64/monado-vulkan- layers, /usr/share/vulkan/implicit_layer.d [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/monado-vulkan- layers, /usr/share/vulkan, /usr/share/vulkan/implicit_layer.d [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc41.x86_64.rpm monado-vulkan-layers-debuginfo-0.9.0-1.20240221gitae43cdc.fc41.x86_64.rpm monado-vulkan-layers-debugsource-0.9.0-1.20240221gitae43cdc.fc41.x86_64.rpm monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppzp0ngu0')] checks: 32, packages: 4 monado-vulkan-layers.spec: W: patch-not-applied Patch0: %{forgeurl}/-/merge_requests/16.patch monado-vulkan-layers.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 16 filtered, 0 badness; has taken 0.4 s Rpmlint (debuginfo) ------------------- Checking: monado-vulkan-layers-debuginfo-0.9.0-1.20240221gitae43cdc.fc41.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppiou3dn_')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 monado-vulkan-layers.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 13 filtered, 0 badness; has taken 0.3 s Unversioned so-files -------------------- monado-vulkan-layers: /usr/lib64/monado-vulkan-layers/libVkLayer_MND_enable_timeline_semaphore.so Source checksums ---------------- https://gitlab.freedesktop.org/monado/utilities/vulkan-layers/-/archive/ae43cdcbd25c56e3481bbc8a0ce2bfcebba9f7c2/vulkan-layers-ae43cdcbd25c56e3481bbc8a0ce2bfcebba9f7c2.tar.bz2 : CHECKSUM(SHA256) this package : 4c7a32cc0cda25e6386adfc7d665a544318359ef8f8df701d678a2c1a1946fa5 CHECKSUM(SHA256) upstream package : 4c7a32cc0cda25e6386adfc7d665a544318359ef8f8df701d678a2c1a1946fa5 Requires -------- monado-vulkan-layers (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) monado-vulkan-layers-debuginfo (rpmlib, GLIBC filtered): monado-vulkan-layers-debugsource (rpmlib, GLIBC filtered): Provides -------- monado-vulkan-layers: libVkLayer_MND_enable_timeline_semaphore.so()(64bit) monado-vulkan-layers monado-vulkan-layers(x86-64) monado-vulkan-layers-debuginfo: debuginfo(build-id) libVkLayer_MND_enable_timeline_semaphore.so-0.9.0-1.20240221gitae43cdc.fc41.x86_64.debug()(64bit) monado-vulkan-layers-debuginfo monado-vulkan-layers-debuginfo(x86-64) monado-vulkan-layers-debugsource: monado-vulkan-layers-debugsource monado-vulkan-layers-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2274947 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: R, Java, Perl, PHP, Python, SugarActivity, Haskell, Ocaml, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
[!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Just add a comment before the License tag for this [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/vulkan, /usr/lib64/monado-vulkan- layers, /usr/share/vulkan/implicit_layer.d [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/monado-vulkan- layers, /usr/share/vulkan, /usr/share/vulkan/implicit_layer.d You probably want Requires: vulkan-loader for /usr/share/vulkan. For the other one, I'd just use %{_libdir}/%{name}/ and have it own the whole folder itself.
Spec URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers.spec SRPM URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc39/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc39.src.rpm This needs a bit more coordination with upstream. My MR likely wont be merged based on documentation on https://gitlab.freedesktop.org/monado/monado/-/blob/main/doc/packaging-notes.md. I added the following to try to illustrate we intend on using the new functionality and are fine with the limitation: # https://gitlab.freedesktop.org/monado/monado/-/blob/main/doc/packaging-notes.md # Updated multi-arch support in OpenXR: Requires: openxr >= 1.0.29 Added a comment about the dual license. (Not sure if I interpreted this request correctly.) Added a Requires on vulkan-loader, good catch.
> Added a comment about the dual license. (Not sure if I interpreted this request correctly.) What I meant was to add a comment and explain what is covered by one license and what is by the other.
Spec URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers.spec SRPM URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc39/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc39.src.rpm
APPROVED, thank you!
Based on the likely outcome of https://pagure.io/packaging-committee/issue/1365, I've moved the library to /usr/lib[64] without a subdirectory. Spec URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers.spec SRPM URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc39/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc39.src.rpm
I've updated this package based on the latest review of the proposed policy. Spec URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers.spec SRPM URL: https://jsteffan.fedorapeople.org/imrsv/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc39/monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc40.src.rpm [fedora-review-service-build]
The Pagure repository was created at https://src.fedoraproject.org/rpms/monado-vulkan-layers
FEDORA-2024-a34fc4f516 (monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a34fc4f516
FEDORA-2024-a34fc4f516 (monado-vulkan-layers-0.9.0-1.20240221gitae43cdc.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.