Bug 2275318 - Review Request: golang-github-gosimple-unidecode - Unicode transliterator in Golang
Summary: Review Request: golang-github-gosimple-unidecode - Unicode transliterator in ...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Renich Bon Ciric
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2275319
TreeView+ depends on / blocked
 
Reported: 2024-04-16 16:13 UTC by Mikel Olasagasti Uranga
Modified: 2024-05-04 01:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
renich: fedora-review?


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2024-04-16 16:13:07 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-gosimple-unidecode.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-gosimple-unidecode-1.0.1-1.fc40.src.rpm
Description: ASCII approximations.
Fedora Account System Username: mikelo2

Comment 1 Renich Bon Ciric 2024-05-04 01:41:23 UTC
Here're a few coments:

This package blocks 2275317 as well since it is a dependency of it. 

It seems that table.txt is not documentation but a file needed to rebuild table.go. It should not be marked as documentation IMHO, what do you think?

> ## Add new characters
>
> 1. Edit `table.txt` file.
> 2. Rebuild `table.go` file:
> 
>    ```go
>    go run ./make_table.go
>    ```

The license of the package seems to be the Apache License. IIUC, the appache indicates that a header be applied to every file as a comment:

   APPENDIX: How to apply the Apache License to your work.

      To apply the Apache License to your work, attach the following
      boilerplate notice, with the fields enclosed by brackets "{}"
      replaced with your own identifying information. (Don't include
      the brackets!)  The text should be enclosed in the appropriate
      comment syntax for the file format. We also recommend that a
      file or class name and description of purpose be included on the
      same "printed page" as the copyright notice for easier
      identification within third-party archives.

   Copyright {yyyy} {name of copyright owner}

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
   You may obtain a copy of the License at

... but none of the files do so. I don't know if this is OK but one should try and contact upstream and let them know about this, if you ask me. What do you think?

A hidden file has been included: /usr/share/gocode/src/github.com/gosimple/unidecode/.goipath


Note You need to log in before you can comment on or make changes to this bug.