Bug 2275385 - cockpit-kdump should depend on kdump-utils
Summary: cockpit-kdump should depend on kdump-utils
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cockpit
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Martin Pitt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2275390
TreeView+ depends on / blocked
 
Reported: 2024-04-17 02:54 UTC by Coiby
Modified: 2024-04-28 03:17 UTC (History)
5 users (show)

Fixed In Version: cockpit-316-1.fc40
Clone Of:
Environment:
Last Closed: 2024-04-28 03:17:12 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github cockpit-project cockpit pull 20337 0 None open tools: Depend on kdumpctl binary 2024-04-19 05:12:40 UTC

Description Coiby 2024-04-17 02:54:21 UTC
With kdump-utils-1.0.42-8.fc41/kexec-tools-2.0.28-8.fc41 released, cockpit-kdump should "Requires: kdump-utils"

Reproducible: Always

Comment 1 Martin Pitt 2024-04-17 06:04:50 UTC
Sure! We like to keep the spec working on all Fedoras and RHELs, without hardcoding a lot of RHEL/CentOS/Fedora versions (that's notoriously prone to errors). Do you intend that kexec-tools will always Requires: kdump-utils, or will that go away at some point? In the former case, we could do

  Requires: (kdump-utils or kexec-tools)

otherwise we need something more refined, like

  Requires: (kdump-utils or kexec-tools <= 2.0.28-8)

Any recommendations? Thanks!

Comment 2 Coiby 2024-04-19 01:22:55 UTC
One of the reasons we split out kdump-utils is there is a growing user base to only use the kexec reboot feature. So kexec-tools doesn't depend on kdump-utils (currently kexec-tools recommends kdump-utils because we expect more users install kexec-tools for kdump) but kdump-utils will always depend on kexec-tools.

How about "Requires: /usr/bin/kdumpctl"?

Comment 3 Martin Pitt 2024-04-19 05:12:40 UTC
Thanks Coiby. That indeed seems to be the most robust way now. I just asked as I faintly remember that depending on paths was a bit smelly, but it does work fine.

https://github.com/cockpit-project/cockpit/pull/20337

Comment 4 Fedora Update System 2024-04-25 14:20:05 UTC
FEDORA-2024-bc42ae090a (cockpit-316-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-bc42ae090a

Comment 5 Fedora Update System 2024-04-26 01:48:12 UTC
FEDORA-2024-bc42ae090a has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-bc42ae090a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-bc42ae090a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-04-28 03:17:12 UTC
FEDORA-2024-bc42ae090a (cockpit-316-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.