Bug 227579 - Review Request: spr - Statistical pattern recognition
Review Request: spr - Statistical pattern recognition
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Mamoru TASAKA
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2007-02-06 17:20 EST by Wart
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-25 10:32:26 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mtasaka: fedora‑review+
jwboyer: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Wart 2007-02-06 17:20:20 EST
Spec URL: http://www.kobold.org/~wart/fedora/spr.spec
SRPM URL: http://www.kobold.org/~wart/fedora/spr-05.00.01-1.src.rpm
Description: 

The package implements a variety of tools for categorization of multivariate
data such as boosted decision trees, bagging and random forest, bump hunting
(PRIM), a multi-class learner and others.
Comment 1 Wart 2007-02-06 17:59:17 EST
rpmlint warns:

W: spr-devel no-documentation

The only documentation that might be part of the -devel subpackage is a few
lines from the README file that's already included in the main package.  I'm
inclined to ignore this warning.
Comment 2 Mamoru TASAKA 2007-04-20 04:04:24 EDT
First, please update to the newest version.
I will check it after that.
Comment 4 Mamoru TASAKA 2007-04-22 03:24:04 EDT
For 05.01.00-1:

* rpmlint - attached
  Summary:
  - libSPR.so.0.0.0 contains undefined non-weak symbols.
    This is a BLOCKER for the rpm providing -devel subpackage
    because linkage against this library fais due to these
    symbols.

* Timestamps
  - This package installs many text files (such as header files)
    which are not modified during build stage and keeping timestamps
    on these files are highly recommended.
    For this package, the following works.
-----------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -c -p"
-----------------------------------------------------

* header files location
  - Generally, if a package installs "many" header files, their
    header files should be hidden in the package specific directory
    to aboid namespace conflict.
    Would you consider to move all header files to under
    %{_includedir}/%{name}/ ?
Comment 5 Wart 2007-04-22 19:13:54 EDT
(In reply to comment #4)
> For 05.01.00-1:
> 
> * rpmlint - attached
>   Summary:
>   - libSPR.so.0.0.0 contains undefined non-weak symbols.

Good catch.  I always forget to run rpmlint on the installed packages.

> * Timestamps

Fixed.

> * header files location
>   - Generally, if a package installs "many" header files, their
>     header files should be hidden in the package specific directory
>     to aboid namespace conflict.
>     Would you consider to move all header files to under
>     %{_includedir}/%{name}/ ?

Good idea.  I'll also suggest that upstream use this as a default.

New packages:

http://www.kobold.org/~wart/fedora/spr.spec
http://www.kobold.org/~wart/fedora/spr-05.01.00-2.src.rpm
Comment 6 Mamoru TASAKA 2007-04-22 21:21:55 EDT
One issue

* Directory ownership
  - The directory %{_includedir}/%{name}/ is not owned by
    any package, which should be owned by -devel package.

Other things are all okay
-------------------------------------------------
  This package (spr) is APPROVED by me
-------------------------------------------------
Comment 7 Wart 2007-04-23 16:27:20 EDT
Many thanks for the review!  I'll fix the directory ownership in the -devel
subpackage after importing the new package, but before the first build.

New Package CVS Request
=======================
Package Name: spr
Short Description: Statistical pattern recognition 
Owners: wart@kobold.org
Branches: FC-6 EL-4 EL-5
InitialCC: 
Comment 8 Wart 2007-04-25 10:32:26 EDT
Imported and built.  Thanks!

Note You need to log in before you can comment on or make changes to this bug.