Bug 2275966 - Review Request: rust-nanoid - Tiny, secure, URL-friendly, unique string ID generator for Rust
Summary: Review Request: rust-nanoid - Tiny, secure, URL-friendly, unique string ID ge...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-04-18 18:47 UTC by Ben Beasley
Modified: 2024-05-22 01:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-04-19 16:15:30 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2024-04-18 18:47:38 UTC
Spec URL: https://music.fedorapeople.org/rust-nanoid.spec
SRPM URL: https://music.fedorapeople.org/rust-nanoid-0.4.0-1.fc39.src.rpm

Description:

A tiny, secure, URL-friendly, unique string ID generator for Rust.

Fedora Account System Username: music

This is a direct dependency for https://github.com/astral-sh/uv.

The spec file is obtained directly from rust2rpm.

Comment 1 Fabio Valentini 2024-04-19 13:09:59 UTC
Package looks good to me.

You might want to patch out the "cargo-husky" dev-dependency.
It is unused, since the tests that use this dependency are not shipped with published crates.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 2 Ben Beasley 2024-04-19 14:46:56 UTC
(In reply to Fabio Valentini from comment #1)
> Package looks good to me.
> 
> You might want to patch out the "cargo-husky" dev-dependency.
> It is unused, since the tests that use this dependency are not shipped with
> published crates.

Thanks for the review, and good catch. I will patch it out.

Comment 3 Ben Beasley 2024-04-19 14:48:28 UTC
https://release-monitoring.org/project/372105/

Comment 4 Ben Beasley 2024-04-19 15:09:39 UTC
Iā€™m currently having trouble requesting a repo for this due to what appear to be FAS issues.

https://pagure.io/fedora-infrastructure/issue/11887#comment-906003

Comment 5 Fedora Admin user for bugzilla script actions 2024-04-19 15:53:08 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nanoid

Comment 6 Fedora Update System 2024-04-19 16:09:28 UTC
FEDORA-2024-14cd10ef31 (rust-nanoid-0.4.0-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-14cd10ef31

Comment 7 Fedora Update System 2024-04-19 16:15:30 UTC
FEDORA-2024-14cd10ef31 (rust-nanoid-0.4.0-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-05-16 18:15:15 UTC
FEDORA-2024-c2abca435e (rust-bisection-0.1.0-2.fc40, rust-http-content-range-0.1.2-1.fc40, and 4 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e

Comment 9 Fedora Update System 2024-05-16 18:15:19 UTC
FEDORA-2024-0bfd6dabc2 (rust-bisection-0.1.0-2.fc39, rust-http-content-range-0.1.2-1.fc39, and 4 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2

Comment 10 Fedora Update System 2024-05-17 01:36:38 UTC
FEDORA-2024-0bfd6dabc2 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0bfd6dabc2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-05-17 02:09:44 UTC
FEDORA-2024-c2abca435e has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c2abca435e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-05-22 01:11:27 UTC
FEDORA-2024-c2abca435e has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c2abca435e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-05-22 01:48:31 UTC
FEDORA-2024-0bfd6dabc2 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0bfd6dabc2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.


Note You need to log in before you can comment on or make changes to this bug.