Bug 2276079 - Review Request: rust-reflink-copy - Copy-on-write mechanism on supported file systems
Summary: Review Request: rust-reflink-copy - Copy-on-write mechanism on supported file...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-04-19 16:14 UTC by Ben Beasley
Modified: 2024-05-22 01:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-04-21 11:31:19 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2024-04-19 16:14:02 UTC
Spec URL: https://music.fedorapeople.org/rust-reflink-copy.spec
SRPM URL: https://music.fedorapeople.org/rust-reflink-copy-0.1.16-1.fc39.src.rpm

Description:

Copy-on-write mechanism on supported file systems.

Fedora Account System Username: music

This is a direct dependency for https://github.com/astral-sh/uv.

The spec file is obtained directly from rust2rpm with rust2rpm.toml as follows:

[[package.extra-patches]]
number = 10
file = "https://github.com/cargo-bins/reflink-copy/pull/69.patch"
comments = [
    "Remove the test reflink_src_is_symlink",
    "https://github.com/cargo-bins/reflink-copy/pull/69",
    "  Fixes:",
    "On btrfs in Fedora 39, reflink_src_is_symlink fails",
    "https://github.com/cargo-bins/reflink-copy/issues/68",
]

Comment 1 Fabio Valentini 2024-04-20 12:04:53 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

If you have a bit of time, it would be great if you could take a look at one of my pending packages in return.

Comment 2 Fedora Admin user for bugzilla script actions 2024-04-20 12:57:52 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-reflink-copy

Comment 3 Ben Beasley 2024-04-20 12:59:04 UTC
Thank you for the review!

https://release-monitoring.org/project/372110/

Comment 4 Ben Beasley 2024-04-21 11:31:19 UTC
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0230ceab53

(Bodhi isn’t properly closing bugs right now.)

Comment 5 Fedora Update System 2024-05-16 18:15:18 UTC
FEDORA-2024-c2abca435e (rust-bisection-0.1.0-2.fc40, rust-http-content-range-0.1.2-1.fc40, and 4 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e

Comment 6 Fedora Update System 2024-05-16 18:15:22 UTC
FEDORA-2024-0bfd6dabc2 (rust-bisection-0.1.0-2.fc39, rust-http-content-range-0.1.2-1.fc39, and 4 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2

Comment 7 Fedora Update System 2024-05-17 01:36:40 UTC
FEDORA-2024-0bfd6dabc2 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0bfd6dabc2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-05-17 02:09:47 UTC
FEDORA-2024-c2abca435e has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c2abca435e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-05-22 01:11:30 UTC
FEDORA-2024-c2abca435e has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c2abca435e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-05-22 01:48:34 UTC
FEDORA-2024-0bfd6dabc2 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0bfd6dabc2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.


Note You need to log in before you can comment on or make changes to this bug.