Spec URL: https://raw.githubusercontent.com/wojnilowicz/rust-jemalloc-sys/main/rust-jemalloc-sys.spec SRPM URL: https://github.com/wojnilowicz/rust-jemalloc-sys/releases/download/0.5.4/rust-jemalloc-sys-0.5.4-1.fc39.src.rpm Description: Rust FFI bindings to jemalloc Fedora Account System Username: wojnilowicz I plan on packaging https://github.com/ActivityWatch/aw-server-rust and jemalloc is its requirement. I've requested a sponsor at https://pagure.io/packager-sponsors/issue/640
Do you *really* need to use the jemalloc allocator? We have previously managed to avoid packaging the Rust bindings for jemalloc ... jemalloc only really supports x86_64 and aarch64, so the package you're working on would be either very limited, or would need to selectively disable jemalloc on other architectures.
I try to package this aw-server-rust and it has this as a dependency for Linux and x86 as seen at https://github.com/ActivityWatch/aw-server-rust/blob/c056e50646b45070c330de8a6dbd14042b3455e4/aw-server/Cargo.toml#L40 Couldn't we just remove the noarch line and limit valid architectures with ExclusiveArch similarly to https://pkgs.rpmfusion.org/cgit/nonfree/nvidia-340xx-kmod.git/tree/nvidia-340xx-kmod.spec#n34 ?
(In reply to wojnilowicz from comment #2) > I try to package this aw-server-rust and it has this as a dependency for > Linux and x86 as seen at > https://github.com/ActivityWatch/aw-server-rust/blob/ > c056e50646b45070c330de8a6dbd14042b3455e4/aw-server/Cargo.toml#L40 Yes, but custom allocators are, by definition, optional. We already have a handful of packages in Fedora that drop custom allocators because they are painful to deal with. > Couldn't we just remove the noarch line and limit valid architectures with > ExclusiveArch similarly to > https://pkgs.rpmfusion.org/cgit/nonfree/nvidia-340xx-kmod.git/tree/nvidia- > 340xx-kmod.spec#n34 > ? No, that would be wrong. The correct solution would be to use the "supported-arches" setting in rust2rpm.toml to specify that the crate should only be built and tested on certain architectures.
(In reply to Fabio Valentini from comment #3) > Yes, but custom allocators are, by definition, optional. > We already have a handful of packages in Fedora that drop custom allocators > because they are painful to deal with. If I can workaround I would. I'll try to investigate further. In the meantime, could you link a package that deals (drops?) with custom allocators? > > Couldn't we just remove the noarch line and limit valid architectures with > > ExclusiveArch similarly to > > https://pkgs.rpmfusion.org/cgit/nonfree/nvidia-340xx-kmod.git/tree/nvidia- > > 340xx-kmod.spec#n34 > > ? > > No, that would be wrong. > > The correct solution would be to use the "supported-arches" setting in > rust2rpm.toml to specify that the crate should only be built and tested on > certain architectures. Ok. I've updated the spec file to use supported-arches from rust2rpm.toml.
Removing a custom allocator is usually very simple - just remove the dependency and the ALLOC static. Here's an example of what the latter looks like: https://src.fedoraproject.org/rpms/rust-fd-find/blob/rawhide/f/0001-remove-references-to-jemalloc.patch
Indeed, it was super easy. I don't need this package anymore. Thanks for helping me.