Spec URL: https://pagure.io/perl-TOML-Tiny/raw/main/f/perl-TOML-Tiny.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perlimports/fedora-rawhide-x86_64/07334171-perl-TOML-Tiny/perl-TOML-Tiny-0.16-1.fc41.src.rpm Description: A minimal, pure perl TOML parser and serializer Fedora Account System Username: mavit
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perlimports/fedora-rawhide-x86_64/07396228-perl-TOML-Tiny/perl-TOML-Tiny-0.16-1.fc41.src.rpm
The source package is not available. Please, update it to the latest version 0.18.
Do you want to add the package to EPEL 7?
SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perlimports/fedora-rawhide-x86_64/08025312-perl-TOML-Tiny/perl-TOML-Tiny-0.18-1.fc42.src.rpm (In reply to Jitka Plesnikova from comment #4) > Do you want to add the package to EPEL 7? I don't, but I do want to add it to EPEL 9.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8025330 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2276412-perl-toml-tiny/fedora-rawhide-x86_64/08025330-perl-TOML-Tiny/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPL-1.0-or-later OR Artistic-1.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Source file is ok Summary is ok Description is ok URL and Source0 are ok License FIX: License should be 'GPL-1.0-or-later OR Artistic-1.0-Perl' All tests passed FIX: Please set AUTHOR_TESTING or remove BRs perl(Test::Pod) and unset AUTHOR_TESTING BuildRequires FIX: Add build-requires coreutils it is needed for %{_fixperms} perl(B) - lib/TOML/Tiny/Writer.pm:8 perl(charnames) - lib/TOML/Tiny/Tokenizer.pm:7 perl(constant) - lib/TOML/Tiny/Writer.pm:13 perl(DateTime) - t/writer.t:4 perl(feature) - t/toml-test/valid/array/* perl(Math::BigFloat) - lib/TOML/Tiny/Parser.pm:13 perl(parent) - lib/TOML/Tiny.pm:12 perl(strict) - lib/TOML/Tiny.pm:4 perl(utf8) - lib/TOML/Tiny/Parser.pm:4 perl(warnings) - lib/TOML/Tiny.pm:5 FIX: Use 'perl(:VERSION) >= 5.18' instead of 'perl-interpreter >= 5.18' because the package has an epoch. NOTE: You can use utility 'tangerine' for getting list of almost all dependencies Because you don't want to add it to EPEL 7, please consider fixing these 'TODO' items: TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' If you use option NO_PACKLIST=1, please add version constrain to ExtUtils::MakeMaker >= 6.76 Remove "find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;". TODO: Use %{make_install} instead of "make pure_install". TODO: Remove "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'" It's not needed. $ rpm -qp --requires perl-TOML-Tiny-0.18-1.fc42.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(B) 1 perl(Carp) 1 perl(charnames) 1 perl(constant) 1 perl(Data::Dumper) 1 perl(Encode) 1 perl(Exporter) 1 perl-libs 1 perl(Math::BigFloat) 1 perl(Math::BigInt) 1 perl(parent) 1 perl(strict) 1 perl(TOML::Tiny::Grammar) 1 perl(TOML::Tiny::Parser) 1 perl(TOML::Tiny::Tokenizer) 1 perl(TOML::Tiny::Util) 1 perl(TOML::Tiny::Writer) 1 perl(utf8) 1 perl(:VERSION) >= 5.18.0 1 perl(warnings) Binary requires are Ok. TODO: Add optional run-require 'perl(Types::Serialiser)' lib/TOML/Tiny/Parser.pm:22 $ rpm -qp --provides perl-TOML-Tiny-0.18-1.fc42.noarch.rpm | sort | uniq -c 1 perl(TOML::Tiny) = 0.18 1 perl-TOML-Tiny = 0.18-1.fc42 1 perl(TOML::Tiny::Grammar) = 0.18 1 perl(TOML::Tiny::Parser) = 0.18 1 perl(TOML::Tiny::Tokenizer) = 0.18 1 perl(TOML::Tiny::Util) = 0.18 1 perl(TOML::Tiny::Writer) = 0.18 Binary provides are Ok. $ rpmlint ./perl-TOML-Tiny* ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-TOML-Tiny.src: E: unknown-key 98927a7e perl-TOML-Tiny.noarch: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized') perl-TOML-Tiny.src: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized') perl-TOML-Tiny.noarch: W: invalid-license Artistic-1.0 perl-TOML-Tiny.src: W: invalid-license Artistic-1.0 2 packages and 1 specfiles checked; 3 errors, 2 warnings, 7 filtered, 3 badness; has taken 0.4 s Rpmlint is ok TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. NOTE: There are base Perl Packaging Guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT Approved
All items addressed. SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perlimports/fedora-rawhide-x86_64/08034365-perl-TOML-Tiny/perl-TOML-Tiny-0.18-1.fc42.src.rpm
Created attachment 2047805 [details] The .spec file difference from Copr build 8025330 to 8042166
Copr build: https://copr.fedorainfracloud.org/coprs/build/8042166 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2276412-perl-toml-tiny/fedora-rawhide-x86_64/08042166-perl-TOML-Tiny/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The changes look good for me. I have only one thing. 'perl(:VERSION)' is provided by perl-libs which contains shared library. FIX: perl-interpreter has to still be in build-requires, but not used for version definition. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' item. Resolution: Approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-TOML-Tiny
FEDORA-2024-118fa5b9e7 (perl-TOML-Tiny-0.18-9.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-118fa5b9e7
FEDORA-2024-5dba05072a (perl-TOML-Tiny-0.18-9.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5dba05072a
FEDORA-2024-6cb0d7dd42 (perl-TOML-Tiny-0.18-9.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6cb0d7dd42
FEDORA-2024-6cb0d7dd42 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6cb0d7dd42 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6cb0d7dd42 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-5dba05072a has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5dba05072a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5dba05072a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-118fa5b9e7 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-118fa5b9e7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-118fa5b9e7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-118fa5b9e7 (perl-TOML-Tiny-0.18-9.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-5dba05072a (perl-TOML-Tiny-0.18-9.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-6cb0d7dd42 (perl-TOML-Tiny-0.18-9.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.