I left the Speed Dreams project to found my own project more in line with what I originally wanted to do with the project. I have just released version 1.0 of the cars-sports-racing project (also on Sourceforge: https://sourceforge.net/projects/cars-sports-racing/files/1.0.0/ The main difference at the moment is that this project is focused on unlocking challenges to be able to access the following races and other cars, I have also removed the OpenSceneGraph engine which remains a very good library but which is no longer developed ( just in maintenance), I'm leaning more towards an internal OpenGL3 engine. The long-term objective of this project is to have a career mode integrated directly into the internal engine. Do you think this project can be included in Fedora ? Cheers Xavier BERTAUX
The ticket summary is not in the correct format. Expected: Review Request: <main package name here> - <short summary here> Found: cars-sports-racing As a consequence, the package name cannot be parsed and submitted to be automatically build. Please modify the ticket summary and trigger a build by typing [fedora-review-service-build]. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Common issues for these kinds of games are usually licensing issues with either source or more often just game data. Review issues should contain already provide spec file with sources and rpm spec file defining packages, dependencies and licensing. For direct inclusion into Fedora it needs to have both code sources and data under free licenses. If there are some data parts, which do not have free license but are needed for package to be working, then this package cannot be part of Fedora. Since we have already torcs in Fedora, there is probably a way to make it legally acceptable way. - https://packages.fedoraproject.org/pkgs/torcs/torcs/index.html What is needed from contributor: - https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_contributor - https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_New_Contributors/
Created attachment 2031624 [details] base spec file for cars-sports-racing
the code is licensed under GPL2/GPL3 like Torcs or Speed Dreams, this code being inherited from these projects. Current data is under freeArts license or CC-BY-SA as the origin of the Speed Dreams project. I have a question about data licenses, are CC-BY-NC-SA licenses blocking for Fedora ? (I do not use this type of license on current data) I have attached a base spec file (based on the latest Speed Dreams spec) but modify for this project. I cannot test the construction but if modifications need to be made I can do so. I removed the dependency with OpenSceneGraph, this project does not use it unfortunately with my personal life and the development of this project I will not have time to be a contributor, but I can be in close collaboration with a maintainer. Cheers Xavier
do not delete the unversion files generated; thry go into the -devel package. furthermore, license is `GPL-2.0-only` for build, use %cmake_build over %make and %cmake_install over %make_install. uploade the spec file to copr https://copr.fedorainfracloud.org/ and run a test build and upload the direct links to the spec and srpm files here. thanks
the globs in %files are greedy. do not own the whold directory, only own your subdirectories and files.
Hi solomoncyl thank's for information. I will look a spec file. I will install a virtual machine with last fedora and build a rpm for test. Fedora prefers a whole package (all in one) or as I did for Mageia a main package and the additional seasons (extra cars and tracks) in separate packages. Cheers Xavier
Best to do separate to reduce bandwidth used while updating
ignor my comment on the license. it is acutually GPL-2.0-or-later
Hi solomoncyj I modified the spec based on the speed dreams spec. The removed cmake are the same ones that are removed in the speed dreams project (cmake included in the datas folders). The build runs correctly on fedora 41. I also made an rpmlint of the src.rpm and the spec link for spec : https://sourceforge.net/projects/cars-sports-racing/files/1.0.5/cars-sports-racing.spec link for src.rpm : https://sourceforge.net/projects/cars-sports-racing/files/1.0.5/cars-sports-racing-1.0.5-1.fc41.src.rpm For the moment it's just the base for extra season which will only contain data,I will make you a spec and a src.rpm once we have finalized this package Cheers Xavier
The ticket summary is not in the correct format. Expected: Review Request: <main package name here> - <short summary here> Found: Review Request: cars-sports-racing As a consequence, the package name cannot be parsed and submitted to be automatically build. Please modify the ticket summary and trigger a build by typing [fedora-review-service-build]. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
no no no no change it back to Review Request: cars-sports-racing - cars-sports-racing . my comment was to trigger the review bot
Sorry(In reply to solomoncyj from comment #13) > no no no no change it back to Review Request: cars-sports-racing - > cars-sports-racing . my comment was to trigger the review bot Sorry
Copr build: https://copr.fedorainfracloud.org/coprs/build/8259005 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2276549-cars-sports-racing-1.0.5/fedora-rawhide-x86_64/08259005-cars-sports-racing/fedora-review/review.txt Found issues: - License file COPYING.txt is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Not a valid SPDX expression 'GPLv2+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi solomoncyl, following the last email received, I modified the license by GPL-3.0-or-later AND GPL-2.0-or-later AND CC-BY-SA-4.0 since part of the code uses the GPL2 license (old code) and another uses the GPL3 license and the datas are under CC-BY-SA-4.0 license to avoid any warning. For the ambiguity on the COPYING.txt file (which corresponds to the GPL2 license I also modified in the file section so that it is taken as a license (following the procedure). I just uploaded the two files to the same place so the links remain the same. I did not increment the version number Release: 1%{?dist} tell me if this is necessary as it is or not Cheers Xavier
use %autorelease
Thank's so updated spec with Release: %autorelease, rebuild src.rpm and just push it on same place Cheers Xavier
[fedora-review-service-build] mandir}/man6/* is a bit greedy
Created attachment 2057783 [details] The .spec file difference from Copr build 8259005 to 8261998
Copr build: https://copr.fedorainfracloud.org/coprs/build/8261998 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2276549-cars-sports-racing-1.0.5/fedora-rawhide-x86_64/08261998-cars-sports-racing/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi Solomoncyj, sorry I found a bug that blocked players when they passed the first championship. So I made a small update to version 1.0.5 that fixes this problem I tried to reduce the cars-sports-racing man a bit The new link for spec : https://sourceforge.net/projects/cars-sports-racing/files/1.0.5.1/cars-sports-racing.spec The new link src.rpm : https://sourceforge.net/projects/cars-sports-racing/files/1.0.5.1/cars-sports-racing-1.0.5.1-1.fc41.src.rpm Another question for rpm datas season2 and other i need to create a new ticket or i can put the season 2 links on this ticket for you to check Cheers Xavier
Created attachment 2058185 [details] The .spec file difference from Copr build 8261998 to 8271849
Copr build: https://copr.fedorainfracloud.org/coprs/build/8271849 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2276549-cars-sports-racing-1.0.5/fedora-rawhide-x86_64/08271849-cars-sports-racing/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.