Bug 2276560 - Review Request: rust-enum-primitive-derive - Enum_primitive implementation using procedural macros to have a custom derive
Summary: Review Request: rust-enum-primitive-derive - Enum_primitive implementation us...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2276561
TreeView+ depends on / blocked
 
Reported: 2024-04-23 03:16 UTC by Orion Poplawski
Modified: 2024-05-08 01:23 UTC (History)
2 users (show)

Fixed In Version: rust-enum-primitive-derive-0.3.0-1.fc41
Clone Of:
Environment:
Last Closed: 2024-05-08 01:23:05 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Orion Poplawski 2024-04-23 03:16:41 UTC
Spec URL: https://orion.fedorapeople.org/rust-enum-primitive-derive.spec
SRPM URL: https://orion.fedorapeople.org/rust-enum-primitive-derive-0.3.0-1.fc41.src.rpm
Description:
Enum_primitive implementation using procedural macros to have a custom
derive.

Fedora Account System Username: orion

Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=116756900

Comment 1 Fabio Valentini 2024-05-07 15:38:10 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

If you have the time, it would be great if you could look at one of my Rust packages that's currently waiting for review.

Comment 2 Fedora Admin user for bugzilla script actions 2024-05-08 01:09:06 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-enum-primitive-derive

Comment 3 Orion Poplawski 2024-05-08 01:23:05 UTC
Thanks for the review.  Checked in and built.


Note You need to log in before you can comment on or make changes to this bug.