Spec URL: ftp://czar.eas.yorku.ca/pub/gimmie/gimmie.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/gimmie/gimmie-0.2.3-1.src.rpm Description: Gimmie is an elegant way to think about how you use your desktop computer.
unable to get srpm file --> error 550 will you check it out please ?
Sorry about that, should be there now.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPMS. + source files match upstream. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is LGPL matched with COPYING file entry. + %doc is right (NEWS can be dropped from this field). + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + post ans postun is correctly set. + python_sitelib present. + Macro use appears rather consistent. (just use %{name}insted of gimmie + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. ------- I can approved it cause i'm not a sponsor. You should think about adding a desktop entry for this app. -------
(In reply to comment #3) > ------- > I can approved it cause i'm not a sponsor. > Thanks for the review. Of course you don't have to be a sponsor to approve a package, but you have to be in the fedorabug group in the Fedora accounts setup. You should also take a look at the review procedures at http://fedoraproject.org/wiki/PackageReviewGuidelines. Parag AN has already assigned this review to himself. > You should think about adding a desktop entry for this app. gimmie works as an applet that can be added to the panel. > > ------- >
Hi Xavier, Kindly assign review to yourself and change blockers to 163778 when you want to review and approve any package.
thx Parag, so, i'll wait that someone add me in fedorabugs group ans sponsor me. i'll just make unofficial review then
s/ans/and
Everything looks Ok to me.
Approved.
gimmie borks on rawhide. Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/gimmie/gimmie_gui.py", line 253, in do_raise self.tooltip.position_to_rect(rect, screen) SystemError: Python/getargs.c:1245: bad argument to internal function
worksforme on x86_64 rawhide. I guess it mean there's probably a needed python module that I've failed to include in the Requires tags, will investigate.
(In reply to comment #10) > gimmie borks on rawhide. > > Traceback (most recent call last): > File "/usr/lib/python2.5/site-packages/gimmie/gimmie_gui.py", line 253, in > do_raise > self.tooltip.position_to_rect(rect, screen) > SystemError: Python/getargs.c:1245: bad argument to internal function > Do you have all of gnome-python2-gnomekeyring, PyXML, python-sexy, and gnome-python2-canvas installed ? If not, can you please install them and check if you still hit the error.
The issue in comment #10 has been fixed, and package built.