Bug 227717 - Review Request: gimmie - Gnome panel revisited
Review Request: gimmie - Gnome panel revisited
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2007-02-07 13:46 EST by Deji Akingunola
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-13 17:27:55 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
notting: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Deji Akingunola 2007-02-07 13:46:38 EST
Spec URL: ftp://czar.eas.yorku.ca/pub/gimmie/gimmie.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/gimmie/gimmie-0.2.3-1.src.rpm
Description: 
Gimmie is an elegant way to think about how you use your desktop computer.
Comment 1 Xavier Lamien 2007-02-08 09:06:38 EST
unable to get srpm file --> error 550
will you check it out please ?
Comment 2 Deji Akingunola 2007-02-08 09:17:26 EST
Sorry about that, should be there now.
Comment 3 Xavier Lamien 2007-02-08 13:07:09 EST
Review:

+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPMS.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is LGPL matched with COPYING file entry.
+ %doc is right (NEWS can be dropped from this field).
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ post ans postun is correctly set.
+ python_sitelib present.
+ Macro use appears rather consistent. (just use %{name}insted of gimmie
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage exists
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.

-------
I can approved it cause i'm not a sponsor.

You should think about adding a desktop entry for this app.

-------
Comment 4 Deji Akingunola 2007-02-08 13:16:49 EST
(In reply to comment #3)

> -------
> I can approved it cause i'm not a sponsor.
> 
Thanks for the review. Of course you don't have to be a sponsor to approve a
package, but you have to be in the fedorabug group in the Fedora accounts setup.
You should also take a look at the review procedures at
http://fedoraproject.org/wiki/PackageReviewGuidelines. 
Parag AN has already assigned this review to himself.
 
> You should think about adding a desktop entry for this app.
gimmie works as an applet that can be added to the panel.

> 
> -------
> 

Comment 5 Parag AN(पराग) 2007-02-08 23:35:08 EST
Hi Xavier,
  Kindly assign review to yourself and change blockers to 163778 when you want
to review and approve any package. 
Comment 6 Xavier Lamien 2007-02-09 07:57:11 EST
thx Parag,
so, i'll wait that someone add me in fedorabugs group ans sponsor me.
i'll just make unofficial review then
Comment 7 Xavier Lamien 2007-02-09 07:58:18 EST
s/ans/and
Comment 8 Parag AN(पराग) 2007-02-11 23:34:47 EST
Everything looks Ok to me.

Comment 9 Parag AN(पराग) 2007-02-11 23:36:45 EST
Approved.
Comment 10 ritz 2007-02-12 07:15:40 EST
gimmie borks on rawhide.

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/gimmie/gimmie_gui.py", line 253, in
do_raise
    self.tooltip.position_to_rect(rect, screen)
SystemError: Python/getargs.c:1245: bad argument to internal function
Comment 11 Deji Akingunola 2007-02-12 09:00:56 EST
worksforme on x86_64 rawhide. I guess it mean there's probably a needed python
module that I've failed to include in the Requires tags, will investigate.
Comment 12 Deji Akingunola 2007-02-12 17:40:24 EST
(In reply to comment #10)
> gimmie borks on rawhide.
> 
> Traceback (most recent call last):
>   File "/usr/lib/python2.5/site-packages/gimmie/gimmie_gui.py", line 253, in
> do_raise
>     self.tooltip.position_to_rect(rect, screen)
> SystemError: Python/getargs.c:1245: bad argument to internal function
> 
Do you have all of gnome-python2-gnomekeyring, PyXML, python-sexy, and
gnome-python2-canvas installed ? If not, can you please install them and check
if you still hit the error.
Comment 13 Deji Akingunola 2007-02-13 17:27:55 EST
The issue in comment #10 has been fixed, and package built.

Note You need to log in before you can comment on or make changes to this bug.