Spec URL: https://dcavalca.fedorapeople.org/review/gattlib/gattlib.spec SRPM URL: https://dcavalca.fedorapeople.org/review/gattlib/gattlib-0.7.1-1.fc41.src.rpm Description: GattLib is a library used to access Generic Attribute Profile (GATT) protocol of BLE (Bluetooth Low Energy) devices. It has been introduced to allow to build applications that could easily communicate with BLE devices. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=116891985
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: pcre-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "GNU General Public License v2.0 or later", "GNU General Public License, Version 2", "GNU Lesser General Public License v2.1 or later", "BSD 2-Clause License". 35 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/gattlib/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/pkgconfig [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5608 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gattlib- examples [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: gattlib-0.7.1-1.fc41.x86_64.rpm gattlib-devel-0.7.1-1.fc41.x86_64.rpm gattlib-examples-0.7.1-1.fc41.x86_64.rpm gattlib-debuginfo-0.7.1-1.fc41.x86_64.rpm gattlib-debugsource-0.7.1-1.fc41.x86_64.rpm gattlib-0.7.1-1.fc41.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp34vfjj0p')] checks: 32, packages: 6 gattlib-devel.x86_64: W: no-documentation gattlib-examples.x86_64: W: no-documentation ========= 6 packages and 0 specfiles checked; 0 errors, 2 warnings, 35 filtered, 0 badness; has taken 0.6 s ========== Rpmlint (debuginfo) ------------------- Checking: gattlib-examples-debuginfo-0.7.1-1.fc41.x86_64.rpm gattlib-debuginfo-0.7.1-1.fc41.x86_64.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbdm4ir89')] checks: 32, packages: 2 ========= 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 24 filtered, 0 badness; has taken 0.3 s ========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 gattlib-devel.x86_64: W: no-documentation gattlib-examples.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 2 warnings, 51 filtered, 0 badness; has taken 1.4 s Source checksums ---------------- https://github.com/labapart/gattlib/archive/0.7.1/gattlib-0.7.1.tar.gz : CHECKSUM(SHA256) this package : e0eb53928d0432a663011920fab477c8ecb95653ff6e6b7f8c4acd87f957e2cb CHECKSUM(SHA256) upstream package : e0eb53928d0432a663011920fab477c8ecb95653ff6e6b7f8c4acd87f957e2cb Requires -------- gattlib (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) rtld(GNU_HASH) gattlib-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gattlib(x86-64) libgattlib.so.0.7.1()(64bit) pkgconfig(glib-2.0) gattlib-examples (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgattlib.so.0.7.1()(64bit) rtld(GNU_HASH) gattlib-debuginfo (rpmlib, GLIBC filtered): gattlib-debugsource (rpmlib, GLIBC filtered): Provides -------- gattlib: gattlib gattlib(x86-64) libgattlib.so.0.7.1()(64bit) gattlib-devel: gattlib-devel gattlib-devel(x86-64) pkgconfig(gattlib) gattlib-examples: gattlib-examples gattlib-examples(x86-64) gattlib-debuginfo: debuginfo(build-id) gattlib-debuginfo gattlib-debuginfo(x86-64) libgattlib.so.0.7.1-0.7.1-1.fc41.x86_64.debug()(64bit) gattlib-debugsource: gattlib-debugsource gattlib-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n gattlib-0.7.1-1.fc41.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: R, fonts, PHP, Python, SugarActivity, Ocaml, Java, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
[!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License file installed when any subpackage combination is installed. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. https://github.com/labapart/gattlib/issues/128 noted in the specfile. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/pkgconfig pkgconf-pkg-config [!]: Package contains no bundled libraries without FPC exception. It seems bluez is bundled in some form? Maybe it's just in the source and the following addresses this: # Set shared library version sed -i {bluez,dbus}/CMakeLists.txt \ -e '/add_library(%{name}/aset_target_properties(%{name} PROPERTIES VERSION %{version})' [!]: Latest version is packaged. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Latest version includes the referenced patch. [!]: %check is present and all tests pass. Doesn't seem upstream has checks. Does that mean this passes?