Spec URL: https://atim.fedorapeople.org/gtk4-layer-shell.spec SRPM URL: https://atim.fedorapeople.org/gtk4-layer-shell-1.0.2-1.fc40.src.rpm Description: A library for using the Layer Shell Wayland protocol with GTK4. With this library you can build desktop shell components such as panels, notifications and wallpapers. You can use it to anchor your windows to a corner or edge of the output, or stretch them across the entire output. This Library is compatible with C, C++ and any language that supports GObject introspection files (Python, Vala, etc). Fedora Account System Username: atim
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=116903501
Tests: 3 from 38 tests failed. Please help with tests to speedup packaging process. https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/07375528-gtk4-layer-shell/builder-live.log.gz
Spec URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/07380559-gtk4-layer-shell/gtk4-layer-shell.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/07380559-gtk4-layer-shell/gtk4-layer-shell-1.0.2-1.fc41.src.rpm Review: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/07380559-gtk4-layer-shell/fedora-review/review.txt Thanks Jakob Probst for help with tests.
Smoke test could be safely ignored, approved by upstream, see: https://github.com/wmww/gtk4-layer-shell/issues/32#issuecomment-2089302515 I'll document this in Spec file before importing package to Fedora repos.
Taking this.
[x] package name is OK [x] license is acceptable for Fedora: MIT [x] builds and installs OK [x] BR/P/R look correct [x] no scriptlets needed or present [x] rpmlint finds no big issue --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)". 94 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/gtk4-layer-shell/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/src, /usr/lib, /usr, /usr/share/licenses, /usr/lib64/girepository-1.0, /usr/lib64/pkgconfig, /usr/lib64, /usr/share, /usr/share/doc, /usr/include, /usr/share/vala/vapi, /usr/src/debug, /usr/share/vala, /usr/share/gir-1.0 [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/src, /usr, /usr/lib64, /usr/share, /usr/share/licenses, /usr/lib64/girepository-1.0, /usr/lib, /usr/share/doc, /usr/share/vala, /usr/include, /usr/share/gir-1.0, /usr/share/vala/vapi, /usr/lib64/pkgconfig, /usr/src/debug [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6530 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: gtk4-layer-shell-1.0.2-1.fc41.x86_64.rpm gtk4-layer-shell-devel-1.0.2-1.fc41.x86_64.rpm gtk4-layer-shell-debuginfo-1.0.2-1.fc41.x86_64.rpm gtk4-layer-shell-debugsource-1.0.2-1.fc41.x86_64.rpm gtk4-layer-shell-1.0.2-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpk2scq8lv')] checks: 32, packages: 5 gtk4-layer-shell-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 1 warnings, 26 filtered, 0 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: gtk4-layer-shell-debuginfo-1.0.2-1.fc41.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa6cuh9d9')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "gtk4-layer-shell-debugsource". (none): E: there is no installed rpm "gtk4-layer-shell-debuginfo". (none): E: there is no installed rpm "gtk4-layer-shell". (none): E: there is no installed rpm "gtk4-layer-shell-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/wmww/gtk4-layer-shell/archive/v1.0.2/gtk4-layer-shell-1.0.2.tar.gz : CHECKSUM(SHA256) this package : a3a827845612fa15de30734eb29c01db329c32f8e279d8bc5251facc69220b86 CHECKSUM(SHA256) upstream package : a3a827845612fa15de30734eb29c01db329c32f8e279d8bc5251facc69220b86 Requires -------- gtk4-layer-shell (rpmlib, GLIBC filtered): libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-4.so.1()(64bit) libwayland-client.so.0()(64bit) rtld(GNU_HASH) gtk4-layer-shell-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gtk4-layer-shell(x86-64) libgtk4-layer-shell.so.0()(64bit) pkgconfig(gtk4) pkgconfig(wayland-client) gtk4-layer-shell-debuginfo (rpmlib, GLIBC filtered): gtk4-layer-shell-debugsource (rpmlib, GLIBC filtered): Provides -------- gtk4-layer-shell: gtk4-layer-shell gtk4-layer-shell(x86-64) libgtk4-layer-shell.so.0()(64bit) gtk4-layer-shell-devel: gtk4-layer-shell-devel gtk4-layer-shell-devel(x86-64) pkgconfig(gtk4-layer-shell-0) gtk4-layer-shell-debuginfo: debuginfo(build-id) gtk4-layer-shell-debuginfo gtk4-layer-shell-debuginfo(x86-64) libgtk4-layer-shell.so.1.0.2-1.0.2-1.fc41.x86_64.debug()(64bit) gtk4-layer-shell-debugsource: gtk4-layer-shell-debugsource gtk4-layer-shell-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name gtk4-layer-shell --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: R, PHP, SugarActivity, Java, Perl, Haskell, Ocaml, fonts, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
A minor issue: > /usr/lib64/libgtk4-layer-shell.so.0 > /usr/lib64/libgtk4-layer-shell.so.1.0.2 In your spec file, you use %{_libdir}/lib%{name}.so.* to include these two files. https://github.com/wmww/gtk4-layer-shell/blob/a689a399d37d174f2e93442e3adc931a9d8dee90/src/meson.build#L18-L19 Well, My suggested revision is: %{_libdir}/lib%{name}.so.0 %{_libdir}/lib%{name}.so.%{version} Hope it may facilitate you to catch the soversion bump. This amendment can be adopted when you import this if you would like to do. The package is approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/gtk4-layer-shell
FEDORA-2024-8b0daf68fd (gtk4-layer-shell-1.0.2-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8b0daf68fd
FEDORA-2024-8b0daf68fd (gtk4-layer-shell-1.0.2-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-8b6ccbf64e (gtk4-layer-shell-1.0.2-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8b6ccbf64e
FEDORA-2024-57e8a3986b (gtk4-layer-shell-1.0.2-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-57e8a3986b
(In reply to Felix Wang from comment #7) Thanks for review. Fixed before import. But look like this breaks tests for some reason https://kojipkgs.fedoraproject.org//work/tasks/5080/117345080/build.log Not only for s390x arch. I also get this test FAIL on local machine. Tried to glob but still this one test fails: %{_libdir}/lib%{name}.so.1* %{_libdir}/lib%{name}.so.0* --- Built for >= f39. If you need gtk4-layer-shell for f38 and EPEL 9 please let me know.
FEDORA-2024-57e8a3986b has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-57e8a3986b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-57e8a3986b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-8b6ccbf64e has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8b6ccbf64e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8b6ccbf64e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.