Bug 2277418 - Review Request: golang-github-notedit-janus - support websocket transport for Janus
Summary: Review Request: golang-github-notedit-janus - support websocket transport fo...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2277423
TreeView+ depends on / blocked
 
Reported: 2024-04-26 20:26 UTC by Renich Bon Ciric
Modified: 2024-05-07 23:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-05-07 23:26:51 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Renich Bon Ciric 2024-04-26 20:26:39 UTC
Spec URL: https://fedorapeople.org/~renich/signaling/golang-github-notedit-janus.spec
SRPM URL: https://fedorapeople.org/~renich/signaling/golang-github-notedit-janus-0-0.1.20240423gitfdce1b1.fc39.src.rpm
Description: support websocket transport for Janus
Fedora Account System Username: renich

Comment 1 Mikel Olasagasti Uranga 2024-04-26 20:39:04 UTC
No need to change the patch, but for future references you can use this other option if you want to avoid having to maintain a patch:

%if %{with check}
%check
for test in "Test_Connect" \
; do
awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test)
done
%gocheck
%endif

Comment 2 Mikel Olasagasti Uranga 2024-04-27 11:29:21 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-05-07 23:11:41 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-notedit-janus

Comment 4 Fedora Update System 2024-05-07 23:23:43 UTC
FEDORA-2024-bc365d12df (golang-github-notedit-janus-0-0.1.20240423gitfdce1b1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-bc365d12df

Comment 5 Fedora Update System 2024-05-07 23:26:51 UTC
FEDORA-2024-bc365d12df (golang-github-notedit-janus-0-0.1.20240423gitfdce1b1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.