Bug 2278422 - Review Request: python-nbdime - Diff and merge of Jupyter notebooks
Summary: Review Request: python-nbdime - Diff and merge of Jupyter notebooks
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: wojnilowicz
QA Contact: Fedora Extras Quality Assurance
URL: https://nbdime.readthedocs.io/
Whiteboard:
Depends On: 2278421
Blocks: 2278423
TreeView+ depends on / blocked
 
Reported: 2024-05-01 20:25 UTC by Jerry James
Modified: 2024-05-17 19:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jerry James 2024-05-01 20:25:50 UTC
Spec URL: https://jjames.fedorapeople.org/python-nbdime/python-nbdime.spec
SRPM URL: https://jjames.fedorapeople.org/python-nbdime/python-nbdime-4.0.1-1.fc41.src.rpm
Fedora Account System Username: jjames
Description: Nbdime provides tools for diffing and merging of Jupyter notebooks.
- nbdiff: compare notebooks in a terminal-friendly way
- nbmerge: three-way merge of notebooks with automatic conflict resolution
- nbdiff-web: shows you a rich rendered diff of notebooks
- nbmerge-web: gives you a web-based three-way merge tool for notebooks
- nbshow: present a single notebook in a terminal-friendly way

Note that this package can only be built for x86_64 and aarch64.  It uses nx to build, and requires a binary nx package, which is only available for those 2 architectures.  If someone knows how to get around that restriction, I would be very happy if you would tell me.

See https://copr.fedorainfracloud.org/coprs/jjames/Jupyter/ for builds of this package.

I am willing to swap reviews.

Comment 1 Fedora Review Service 2024-05-01 20:30:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7397094
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2278422-python-nbdime/fedora-rawhide-x86_64/07397094-python-nbdime/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 wojnilowicz 2024-05-17 19:03:36 UTC
It looks a bit scary :)

Before I look into it deeper:
1) Previous post from Fedora Review Service says it doesn't build. Could you fix that?
2) Could you use 
https://src.fedoraproject.org/rpms/python-jupytext/blob/rawhide/f/python-jupytext.spec#_52
https://src.fedoraproject.org/rpms/python-jupytext/blob/rawhide/f/python-jupytext.spec#_144
instead of
"# Move the configuration files to where we want them"?
3) Is %{_bindir}/nbdime not missing a man page?


Note You need to log in before you can comment on or make changes to this bug.