Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/review/fedora-rawhide-x86_64/07398651-amazon-ec2-utils/amazon-ec2-utils.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/review/fedora-rawhide-x86_64/07398651-amazon-ec2-utils/amazon-ec2-utils-2.2.0-1.fc41.src.rpm Description: Contains a set of utilities and settings for Linux deployments in EC2. Fedora Account System Username: mhayden
Copr build: https://copr.fedorainfracloud.org/coprs/build/7398669 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2278626-amazon-ec2-utils/fedora-rawhide-x86_64/07398669-amazon-ec2-utils/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I take this Review
@mhayden looks good, just one finding related to licensing that you should address: # Everything MIT except doc/ec2-metadata.8 and doc/ebsnvme-id.8 are CC-BY-SA-4.0 License: MIT AND CC-BY-SA-4.0 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [-]: Package requires other packages for directories it uses. Note: No known owner of /etc/udev/rules.d, /usr/sbin, /usr/lib/udev/rules.d, /usr/share/doc, /etc/udev, /usr/bin, /usr/lib/udev, /usr/share/man, /usr, /usr/lib, /usr/share/licenses, /usr/share, /usr/share/man/man8, /etc [-]: Package must own all directories that it creates. Note: Directories without known owners: /etc/udev/rules.d, /usr/sbin, /usr/lib/udev/rules.d, /usr/share/doc, /etc/udev, /usr/bin, /usr/lib/udev, /usr/share/man, /usr, /usr/lib, /usr/share/licenses, /usr/share, /usr/share/man/man8, /etc [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 567 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: amazon-ec2-utils-2.2.0-1.fc41.noarch.rpm amazon-ec2-utils-2.2.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppij21gk6')] checks: 32, packages: 2 amazon-ec2-utils.noarch: W: udev-rule-in-etc /etc/udev/rules.d/60-cdrom_id.rules amazon-ec2-utils.noarch: W: only-non-binary-in-usr-lib amazon-ec2-utils.noarch: W: non-conffile-in-etc /etc/udev/rules.d/60-cdrom_id.rules amazon-ec2-utils.noarch: W: no-manual-page-for-binary ec2nvme-nsid amazon-ec2-utils.noarch: W: no-manual-page-for-binary ec2udev-vbd 2 packages and 0 specfiles checked; 0 errors, 5 warnings, 7 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "amazon-ec2-utils". There are no files to process nor additional arguments. Nothing to do, aborting. Source checksums ---------------- https://github.com/amazonlinux/amazon-ec2-utils//archive/refs/tags/v2.2.0.tar.gz : CHECKSUM(SHA256) this package : 4fd0c06dfa6959d6e0b197ce4f5eddb9f07822d8d9810d1ae7e886d7fd055df6 CHECKSUM(SHA256) upstream package : 4fd0c06dfa6959d6e0b197ce4f5eddb9f07822d8d9810d1ae7e886d7fd055df6 Requires -------- amazon-ec2-utils (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/python3 curl python3 Provides -------- amazon-ec2-utils: amazon-ec2-utils ec2-metadata Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name amazon-ec2-utils --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, Perl, R, Ocaml, Haskell, SugarActivity, Java, C/C++, PHP, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/review/fedora-40-x86_64/07426747-amazon-ec2-utils/amazon-ec2-utils.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/review/fedora-40-x86_64/07426747-amazon-ec2-utils/amazon-ec2-utils-2.2.0-1.fc40.src.rpm License fixed.
Created attachment 2032176 [details] The .spec file difference from Copr build 7398669 to 7426794
Copr build: https://copr.fedorainfracloud.org/coprs/build/7426794 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2278626-amazon-ec2-utils/fedora-rawhide-x86_64/07426794-amazon-ec2-utils/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks Major, looks good, approved!
The Pagure repository was created at https://src.fedoraproject.org/rpms/amazon-ec2-utils
FEDORA-2024-0f71aef5c7 (amazon-ec2-utils-2.2.0-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0f71aef5c7
FEDORA-2024-0f71aef5c7 (amazon-ec2-utils-2.2.0-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.