Bug 2278645 - bat bundles sublime language support and themes as opaque binary blobs
Summary: bat bundles sublime language support and themes as opaque binary blobs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rust-bat
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-02 14:35 UTC by Fabio Valentini
Modified: 2024-06-03 12:17 UTC (History)
2 users (show)

Fixed In Version: rust-bat-0.24.0-6.fc41
Clone Of:
Environment:
Last Closed: 2024-06-03 12:17:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Fabio Valentini 2024-05-02 14:35:26 UTC
It appears that "bat" started bundling Sublime language definitions and themes in a binary blob format as assets at some point - though since the bundled language support and themes all seem to be years old at this point, I assume that they were already present when this package was initially added to Fedora, but were missed.

The Sublime language definitions and themes carry individual licenses, which are not determinable from the contents of the published crate, but only by either looking at the files from which the binary blobs are generated, or by querying the blobs at runtime (`bat --acknowledgements`).

The language definitions for syntax highlighting appear to be from Sublime, with extra ones from many different authors:
https://github.com/sharkdp/bat/tree/master/assets/syntaxes

While the themes are all from different sources:
https://github.com/sharkdp/bat/tree/master/assets/themes

At first glance I see only bundled projects that are "MIT" or "Apache-2.0" licensed, but I haven't checked everything.

I'm not sure if generated content of this form (third-party syntax highlighting support + themes packed as binary blobs) is acceptable for Fedora, or if it would need to be re-generated from scratch.

Either way, I think the bundled content would need to be declared, and the license tag amended to reflect the license of the bundled content.

Comment 1 Fabio Valentini 2024-05-02 14:39:30 UTC
Checking the version of bat that was initially reviewed here:
https://bugzilla.redhat.com/show_bug.cgi?id=1624737

Version 0.6.1 already had bundled binary blobs, but without embedded license texts - so these must have been added later.
So this was definitely missed during initial package review.

Comment 2 Fabio Valentini 2024-05-02 15:25:38 UTC
The license for Sublime Text language definitions for syntax highlighting is unknown to me, posted to the legal list for help:
https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/FW5MQLP42D2TYGKZJWE2MAF5TBKYKA3A/

Comment 3 Fabio Valentini 2024-05-16 14:12:39 UTC
I have now filed a license review request on GitLab:
https://gitlab.com/fedora/legal/fedora-license-data/-/issues/516

Comment 4 Fedora Update System 2024-06-03 12:05:47 UTC
FEDORA-2024-639a8c11f3 (rust-asyncgit-0.26.3-1.fc41, rust-bat-0.24.0-6.fc41, and 5 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-639a8c11f3

Comment 5 Fedora Update System 2024-06-03 12:17:37 UTC
FEDORA-2024-639a8c11f3 (rust-asyncgit-0.26.3-1.fc41, rust-bat-0.24.0-6.fc41, and 5 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.